Re: ar9170-fw II

[Christian Lamparter <chunkeey@googlemail.com>]

On Wednesday 12 May 2010 00:02:03 David H. Lynch Jr. wrote:
> On 05/02/2010 08:52 AM, Christian Lamparter wrote:
> > Well, then you have two more good reasons why to use carl9170:
> >   * carl9170 has the ability to store additional per-frame data.
> >     In fact, if you don't need to have a different retry rates
> >     you could realloc the 3 * 32 bit "rr" (as in retry rate)
> >     array in the carl9170_tx_superdesc and _carl9170_tx_superdesc
> >     struct (see wlan.h) for your purposes (storage for your time values).
> >
> >     And if you fetched all the data, everything will be sent
> >     with an ordinary tx status feedback report to the application
> >     (add the timer fields into carl9170_tx_status and _carl9170_tx_status
> >      struct - see fwcmd.h)
>      cmd.h __check() tests for sizeof(carl9170_tx_status) != 2
>      is there an assumption somewhere that carl9170_tx_status == 2 ?
good catch!

I have now replace some of those meaningless numerical values with
precalculated #defines *_SIZE.

This way, firmware and drivers can verify the structs sizes
and check whenever the compiler really did what it was supposed
to do.

Regards,
	Chr