All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David H. Lynch Jr." <dhlii@dlasys.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Subject: carl9170 1.0.9
Date: Sat, 22 May 2010 15:13:50 -0400	[thread overview]
Message-ID: <4BF82CEE.8020502@dlasys.net> (raw)
In-Reply-To: <201005021452.01101.chunkeey@googlemail.com>

	
some items I have found while making my changes to the code.


	In firmware_source/carlfw/src/wlan.c you have aloop to read the TSF 
timer to make sure there is no roll over. According to the docs I have 
when TSF_LOW is read, TSF_HI is automatically concurrently copied to a 
temp register so that an immediate read of TSF_HI will get the value 
that was present when TSF_LO was read.

	Presuming the docs are correct - and this feature is common in 
multi-word timers you should be able to save some code.
	Also with some complex casting or another pointer you can read directly 
to your destination and save a memcpy()

	I beleive the timer_init() routine in carlfw/src/timer.c can not be 
called for more than one timer. Any subsequent call will clear the 
interrupt and mode bits for the previous timer.

	I have not completely tracked these down, but the new config system 
must be missing some dependencies, because I can configure and build 
firmware that will not load.
	In carlfw/src/cmd.c the CARL9170_CMD_PSM case needs ifdef'd with 
CONFIG_CARL9170FW_PSM or it will not build with PSM disabled.



-- 
Dave Lynch 					  	    DLA Systems
Software Development:  				         Embedded Linux
717.587.7774 	       dhlii@dlasys.net 	  http://www.dlasys.net
Over 25 years' experience in platforms, languages, and technologies 
toonumerous to list.

"Any intelligent fool can make things bigger and more complex... It 
takes a touch of genius - and a lot of courage to move in the opposite 
direction."
Albert Einstein


  parent reply	other threads:[~2010-05-22 19:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-01 10:19 ar9170-fw II David H. Lynch Jr.
2010-05-01 17:19 ` Christian Lamparter
2010-05-01 18:23   ` David H. Lynch Jr.
2010-05-01 20:45     ` Christian Lamparter
2010-05-02  7:47       ` Benoit Papillault
2010-05-02 11:14         ` David H. Lynch Jr.
2010-05-02 12:52           ` Christian Lamparter
2010-05-02 13:47             ` David H. Lynch Jr.
2010-05-05 18:41             ` carl9170 1.0.5.1 David H. Lynch Jr.
2010-05-05 19:59               ` 2.6.34-rc6 pci bridge problems Christian Lamparter
2010-05-06 15:09                 ` Bjorn Helgaas
2010-05-07 15:46                   ` Bjorn Helgaas
2010-05-07 18:44                     ` Christian Lamparter
2010-05-06  0:11               ` carl9170 1.0.5.1 Luis R. Rodriguez
2010-05-11 22:02             ` ar9170-fw II David H. Lynch Jr.
2010-05-11 23:27               ` Christian Lamparter
2010-05-21  7:50             ` carl9170 1.0.6 David H. Lynch Jr.
2010-05-21 21:35             ` carl9170 1.0.6 carl9170_tx_superdesc David H. Lynch Jr.
2010-05-21 22:55               ` Christian Lamparter
2010-05-22  1:09                 ` David H. Lynch Jr.
2010-05-22 19:13             ` David H. Lynch Jr. [this message]
2010-05-23  1:34               ` carl9170 1.0.9 Christian Lamparter
2010-05-23  5:30                 ` David H. Lynch Jr.
2010-05-23  6:30                 ` carl9170 1.0.9.1 David H. Lynch Jr.
2010-05-03 21:39     ` ar9170-fw II Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF82CEE.8020502@dlasys.net \
    --to=dhlii@dlasys.net \
    --cc=chunkeey@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.