From: Andrew Morton <akpm@linux-foundation.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, Pete Eberlein <pete@sensoray.com>,
Ross Cohen <rcohen@snurgle.org>, Greg KH <greg@kroah.com>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH -mm] remove deprecated dma_sync_single and dma_sync_sg
Date: Wed, 12 May 2010 23:28:03 +0000 [thread overview]
Message-ID: <20100512162803.ccb05cb8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100511101308R.fujita.tomonori@lab.ntt.co.jp>
On Tue, 11 May 2010 10:13:23 +0900
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> Since 2.6.5, it had been commented, 'for backwards compatibility,
> removed in 2.7.x'. Since 2.6.31, it have been marked as __deprecated.
>
> I think that we can remove the API safely now.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
> include/linux/dma-mapping.h | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 2ea1494..89b7e1a 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -95,21 +95,6 @@ static inline int is_device_dma_capable(struct device *dev)
> #include <asm-generic/dma-mapping-broken.h>
> #endif
>
> -/* for backwards compatibility, removed soon */
> -static inline void __deprecated dma_sync_single(struct device *dev,
> - dma_addr_t addr, size_t size,
> - enum dma_data_direction dir)
> -{
> - dma_sync_single_for_cpu(dev, addr, size, dir);
> -}
> -
> -static inline void __deprecated dma_sync_sg(struct device *dev,
> - struct scatterlist *sg, int nelems,
> - enum dma_data_direction dir)
> -{
> - dma_sync_sg_for_cpu(dev, sg, nelems, dir);
> -}
> -
> static inline u64 dma_get_mask(struct device *dev)
> {
> if (dev && dev->dma_mask && *dev->dma_mask)
drivers/staging/go7007/saa7134-go7007.c uses dma_sync_single().
arch/ia64/kernel/machvec.c has functions machvec_dma_sync_single() and
machvec_dma_sync_sg() which might be dead code.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, Pete Eberlein <pete@sensoray.com>,
Ross Cohen <rcohen@snurgle.org>, Greg KH <greg@kroah.com>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH -mm] remove deprecated dma_sync_single and dma_sync_sg API
Date: Wed, 12 May 2010 16:28:03 -0700 [thread overview]
Message-ID: <20100512162803.ccb05cb8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100511101308R.fujita.tomonori@lab.ntt.co.jp>
On Tue, 11 May 2010 10:13:23 +0900
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> Since 2.6.5, it had been commented, 'for backwards compatibility,
> removed in 2.7.x'. Since 2.6.31, it have been marked as __deprecated.
>
> I think that we can remove the API safely now.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
> include/linux/dma-mapping.h | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 2ea1494..89b7e1a 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -95,21 +95,6 @@ static inline int is_device_dma_capable(struct device *dev)
> #include <asm-generic/dma-mapping-broken.h>
> #endif
>
> -/* for backwards compatibility, removed soon */
> -static inline void __deprecated dma_sync_single(struct device *dev,
> - dma_addr_t addr, size_t size,
> - enum dma_data_direction dir)
> -{
> - dma_sync_single_for_cpu(dev, addr, size, dir);
> -}
> -
> -static inline void __deprecated dma_sync_sg(struct device *dev,
> - struct scatterlist *sg, int nelems,
> - enum dma_data_direction dir)
> -{
> - dma_sync_sg_for_cpu(dev, sg, nelems, dir);
> -}
> -
> static inline u64 dma_get_mask(struct device *dev)
> {
> if (dev && dev->dma_mask && *dev->dma_mask)
drivers/staging/go7007/saa7134-go7007.c uses dma_sync_single().
arch/ia64/kernel/machvec.c has functions machvec_dma_sync_single() and
machvec_dma_sync_sg() which might be dead code.
next prev parent reply other threads:[~2010-05-12 23:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 1:13 [PATCH -mm] remove deprecated dma_sync_single and dma_sync_sg API FUJITA Tomonori
2010-05-12 23:28 ` Andrew Morton [this message]
2010-05-12 23:28 ` Andrew Morton
2010-05-13 3:27 ` [PATCH -mm] remove deprecated dma_sync_single and dma_sync_sg FUJITA Tomonori
2010-05-13 3:27 ` [PATCH -mm] remove deprecated dma_sync_single and dma_sync_sg API FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512162803.ccb05cb8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=greg@kroah.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pete@sensoray.com \
--cc=rcohen@snurgle.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.