All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
To: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 2/5] musb: use system DMA to fix Inventra DMA issue on RTL-1.4
Date: Wed, 12 May 2010 20:51:14 +0300	[thread overview]
Message-ID: <20100512175113.GA3285@gandalf> (raw)
In-Reply-To: <1273664979-493-2-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>

On Wed, May 12, 2010 at 05:19:36PM +0530, Ajay Kumar Gupta wrote:
> MUSB RTL version 1.4 has a hardware issue when TX and RX DMA channels are
> simultaneously enabled which results in DMA lockup.

I've seen it on rtl1.8 also if I remember correctly.

> Use system DMA for all RX channels as a workaround of this issue as this
> will have minimal throughput overhead based on the fact that Rx transfers
> are done in DMA mode-0 on OMAP34x/35x platforms.
> 
> Another approach to use PIO mode in opposite direction would increase the
> cpu loading and thus using system DMA is preferred workaround.
> 
> Signed-off-by: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>

I think falling back to pio is better than this patch. It will most
likely be only one transfer. Another approach is to allocate dma
channels on a transfer basis. This is way too big of a problem.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-05-12 17:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-12 11:49 [PATCH 1/5] musb: save OTG base physical address Ajay Kumar Gupta
2010-05-12 11:49 ` [PATCH 2/5] musb: use system DMA to fix Inventra DMA issue on RTL-1.4 Ajay Kumar Gupta
     [not found]   ` <1273664979-493-2-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-05-12 11:49     ` [PATCH 3/5] musb: add function to check if Inventra DMA used Ajay Kumar Gupta
     [not found]       ` <1273664979-493-3-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-05-12 11:49         ` [PATCH 4/5] musb: use system DMA for unaligned buffers on RTL >= 1.8 Ajay Kumar Gupta
     [not found]           ` <1273664979-493-4-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-05-12 11:49             ` [PATCH 5/5] musb: dma: use optimal transfer element for sdma Ajay Kumar Gupta
2010-05-12 13:18             ` [PATCH 4/5] musb: use system DMA for unaligned buffers on RTL >= 1.8 Sergei Shtylyov
2010-05-12 13:55               ` Gupta, Ajay Kumar
2010-05-12 14:59                 ` Sergei Shtylyov
     [not found]                   ` <4BEAC268.1080601-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-05-12 17:55                     ` Felipe Balbi
2010-05-13  4:14                       ` Gupta, Ajay Kumar
     [not found]                         ` <19F8576C6E063C45BE387C64729E7394044E40516A-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-05-13 19:43                           ` Felipe Balbi
2010-05-14  4:39                             ` Gupta, Ajay Kumar
2010-05-12 17:54             ` Felipe Balbi
2010-05-13  4:13               ` Gupta, Ajay Kumar
     [not found]                 ` <19F8576C6E063C45BE387C64729E7394044E405169-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-05-14 11:06                   ` Felipe Balbi
2010-05-14 11:39                     ` Gupta, Ajay Kumar
2010-05-12 17:52       ` [PATCH 3/5] musb: add function to check if Inventra DMA used Felipe Balbi
2010-05-12 17:51     ` Felipe Balbi [this message]
2010-05-12 17:56       ` [PATCH 2/5] musb: use system DMA to fix Inventra DMA issue on RTL-1.4 Gadiyar, Anand
     [not found]         ` <5A47E75E594F054BAF48C5E4FC4B92AB03216237DA-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-05-13  4:22           ` Gupta, Ajay Kumar
2010-05-13  8:58             ` Kalliguddi, Hema
2010-05-13 10:10               ` Gupta, Ajay Kumar
2010-05-13 11:57                 ` Kalliguddi, Hema

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100512175113.GA3285@gandalf \
    --to=me-uirdbs8odbtmtblb0cgj/q@public.gmane.org \
    --cc=ajay.gupta-l0cyMroinI0@public.gmane.org \
    --cc=gadiyar-l0cyMroinI0@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.