From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Gupta, Ajay Kumar" <ajay.gupta@ti.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 4/5] musb: use system DMA for unaligned buffers on RTL >= 1.8
Date: Wed, 12 May 2010 18:59:52 +0400 [thread overview]
Message-ID: <4BEAC268.1080601@ru.mvista.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E7394044E405072@dbde02.ent.ti.com>
Hello.
Gupta, Ajay Kumar wrote:
> Hi,
>
>>> if (channel->status == MUSB_DMA_STATUS_BUSY) {
>>> if (musb_channel->transmit) {
>>> + if (musb_channel->sysdma_channel != -1)
>>> + omap_stop_dma(musb_channel->sysdma_channel);
>>> +
>>>
>>>
>> Have you thought about e.g. Blackfin? How this is going to compile
>> there, without omap_*() functions even existing? Or did you think that
>> OMAP is the only user of this driver?
>>
> Thanks for pointing this. It would require adding wrapper functions for
> Blckfin's.
>
Better wrap your stuff into #ifdef OMAP, I think...
> -Ajay
>
WBR, Sergei
next prev parent reply other threads:[~2010-05-12 15:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 11:49 [PATCH 1/5] musb: save OTG base physical address Ajay Kumar Gupta
2010-05-12 11:49 ` [PATCH 2/5] musb: use system DMA to fix Inventra DMA issue on RTL-1.4 Ajay Kumar Gupta
[not found] ` <1273664979-493-2-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-05-12 11:49 ` [PATCH 3/5] musb: add function to check if Inventra DMA used Ajay Kumar Gupta
[not found] ` <1273664979-493-3-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-05-12 11:49 ` [PATCH 4/5] musb: use system DMA for unaligned buffers on RTL >= 1.8 Ajay Kumar Gupta
[not found] ` <1273664979-493-4-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-05-12 11:49 ` [PATCH 5/5] musb: dma: use optimal transfer element for sdma Ajay Kumar Gupta
2010-05-12 13:18 ` [PATCH 4/5] musb: use system DMA for unaligned buffers on RTL >= 1.8 Sergei Shtylyov
2010-05-12 13:55 ` Gupta, Ajay Kumar
2010-05-12 14:59 ` Sergei Shtylyov [this message]
[not found] ` <4BEAC268.1080601-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-05-12 17:55 ` Felipe Balbi
2010-05-13 4:14 ` Gupta, Ajay Kumar
[not found] ` <19F8576C6E063C45BE387C64729E7394044E40516A-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-05-13 19:43 ` Felipe Balbi
2010-05-14 4:39 ` Gupta, Ajay Kumar
2010-05-12 17:54 ` Felipe Balbi
2010-05-13 4:13 ` Gupta, Ajay Kumar
[not found] ` <19F8576C6E063C45BE387C64729E7394044E405169-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-05-14 11:06 ` Felipe Balbi
2010-05-14 11:39 ` Gupta, Ajay Kumar
2010-05-12 17:52 ` [PATCH 3/5] musb: add function to check if Inventra DMA used Felipe Balbi
2010-05-12 17:51 ` [PATCH 2/5] musb: use system DMA to fix Inventra DMA issue on RTL-1.4 Felipe Balbi
2010-05-12 17:56 ` Gadiyar, Anand
[not found] ` <5A47E75E594F054BAF48C5E4FC4B92AB03216237DA-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-05-13 4:22 ` Gupta, Ajay Kumar
2010-05-13 8:58 ` Kalliguddi, Hema
2010-05-13 10:10 ` Gupta, Ajay Kumar
2010-05-13 11:57 ` Kalliguddi, Hema
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEAC268.1080601@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=ajay.gupta@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.