All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Joey Lee <jlee@novell.com>
Cc: dmitry.torokhov@gmail.com, mzxreary@0pointer.de, greg@kroah.com,
	rpurdie@linux.intel.com, mjg@redhat.com,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 4/4] msi-laptop: Add i8042 filter to sync sw state with BIOS when function key pressed
Date: Thu, 13 May 2010 15:54:15 -0700	[thread overview]
Message-ID: <20100513225415.GA23450@suse.de> (raw)
In-Reply-To: <4BEC74C002000023000190EE@novprvlin0050.provo.novell.com>

On Thu, May 13, 2010 at 05:53:04AM -0600, Joey Lee wrote:
> Hi Dmitry, 
> 
> Thank's for your review.
> 
> 於 四，2010-05-13 於 00:52 -0700，Dmitry Torokhov 提到：
> > On Wed, May 12, 2010 at 11:56:47AM -0700, Greg KH wrote:
> > >  static int __init msi_init(void)
> > > @@ -819,6 +875,7 @@ static void __exit msi_cleanup(void)
> > >  	platform_driver_unregister(&msipf_driver);
> > >  	backlight_device_unregister(msibl_device);
> > >  
> > > +	i8042_remove_filter(msi_laptop_i8042_filter);
> > 
> > You also need cancel_delayed_work_sync() here. Sorry for not noticing
> > this before.
> > 
> 
> Yes, you are right, need add cancel_delayed_work_sync().

Want to make up an additional patch to add on top of this that does it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Joey Lee <jlee@novell.com>
Cc: dmitry.torokhov@gmail.com, mzxreary@0pointer.de, greg@kroah.com,
	rpurdie@linux.intel.com, mjg@redhat.com,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 4/4] msi-laptop: Add i8042 filter to sync sw state with BIOS when function key pressed
Date: Thu, 13 May 2010 15:54:15 -0700	[thread overview]
Message-ID: <20100513225415.GA23450@suse.de> (raw)
In-Reply-To: <4BEC74C002000023000190EE@novprvlin0050.provo.novell.com>

On Thu, May 13, 2010 at 05:53:04AM -0600, Joey Lee wrote:
> Hi Dmitry, 
> 
> Thank's for your review.
> 
> 於 四，2010-05-13 於 00:52 -0700，Dmitry Torokhov 提到：
> > On Wed, May 12, 2010 at 11:56:47AM -0700, Greg KH wrote:
> > >  static int __init msi_init(void)
> > > @@ -819,6 +875,7 @@ static void __exit msi_cleanup(void)
> > >  	platform_driver_unregister(&msipf_driver);
> > >  	backlight_device_unregister(msibl_device);
> > >  
> > > +	i8042_remove_filter(msi_laptop_i8042_filter);
> > 
> > You also need cancel_delayed_work_sync() here. Sorry for not noticing
> > this before.
> > 
> 
> Yes, you are right, need add cancel_delayed_work_sync().

Want to make up an additional patch to add on top of this that does it?

thanks,

greg k-h

  reply	other threads:[~2010-05-13 22:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 11:53 [PATCH 4/4] msi-laptop: Add i8042 filter to sync sw state with BIOS when function key pressed Joey Lee
2010-05-13 11:53 ` Joey Lee
2010-05-13 22:54 ` Greg KH [this message]
2010-05-13 22:54   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2010-05-20 13:39 Joey Lee
2010-05-20 13:39 ` Joey Lee
2010-05-14 22:49 Joey Lee
2010-05-14 22:49 ` Joey Lee
2010-05-20 13:32 ` Matthew Garrett
2010-05-14  0:37 Joey Lee
2010-05-14  0:37 ` Joey Lee
     [not found] <20100512141149.GB20564@kroah.com>
2010-05-12 16:58 ` Greg Kroah-Hartman
2010-05-12 17:33   ` Dmitry Torokhov
2010-05-12 18:55     ` Greg KH
2010-05-12 18:56     ` Greg KH
2010-05-13  7:52       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100513225415.GA23450@suse.de \
    --to=gregkh@suse.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=greg@kroah.com \
    --cc=jlee@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=mzxreary@0pointer.de \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rpurdie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.