All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: linux-omap@vger.kernel.org, Kalle Valo <kalle.valo@iki.fi>
Subject: Re: [PATCH] omap: rx51: Move peripheral OMAP gpio setups to rx51_omapgpio_setup function
Date: Fri, 14 May 2010 08:33:51 -0700	[thread overview]
Message-ID: <20100514153351.GW3428@atomide.com> (raw)
In-Reply-To: <1273840778-4830-1-git-send-email-jhnikula@gmail.com>

* Jarkko Nikula <jhnikula@gmail.com> [100514 05:32]:
> Idea is to combine peripheral OMAP gpio setups in single function like what
> rx51_twlgpio_setup is doing for TWL4030 GPIOs.
> 
> Currently this is mostly cleanup for wl1251 gpio setup as not testing the
> gpiolib return values and setting the wl1251_pdata statically. The wl1251
> driver seems to cope well with uninitialized gpios or with negative irq
> number.

We should check the return values always. If gpio_request handling
changes then we have to fix it all over the place.

Regards,

Tony

  reply	other threads:[~2010-05-14 15:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-14 12:39 [PATCH] omap: rx51: Move peripheral OMAP gpio setups to rx51_omapgpio_setup function Jarkko Nikula
2010-05-14 15:33 ` Tony Lindgren [this message]
2010-05-14 18:04   ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100514153351.GW3428@atomide.com \
    --to=tony@atomide.com \
    --cc=jhnikula@gmail.com \
    --cc=kalle.valo@iki.fi \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.