Re: [PATCH] omap: rx51: Move peripheral OMAP gpio setups to rx51_omapgpio_setup function

[Jarkko Nikula <jhnikula@gmail.com>]

On Fri, 14 May 2010 08:33:51 -0700
Tony Lindgren <tony@atomide.com> wrote:

> * Jarkko Nikula <jhnikula@gmail.com> [100514 05:32]:
> > Idea is to combine peripheral OMAP gpio setups in single function like what
> > rx51_twlgpio_setup is doing for TWL4030 GPIOs.
> > 
> > Currently this is mostly cleanup for wl1251 gpio setup as not testing the
> > gpiolib return values and setting the wl1251_pdata statically. The wl1251
> > driver seems to cope well with uninitialized gpios or with negative irq
> > number.
> 
> We should check the return values always. If gpio_request handling
> changes then we have to fix it all over the place.
> 
Yeah, true and actually Documentation/gpio.txt is even insisting it.

I was somehow recalling that checking is not necessary in early init
code for soc gpios and counting only that they would fail only if
CONFIG_GPIOLIB is not set or if mixing up with the same numbers in same
early init code.

So let's discard this one.


-- 
Jarkko