From: Shaohui Zheng <shaohui.zheng@intel.com>
To: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Yinghai Lu <yinghai@kernel.org>,
David Rientjes <rientjes@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
linux-kernel@vger.kernel.org, ak@linux.intel.co,
fengguang.wu@intel.com, haicheng.li@linux.intel.com,
shaohui.zheng@linux.intel.com
Subject: Re: [RFC,2/7] NUMA Hotplug emulator
Date: Sun, 16 May 2010 00:08:05 +0800 [thread overview]
Message-ID: <20100515160805.GA23630@shaohui> (raw)
In-Reply-To: <AANLkTikZiRw2w9hveCxA2XQp8SYs-4rYpH4BdZOns2CS@mail.gmail.com>
On Sat, May 15, 2010 at 06:47:00PM +0530, Jaswinder Singh Rajput wrote:
> > + if (hidden_num)
>
> if (hidden_num) is not required, as next line's for statement is also
> doing the same thing.
Good catching, We will remove this statement in the formal patch. Thanks Jaswinder.
Have a nice day.
>
> Thanks,
> --
> Jaswinder Singh.
>
> > + for (i = 0; i < hidden_num; i++) {
> > + int nid = num_nodes + i + 1;
> > + node_set(nid, node_possible_map);
> > + hidden_nodes[nid].start = hp_start + hp_size * i;
> > + hidden_nodes[nid].end = hp_start + hp_size * (i+1);
> > + node_set_hidden(nid);
> > + }
> > +}
--
Thanks & Regards,
Shaohui
WARNING: multiple messages have this Message-ID (diff)
From: Shaohui Zheng <shaohui.zheng@intel.com>
To: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Yinghai Lu <yinghai@kernel.org>,
David Rientjes <rientjes@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
linux-kernel@vger.kernel.org, ak@linux.intel.co,
fengguang.wu@intel.com, haicheng.li@linux.intel.com,
shaohui.zheng@linux.intel.com
Subject: Re: [RFC,2/7] NUMA Hotplug emulator
Date: Sun, 16 May 2010 00:08:05 +0800 [thread overview]
Message-ID: <20100515160805.GA23630@shaohui> (raw)
In-Reply-To: <AANLkTikZiRw2w9hveCxA2XQp8SYs-4rYpH4BdZOns2CS@mail.gmail.com>
On Sat, May 15, 2010 at 06:47:00PM +0530, Jaswinder Singh Rajput wrote:
> > + if (hidden_num)
>
> if (hidden_num) is not required, as next line's for statement is also
> doing the same thing.
Good catching, We will remove this statement in the formal patch. Thanks Jaswinder.
Have a nice day.
>
> Thanks,
> --
> Jaswinder Singh.
>
> > + for (i = 0; i < hidden_num; i++) {
> > + int nid = num_nodes + i + 1;
> > + node_set(nid, node_possible_map);
> > + hidden_nodes[nid].start = hp_start + hp_size * i;
> > + hidden_nodes[nid].end = hp_start + hp_size * (i+1);
> > + node_set_hidden(nid);
> > + }
> > +}
--
Thanks & Regards,
Shaohui
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-15 16:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 11:45 [RFC,2/7] NUMA Hotplug emulator Shaohui Zheng
2010-05-14 2:16 ` KAMEZAWA Hiroyuki
2010-05-14 2:16 ` KAMEZAWA Hiroyuki
2010-05-14 5:42 ` Paul Mundt
2010-05-14 5:42 ` Paul Mundt
2010-05-14 7:38 ` Haicheng Li
2010-05-14 7:38 ` Haicheng Li
2010-05-14 8:07 ` Balbir Singh
2010-05-14 8:07 ` Balbir Singh
2010-05-14 4:49 ` Haicheng Li
2010-05-14 4:49 ` Haicheng Li
2010-05-15 13:17 ` Jaswinder Singh Rajput
2010-05-15 13:17 ` Jaswinder Singh Rajput
2010-05-15 16:08 ` Shaohui Zheng [this message]
2010-05-15 16:08 ` Shaohui Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100515160805.GA23630@shaohui \
--to=shaohui.zheng@intel.com \
--cc=ak@linux.intel.co \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jaswinderlinux@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=shaohui.zheng@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.