From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: Julia Lawall <julia@diku.dk>
Cc: Marcel Holtmann <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 20/37] drivers/bluetooth: Use kmemdup
Date: Sun, 16 May 2010 04:53:31 +0000 [thread overview]
Message-ID: <20100516045331.GA25105@vigoh> (raw)
In-Reply-To: <Pine.LNX.4.64.1005152318590.21345@ask.diku.dk>
* Julia Lawall <julia@diku.dk> [2010-05-15 23:19:15 +0200]:
> From: Julia Lawall <julia@diku.dk>
>
> Use kmemdup when some other buffer is immediately copied into the
> allocated region.
>
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression from,to,size,flag;
> statement S;
> @@
>
> - to = \(kmalloc\|kzalloc\)(size,flag);
> + to = kmemdup(from,size,flag);
> if (to=NULL || ...) S
> - memcpy(to, from, size);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/bluetooth/bcm203x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/drivers/bluetooth/bcm203x.c b/drivers/bluetooth/bcm203x.c
> --- a/drivers/bluetooth/bcm203x.c
> +++ b/drivers/bluetooth/bcm203x.c
> @@ -224,7 +224,7 @@ static int bcm203x_probe(struct usb_inte
>
> BT_DBG("firmware data %p size %zu", firmware->data, firmware->size);
>
> - data->fw_data = kmalloc(firmware->size, GFP_KERNEL);
> + data->fw_data = kmemdup(firmware->data, firmware->size, GFP_KERNEL);
> if (!data->fw_data) {
> BT_ERR("Can't allocate memory for firmware image");
> release_firmware(firmware);
> @@ -234,7 +234,6 @@ static int bcm203x_probe(struct usb_inte
> return -ENOMEM;
> }
>
> - memcpy(data->fw_data, firmware->data, firmware->size);
> data->fw_size = firmware->size;
> data->fw_sent = 0;
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
http://padovan.org
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: Julia Lawall <julia@diku.dk>
Cc: Marcel Holtmann <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 20/37] drivers/bluetooth: Use kmemdup
Date: Sun, 16 May 2010 01:53:31 -0300 [thread overview]
Message-ID: <20100516045331.GA25105@vigoh> (raw)
In-Reply-To: <Pine.LNX.4.64.1005152318590.21345@ask.diku.dk>
* Julia Lawall <julia@diku.dk> [2010-05-15 23:19:15 +0200]:
> From: Julia Lawall <julia@diku.dk>
>
> Use kmemdup when some other buffer is immediately copied into the
> allocated region.
>
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression from,to,size,flag;
> statement S;
> @@
>
> - to = \(kmalloc\|kzalloc\)(size,flag);
> + to = kmemdup(from,size,flag);
> if (to==NULL || ...) S
> - memcpy(to, from, size);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/bluetooth/bcm203x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/drivers/bluetooth/bcm203x.c b/drivers/bluetooth/bcm203x.c
> --- a/drivers/bluetooth/bcm203x.c
> +++ b/drivers/bluetooth/bcm203x.c
> @@ -224,7 +224,7 @@ static int bcm203x_probe(struct usb_inte
>
> BT_DBG("firmware data %p size %zu", firmware->data, firmware->size);
>
> - data->fw_data = kmalloc(firmware->size, GFP_KERNEL);
> + data->fw_data = kmemdup(firmware->data, firmware->size, GFP_KERNEL);
> if (!data->fw_data) {
> BT_ERR("Can't allocate memory for firmware image");
> release_firmware(firmware);
> @@ -234,7 +234,6 @@ static int bcm203x_probe(struct usb_inte
> return -ENOMEM;
> }
>
> - memcpy(data->fw_data, firmware->data, firmware->size);
> data->fw_size = firmware->size;
> data->fw_sent = 0;
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
http://padovan.org
next prev parent reply other threads:[~2010-05-16 4:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 21:19 [PATCH 20/37] drivers/bluetooth: Use kmemdup Julia Lawall
2010-05-15 21:19 ` Julia Lawall
2010-05-16 4:53 ` Gustavo F. Padovan [this message]
2010-05-16 4:53 ` Gustavo F. Padovan
2010-07-08 21:57 ` Marcel Holtmann
2010-07-08 21:57 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100516045331.GA25105@vigoh \
--to=gustavo@padovan.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.