All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@logfs.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	logfs@logfs.org
Subject: Re: linux-next: Tree for April 28 (logfs)
Date: Mon, 17 May 2010 21:25:47 +0200	[thread overview]
Message-ID: <20100517192547.GD28003@logfs.org> (raw)
In-Reply-To: <20100509062010.GA9485@elte.hu>

On Sun, 9 May 2010 08:20:10 +0200, Ingo Molnar wrote:
> 
> Please post the fix itself as well, i've ran into this and so did others.

Jörn

-- 
ticks = jiffies;
while (ticks == jiffies);
ticks = jiffies;
-- /usr/src/linux/init/main.c

When CONFIG_BLOCK is not enabled:

fs/logfs/super.c:142: error: implicit declaration of function 'bdev_get_queue'
fs/logfs/super.c:142: error: invalid type argument of '->' (have 'int')

Found by Randy Dunlap <randy.dunlap@oracle.com>

Signed-off-by: Joern Engel <joern@logfs.org>
---
 fs/logfs/super.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/logfs/super.c b/fs/logfs/super.c
index edd9948..2b26938 100644
--- a/fs/logfs/super.c
+++ b/fs/logfs/super.c
@@ -138,10 +138,14 @@ static int logfs_sb_set(struct super_block *sb, void *_super)
 	sb->s_fs_info = super;
 	sb->s_mtd = super->s_mtd;
 	sb->s_bdev = super->s_bdev;
+#ifdef CONFIG_BLOCK
 	if (sb->s_bdev)
 		sb->s_bdi = &bdev_get_queue(sb->s_bdev)->backing_dev_info;
+#endif
+#ifdef CONFIG_MTD
 	if (sb->s_mtd)
 		sb->s_bdi = sb->s_mtd->backing_dev_info;
+#endif
 	return 0;
 }
 
-- 
1.6.6.1


_______________________________________________
Logfs mailing list
Logfs@logfs.org
http://logfs.org/cgi-bin/mailman/listinfo/logfs

WARNING: multiple messages have this Message-ID (diff)
From: "Jörn Engel" <joern@logfs.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	logfs@logfs.org
Subject: Re: linux-next: Tree for April 28 (logfs)
Date: Mon, 17 May 2010 21:25:47 +0200	[thread overview]
Message-ID: <20100517192547.GD28003@logfs.org> (raw)
In-Reply-To: <20100509062010.GA9485@elte.hu>

On Sun, 9 May 2010 08:20:10 +0200, Ingo Molnar wrote:
> 
> Please post the fix itself as well, i've ran into this and so did others.

Jörn

-- 
ticks = jiffies;
while (ticks == jiffies);
ticks = jiffies;
-- /usr/src/linux/init/main.c

When CONFIG_BLOCK is not enabled:

fs/logfs/super.c:142: error: implicit declaration of function 'bdev_get_queue'
fs/logfs/super.c:142: error: invalid type argument of '->' (have 'int')

Found by Randy Dunlap <randy.dunlap@oracle.com>

Signed-off-by: Joern Engel <joern@logfs.org>
---
 fs/logfs/super.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/logfs/super.c b/fs/logfs/super.c
index edd9948..2b26938 100644
--- a/fs/logfs/super.c
+++ b/fs/logfs/super.c
@@ -138,10 +138,14 @@ static int logfs_sb_set(struct super_block *sb, void *_super)
 	sb->s_fs_info = super;
 	sb->s_mtd = super->s_mtd;
 	sb->s_bdev = super->s_bdev;
+#ifdef CONFIG_BLOCK
 	if (sb->s_bdev)
 		sb->s_bdi = &bdev_get_queue(sb->s_bdev)->backing_dev_info;
+#endif
+#ifdef CONFIG_MTD
 	if (sb->s_mtd)
 		sb->s_bdi = sb->s_mtd->backing_dev_info;
+#endif
 	return 0;
 }
 
-- 
1.6.6.1


  parent reply	other threads:[~2010-05-17 19:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-28  6:43 linux-next: Tree for April 28 Stephen Rothwell
2010-04-28 15:56 ` linux-next: Tree for April 28 (logfs) Randy Dunlap
2010-05-05 16:20   ` Randy Dunlap
2010-05-05 20:35     ` Jörn Engel
2010-05-05 20:35       ` Jörn Engel
2010-05-09  6:20       ` Ingo Molnar
2010-05-17  3:48         ` linux-next -> 2.6.34: " Randy Dunlap
2010-05-17 19:31           ` Jörn Engel
2010-05-17 19:31             ` Jörn Engel
2010-05-18  0:40             ` Ingo Molnar
2010-05-17 19:25         ` Jörn Engel [this message]
2010-05-17 19:25           ` linux-next: " Jörn Engel
2010-04-28 17:33 ` [PATCH -next] infiniband: fix cxgb4 printk format warnings Randy Dunlap
2010-05-05 18:57   ` Roland Dreier
     [not found]   ` <20100428103356.931ba48c.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-05-05 19:01     ` [PATCH/RFC] cxgb4: Add MAINTAINERS info Roland Dreier
2010-05-06  5:57       ` Or Gerlitz
     [not found]         ` <4BE25A3D.20800-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-05-06 16:07           ` Roland Dreier
     [not found]             ` <adapr199foo.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-05-08 15:43               ` Or Gerlitz
     [not found]       ` <adawrvijhpq.fsf_-_-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-05-05 19:59         ` Steve Wise
     [not found]           ` <4BE1CE39.1050707-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-05-05 21:40             ` Divy Le Ray
2010-05-06  8:43         ` Dimitris Michailidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100517192547.GD28003@logfs.org \
    --to=joern@logfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=logfs@logfs.org \
    --cc=mingo@elte.hu \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.