* [PATCH] cross.bbclass: fix build of meta-toolchain
@ 2010-05-14 22:53 Eric Benard
2010-05-16 16:22 ` Koen Kooi
2010-05-17 18:42 ` Cliff Brake
0 siblings, 2 replies; 6+ messages in thread
From: Eric Benard @ 2010-05-14 22:53 UTC (permalink / raw)
To: openembedded-devel
- without this bitbake meta-toolchain fails because it doesn't find who
provides gdb-cross-sdk
- found thanks to a hint from Phil Blundell on IRC
- tested with Angstrom/ARMv5te
Signed-off-by: Eric Benard <eric@eukrea.com>
---
classes/cross.bbclass | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/classes/cross.bbclass b/classes/cross.bbclass
index 69f6511..5c2d5be 100644
--- a/classes/cross.bbclass
+++ b/classes/cross.bbclass
@@ -17,8 +17,6 @@ PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}"
OLD_BASE_PACKAGE_ARCH := "${BASE_PACKAGE_ARCH}"
BASE_PACKAGE_ARCH = "${OLD_BASE_PACKAGE_ARCH}"
-PACKAGES = ""
-
HOST_ARCH = "${BUILD_ARCH}"
HOST_VENDOR = "${BUILD_VENDOR}"
HOST_OS = "${BUILD_OS}"
--
1.6.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cross.bbclass: fix build of meta-toolchain
2010-05-14 22:53 [PATCH] cross.bbclass: fix build of meta-toolchain Eric Benard
@ 2010-05-16 16:22 ` Koen Kooi
2010-05-17 19:18 ` Eric Bénard
2010-05-17 18:42 ` Cliff Brake
1 sibling, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2010-05-16 16:22 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I can confirm that 'meta-toolchain' builds against with this
(angstrom/beagleboard), but I don't know what the effect of this is on
cross recipes.
regards,
Koen
On 15-05-10 00:53, Eric Benard wrote:
> - without this bitbake meta-toolchain fails because it doesn't find who
> provides gdb-cross-sdk
> - found thanks to a hint from Phil Blundell on IRC
> - tested with Angstrom/ARMv5te
>
> Signed-off-by: Eric Benard <eric@eukrea.com>
> ---
> classes/cross.bbclass | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/classes/cross.bbclass b/classes/cross.bbclass
> index 69f6511..5c2d5be 100644
> --- a/classes/cross.bbclass
> +++ b/classes/cross.bbclass
> @@ -17,8 +17,6 @@ PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}"
> OLD_BASE_PACKAGE_ARCH := "${BASE_PACKAGE_ARCH}"
> BASE_PACKAGE_ARCH = "${OLD_BASE_PACKAGE_ARCH}"
>
> -PACKAGES = ""
> -
> HOST_ARCH = "${BUILD_ARCH}"
> HOST_VENDOR = "${BUILD_VENDOR}"
> HOST_OS = "${BUILD_OS}"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFL8BvSMkyGM64RGpERApFQAJ40WH4OOiFb0PZVfy/8gbQG4tFn4ACdFiHQ
9sEaKXsbeiDyzv/P/7+fQ4A=
=14NR
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cross.bbclass: fix build of meta-toolchain
2010-05-14 22:53 [PATCH] cross.bbclass: fix build of meta-toolchain Eric Benard
2010-05-16 16:22 ` Koen Kooi
@ 2010-05-17 18:42 ` Cliff Brake
1 sibling, 0 replies; 6+ messages in thread
From: Cliff Brake @ 2010-05-17 18:42 UTC (permalink / raw)
To: openembedded-devel
On Fri, May 14, 2010 at 6:53 PM, Eric Benard <eric@eukrea.com> wrote:
> - without this bitbake meta-toolchain fails because it doesn't find who
> provides gdb-cross-sdk
> - found thanks to a hint from Phil Blundell on IRC
> - tested with Angstrom/ARMv5te
>
> Signed-off-by: Eric Benard <eric@eukrea.com>
> ---
> classes/cross.bbclass | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/classes/cross.bbclass b/classes/cross.bbclass
> index 69f6511..5c2d5be 100644
> --- a/classes/cross.bbclass
> +++ b/classes/cross.bbclass
> @@ -17,8 +17,6 @@ PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}"
> OLD_BASE_PACKAGE_ARCH := "${BASE_PACKAGE_ARCH}"
> BASE_PACKAGE_ARCH = "${OLD_BASE_PACKAGE_ARCH}"
>
> -PACKAGES = ""
> -
> HOST_ARCH = "${BUILD_ARCH}"
> HOST_VENDOR = "${BUILD_VENDOR}"
> HOST_OS = "${BUILD_OS}"
> --
> 1.6.3.3
This fixes meta-toolchain builds for me.
Thanks,
Cliff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cross.bbclass: fix build of meta-toolchain
2010-05-16 16:22 ` Koen Kooi
@ 2010-05-17 19:18 ` Eric Bénard
2010-05-17 19:26 ` Khem Raj
2010-05-18 21:40 ` Phil Blundell
0 siblings, 2 replies; 6+ messages in thread
From: Eric Bénard @ 2010-05-17 19:18 UTC (permalink / raw)
To: openembedded-devel
Hi,
Le 16/05/2010 18:22, Koen Kooi a écrit :
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I can confirm that 'meta-toolchain' builds against with this
> (angstrom/beagleboard), but I don't know what the effect of this is on
> cross recipes.
Who could confirm that this change may not introduce any unwanted
behaviour ?
Thanks,
Eric
>
> On 15-05-10 00:53, Eric Benard wrote:
>> - without this bitbake meta-toolchain fails because it doesn't find who
>> provides gdb-cross-sdk
>> - found thanks to a hint from Phil Blundell on IRC
>> - tested with Angstrom/ARMv5te
>>
>> Signed-off-by: Eric Benard<eric@eukrea.com>
>> ---
>> classes/cross.bbclass | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/classes/cross.bbclass b/classes/cross.bbclass
>> index 69f6511..5c2d5be 100644
>> --- a/classes/cross.bbclass
>> +++ b/classes/cross.bbclass
>> @@ -17,8 +17,6 @@ PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}"
>> OLD_BASE_PACKAGE_ARCH := "${BASE_PACKAGE_ARCH}"
>> BASE_PACKAGE_ARCH = "${OLD_BASE_PACKAGE_ARCH}"
>>
>> -PACKAGES = ""
>> -
>> HOST_ARCH = "${BUILD_ARCH}"
>> HOST_VENDOR = "${BUILD_VENDOR}"
>> HOST_OS = "${BUILD_OS}"
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFL8BvSMkyGM64RGpERApFQAJ40WH4OOiFb0PZVfy/8gbQG4tFn4ACdFiHQ
> 9sEaKXsbeiDyzv/P/7+fQ4A=
> =14NR
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cross.bbclass: fix build of meta-toolchain
2010-05-17 19:18 ` Eric Bénard
@ 2010-05-17 19:26 ` Khem Raj
2010-05-18 21:40 ` Phil Blundell
1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2010-05-17 19:26 UTC (permalink / raw)
To: openembedded-devel
On (17/05/10 21:18), Eric Bénard wrote:
> Hi,
>
> Le 16/05/2010 18:22, Koen Kooi a écrit :
> >-----BEGIN PGP SIGNED MESSAGE-----
> >Hash: SHA1
> >
> >I can confirm that 'meta-toolchain' builds against with this
> >(angstrom/beagleboard), but I don't know what the effect of this is on
> >cross recipes.
>
> Who could confirm that this change may not introduce any unwanted
> behaviour ?
I have build a console-image so far ok with this change in. I did
not notice any difference.
So you have my ack
Acked-by: Khem Raj <raj.khem@gmail.com>
>
> Thanks,
> Eric
> >
> >On 15-05-10 00:53, Eric Benard wrote:
> >>- without this bitbake meta-toolchain fails because it doesn't find who
> >> provides gdb-cross-sdk
> >>- found thanks to a hint from Phil Blundell on IRC
> >>- tested with Angstrom/ARMv5te
> >>
> >>Signed-off-by: Eric Benard<eric@eukrea.com>
> >>---
> >> classes/cross.bbclass | 2 --
> >> 1 files changed, 0 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/classes/cross.bbclass b/classes/cross.bbclass
> >>index 69f6511..5c2d5be 100644
> >>--- a/classes/cross.bbclass
> >>+++ b/classes/cross.bbclass
> >>@@ -17,8 +17,6 @@ PACKAGE_ARCH = "${OLD_PACKAGE_ARCH}"
> >> OLD_BASE_PACKAGE_ARCH := "${BASE_PACKAGE_ARCH}"
> >> BASE_PACKAGE_ARCH = "${OLD_BASE_PACKAGE_ARCH}"
> >>
> >>-PACKAGES = ""
> >>-
> >> HOST_ARCH = "${BUILD_ARCH}"
> >> HOST_VENDOR = "${BUILD_VENDOR}"
> >> HOST_OS = "${BUILD_OS}"
> >
> >-----BEGIN PGP SIGNATURE-----
> >Version: GnuPG v1.4.5 (Darwin)
> >
> >iD8DBQFL8BvSMkyGM64RGpERApFQAJ40WH4OOiFb0PZVfy/8gbQG4tFn4ACdFiHQ
> >9sEaKXsbeiDyzv/P/7+fQ4A=
> >=14NR
> >-----END PGP SIGNATURE-----
> >
> >
> >_______________________________________________
> >Openembedded-devel mailing list
> >Openembedded-devel@lists.openembedded.org
> >http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> >
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cross.bbclass: fix build of meta-toolchain
2010-05-17 19:18 ` Eric Bénard
2010-05-17 19:26 ` Khem Raj
@ 2010-05-18 21:40 ` Phil Blundell
1 sibling, 0 replies; 6+ messages in thread
From: Phil Blundell @ 2010-05-18 21:40 UTC (permalink / raw)
To: openembedded-devel
On Mon, 2010-05-17 at 21:18 +0200, Eric Bénard wrote:
> Hi,
>
> Le 16/05/2010 18:22, Koen Kooi a écrit :
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > I can confirm that 'meta-toolchain' builds against with this
> > (angstrom/beagleboard), but I don't know what the effect of this is on
> > cross recipes.
>
> Who could confirm that this change may not introduce any unwanted
> behaviour ?
In the long term I think this patch is a good idea, and I think we
already have a similar change on the toolchain-desuck branch.
In the short term, this patch is probably harmless since I think the
other bits in cross.bbclass will prevent any packages from actually
being generated (since the install paths won't match against any FILES).
If you did get packages out then they would be somewhat misleadingly
named and this would probably be a bad thing.
I think you might as well go ahead and check this in, if you haven't
already, and if any issues do crop up we can deal with them at that
time. I would like to try to get the other toolchain-packaging changes
merged as well at some point soonish.
p.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-05-18 21:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-14 22:53 [PATCH] cross.bbclass: fix build of meta-toolchain Eric Benard
2010-05-16 16:22 ` Koen Kooi
2010-05-17 19:18 ` Eric Bénard
2010-05-17 19:26 ` Khem Raj
2010-05-18 21:40 ` Phil Blundell
2010-05-17 18:42 ` Cliff Brake
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.