From: Ben Dooks <ben-linux@fluff.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kyungmin.park@samsung.com
Subject: Re: [PATCH] serial: SAMSUNG: Fix dev_name and driver_name
Date: Tue, 18 May 2010 06:36:45 +0100 [thread overview]
Message-ID: <20100518053645.GN27571@trinity.fluff.org> (raw)
In-Reply-To: <4BF20EED.5040306@samsung.com>
On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote:
> On 5/18/2010 11:48 AM, Ben Dooks wrote:
> > On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote:
> >> Thd dev_name and driver_name should be switched each other.
> >
> > Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
> >
> > Please provide some information about what problem that this is fixing
> > and the impact on any existing systems.
> >
>
> The serial device nodes are created to s3c2410_serial* on android
> platform instead of ttySAC*.
This has been how they've been for ages, surely the android device node
creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx,
like many other operating sysyerms that can already do this.
Changing this just because android (something as-yet unmerged into mainline)
does not like it. I'm not even happy with an #ifdef around this.
If you really feel this is a problem that you absolutely must fix in kernel
then please provide a kernel commandline option to change the serial driver
name and use that on any platform that needs it. Another way would be to
update the serial platform data to have a field for which name to choose.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
WARNING: multiple messages have this Message-ID (diff)
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: SAMSUNG: Fix dev_name and driver_name
Date: Tue, 18 May 2010 06:36:45 +0100 [thread overview]
Message-ID: <20100518053645.GN27571@trinity.fluff.org> (raw)
In-Reply-To: <4BF20EED.5040306@samsung.com>
On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote:
> On 5/18/2010 11:48 AM, Ben Dooks wrote:
> > On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote:
> >> Thd dev_name and driver_name should be switched each other.
> >
> > Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
> >
> > Please provide some information about what problem that this is fixing
> > and the impact on any existing systems.
> >
>
> The serial device nodes are created to s3c2410_serial* on android
> platform instead of ttySAC*.
This has been how they've been for ages, surely the android device node
creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx,
like many other operating sysyerms that can already do this.
Changing this just because android (something as-yet unmerged into mainline)
does not like it. I'm not even happy with an #ifdef around this.
If you really feel this is a problem that you absolutely must fix in kernel
then please provide a kernel commandline option to change the serial driver
name and use that on any platform that needs it. Another way would be to
update the serial platform data to have a field for which name to choose.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2010-05-18 5:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 12:46 [PATCH] serial: SAMSUNG: Fix dev_name and driver_name Joonyoung Shim
2010-05-17 12:46 ` Joonyoung Shim
2010-05-18 2:48 ` Ben Dooks
2010-05-18 2:48 ` Ben Dooks
2010-05-18 3:52 ` Joonyoung Shim
2010-05-18 3:52 ` Joonyoung Shim
2010-05-18 5:36 ` Ben Dooks [this message]
2010-05-18 5:36 ` Ben Dooks
2010-05-18 6:00 ` Joonyoung Shim
2010-05-18 6:00 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518053645.GN27571@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.