From: Dan Carpenter <error27@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [patch -next 1/2 v2] ath9k/debug: improve the snprintf() handling
Date: Tue, 18 May 2010 09:47:45 +0200 [thread overview]
Message-ID: <20100518074601.GA25162@bicker> (raw)
In-Reply-To: <20100515133441.GB5381@bicker>
On Sat, May 15, 2010 at 03:34:41PM +0200, Dan Carpenter wrote:
> The snprintf() function returns the number of bytes that *would* have
> been written (not counting the NULL terminator). We want to pass NULL
> terminated strings to the user so we need to add one to the snprintf
> return value.
Actually this is a filesystem so we don't want to pass null terminated
strings do we? Probably the first version of this patch was the better
one.
(What I love about open source is the discussions. But normally it's
not just one discussing and sending out patches to his ownself. :P).
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Jouni Malinen <jmalinen@atheros.com>,
Sujith Manoharan <Sujith.Manoharan@atheros.com>,
Vasanthakumar Thiagarajan <vasanth@atheros.com>,
Senthil Balasubramanian <senthilkumar@atheros.com>,
"John W. Linville" <linville@tuxdriver.com>,
Felix Fietkau <nbd@openwrt.org>, Jeff Hansen <x@jeffhansen.com>,
linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org
Subject: Re: [patch -next 1/2 v2] ath9k/debug: improve the snprintf() handling
Date: Tue, 18 May 2010 09:47:45 +0200 [thread overview]
Message-ID: <20100518074601.GA25162@bicker> (raw)
In-Reply-To: <20100515133441.GB5381@bicker>
On Sat, May 15, 2010 at 03:34:41PM +0200, Dan Carpenter wrote:
> The snprintf() function returns the number of bytes that *would* have
> been written (not counting the NULL terminator). We want to pass NULL
> terminated strings to the user so we need to add one to the snprintf
> return value.
Actually this is a filesystem so we don't want to pass null terminated
strings do we? Probably the first version of this patch was the better
one.
(What I love about open source is the discussions. But normally it's
not just one discussing and sending out patches to his ownself. :P).
regards,
dan carpenter
next prev parent reply other threads:[~2010-05-18 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 13:24 [ath9k-devel] [patch -next 1/2] ath9k/debug: improve the snprintf() handling Dan Carpenter
2010-05-14 13:24 ` Dan Carpenter
2010-05-15 13:34 ` [ath9k-devel] [patch -next 1/2 v2] " Dan Carpenter
2010-05-15 13:34 ` Dan Carpenter
2010-05-18 7:47 ` Dan Carpenter [this message]
2010-05-18 7:47 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518074601.GA25162@bicker \
--to=error27@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.