Re: [PATCH 2/2] omap: rx51: Add supplies and data for the tpa6130a2 headphone amplifier

[Jarkko Nikula <jhnikula@gmail.com>]

On Tue, 18 May 2010 15:48:48 +0300
Eduardo Valentin <eduardo.valentin@nokia.com> wrote:

> > @@ -285,6 +287,9 @@ static struct regulator_consumer_supply rx51_vmmc2_supplies[] = {
> >  	/* tlv320aic3x analog supplies */
> >  	REGULATOR_SUPPLY("AVDD", "2-0018"),
> >  	REGULATOR_SUPPLY("DRVDD", "2-0018"),
> > +	/* tpa6130a2 */
> > +	REGULATOR_SUPPLY("CPVSS", "2-0060"),
> 
> Isn't CPVSS grounded? Well that wouldn't hurt to put it here, but it doesnt belong to vmmc2 though.
> 
Thanks Eduardo! For me it looks this CPVSS supply is miss-added to the
tpa6130a2 as spec says for this pin:

"Negative supply generated by the charge pump. Decouple to pin 19 on
the QFN or a CPVSS B2 15, 16 P GND plane. Use a 1 μF capacitor."

I'll send a fix first to the tpa6130a2 and repost this one after that.


-- 
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html