From: Simon Horman <horms@verge.net.au>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@ozlabs.org, kexec@lists.infradead.org,
Matt Evans <matt@ozlabs.org>
Subject: Re: [PATCH v2] kexec-tools, ppc64: Fix segfault parsing DR memory property
Date: Wed, 19 May 2010 09:22:27 +0900 [thread overview]
Message-ID: <20100519002227.GC8536@verge.net.au> (raw)
In-Reply-To: <23148.1274139032@neuling.org>
On Tue, May 18, 2010 at 09:30:32AM +1000, Michael Neuling wrote:
>
>
> In message <4BECBE89.3020108@ozlabs.org> you wrote:
> > add_dyn_reconf_usable_mem_property() iterates over memory spans
> > in /ibm,dynamic-reconfiguration-memory/ibm,dynamic-memory and intersects
> > these with usablemem_rgns ranges. In doing so it used an unchecked
> > fixed-size array which will overrun on machines with lots of LMBs.
> >
> > This patch removes the fixed-sized arrays from
> > add_dyn_reconf_usable_mem_property() and add_usable_mem_property(), in lieu o
> f
> > malloc/realloc/free.
> >
> > Signed-off-by: Matt Evans <matt@ozlabs.org>
>
> So this works our large P7 machine unlike the last one.
>
> Acked-by: Michael Neuling <mikey@neuling.org>
Thanks, applied
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@ozlabs.org, kexec@lists.infradead.org,
Matt Evans <matt@ozlabs.org>
Subject: Re: [PATCH v2] kexec-tools, ppc64: Fix segfault parsing DR memory property
Date: Wed, 19 May 2010 09:22:27 +0900 [thread overview]
Message-ID: <20100519002227.GC8536@verge.net.au> (raw)
In-Reply-To: <23148.1274139032@neuling.org>
On Tue, May 18, 2010 at 09:30:32AM +1000, Michael Neuling wrote:
>
>
> In message <4BECBE89.3020108@ozlabs.org> you wrote:
> > add_dyn_reconf_usable_mem_property() iterates over memory spans
> > in /ibm,dynamic-reconfiguration-memory/ibm,dynamic-memory and intersects
> > these with usablemem_rgns ranges. In doing so it used an unchecked
> > fixed-size array which will overrun on machines with lots of LMBs.
> >
> > This patch removes the fixed-sized arrays from
> > add_dyn_reconf_usable_mem_property() and add_usable_mem_property(), in lieu o
> f
> > malloc/realloc/free.
> >
> > Signed-off-by: Matt Evans <matt@ozlabs.org>
>
> So this works our large P7 machine unlike the last one.
>
> Acked-by: Michael Neuling <mikey@neuling.org>
Thanks, applied
next prev parent reply other threads:[~2010-05-19 0:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 3:07 [PATCH v2] kexec-tools, ppc64: Fix segfault parsing DR memory property Matt Evans
2010-05-14 3:07 ` Matt Evans
2010-05-17 23:30 ` Michael Neuling
2010-05-17 23:30 ` Michael Neuling
2010-05-19 0:22 ` Simon Horman [this message]
2010-05-19 0:22 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519002227.GC8536@verge.net.au \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=matt@ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.