From: Oleg Nesterov <oleg@redhat.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Jamie Lokier <jamie@shareable.org>,
David Howells <dhowells@redhat.com>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/3] Reduce get_current() to the asm-generic implementation where possible
Date: Wed, 19 May 2010 13:02:04 +0200 [thread overview]
Message-ID: <20100519110204.GB10040@redhat.com> (raw)
In-Reply-To: <20100519062112.GQ2516@laptop>
On 05/19, Nick Piggin wrote:
>
> On Tue, May 18, 2010 at 08:47:53PM +0100, Jamie Lokier wrote:
> >
> > So there is probably no point putting the const attribute back, unless
> > GCC has changed at this.
> >
> > It might be able to eliminate some duplicates if the asm inside
> > current_thread_info() is consty enough, and duplicate ->task
> > dereferences might be eliminated by strict-aliasing in some cases.
>
> I don't think it hurts to give more information even if the compiler
> does not use it yet.
Completely agreed.
Personally, I think this patch makes sense even as documentation. And
hopefully some time later gcc will be improved.
Oleg.
next prev parent reply other threads:[~2010-05-19 11:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 16:45 [PATCH 1/3] Reduce get_current() to the asm-generic implementation where possible David Howells
2010-05-18 16:45 ` [PATCH 2/3] Mark the 'current' pointer register read-only when such a thing exists David Howells
2010-05-18 21:05 ` David Miller
2010-05-18 16:45 ` [PATCH 3/3] Make get_current() __attribute__((const)) David Howells
2010-05-18 21:22 ` schedule() && prev/current (Was: [PATCH 3/3] Make get_current() __attribute__((const))) Oleg Nesterov
2010-05-19 6:21 ` Peter Zijlstra
2010-05-19 10:27 ` Oleg Nesterov
2010-05-19 10:37 ` Peter Zijlstra
2010-05-19 12:57 ` [PATCH] schedule: simplify the reacquire_kernel_lock() logic Oleg Nesterov
2010-05-19 13:11 ` Yong Zhang
2010-06-09 10:13 ` [tip:sched/core] sched: Simplify " tip-bot for Oleg Nesterov
2010-05-19 13:07 ` schedule() && prev/current (Was: [PATCH 3/3] Make get_current() __attribute__((const))) Yong Zhang
2010-05-18 17:39 ` [PATCH 1/3] Reduce get_current() to the asm-generic implementation where possible Kyle McMartin
2010-05-18 19:47 ` Jamie Lokier
2010-05-19 6:21 ` Nick Piggin
2010-05-19 11:02 ` Oleg Nesterov [this message]
2010-05-21 10:13 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519110204.GB10040@redhat.com \
--to=oleg@redhat.com \
--cc=dhowells@redhat.com \
--cc=jamie@shareable.org \
--cc=linux-arch@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.