[Qemu-devel] [PATCH 1/3] Fix typo in balloon help

[Qemu-devel] [PATCH 1/3] Fix typo in balloon help

[Riccardo Magliocchetti]

Fix launchpad #563883

Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
---
 qemu-monitor.hx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index a8f194c..ed7def9 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -979,7 +979,7 @@ ETEXI
         .name       = "balloon",
         .args_type  = "value:M",
         .params     = "target",
-        .help       = "request VM to change it's memory allocation (in MB)",
+        .help       = "request VM to change its memory allocation (in MB)",
         .user_print = monitor_user_noop,
         .mhandler.cmd_async = do_balloon,
         .async      = 1,
-- 
1.7.1

[Qemu-devel] [PATCH 2/3] Fix __VA__ARGS__ typo in cris mmu.c

[Riccardo Magliocchetti]

Fix compilation with DEBUG defined

Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
---
 target-cris/mmu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/target-cris/mmu.c b/target-cris/mmu.c
index 2a5ded8..d09e921 100644
--- a/target-cris/mmu.c
+++ b/target-cris/mmu.c
@@ -31,7 +31,7 @@
 
 #ifdef DEBUG
 #define D(x) x
-#define D_LOG(...) qemu_log(__VA__ARGS__)
+#define D_LOG(...) qemu_log(__VA_ARGS__)
 #else
 #define D(x)
 #define D_LOG(...) do { } while (0)
-- 
1.7.1

[Qemu-devel] [PATCH 3/3] Fix hw/gt64xxx.c compilation with DEBUG defined

[Riccardo Magliocchetti]

Use TARGET_FMT_plx as format placeholder for target_phys_addr_t

Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
---
 hw/gt64xxx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c
index 55971b9..7691e1d 100644
--- a/hw/gt64xxx.c
+++ b/hw/gt64xxx.c
@@ -276,7 +276,7 @@ static void gt64120_isd_mapping(GT64120State *s)
     check_reserved_space(&start, &length);
     length = 0x1000;
     /* Map new address */
-    DPRINTF("ISD: %x@%x -> %x@%x, %x\n", s->ISD_length, s->ISD_start,
+    DPRINTF("ISD: "TARGET_FMT_plx"@"TARGET_FMT_plx" -> "TARGET_FMT_plx"@"TARGET_FMT_plx", %x\n", s->ISD_length, s->ISD_start,
             length, start, s->ISD_handle);
     s->ISD_start = start;
     s->ISD_length = length;
-- 
1.7.1

[Qemu-devel] Re: [PATCH 2/3] Fix __VA__ARGS__ typo in cris mmu.c

[Edgar E. Iglesias]

On Wed, May 19, 2010 at 06:49:29PM +0200, Riccardo Magliocchetti wrote:
> Fix compilation with DEBUG defined
> 
> Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>


Thanks, applied.

Cheers


> ---
>  target-cris/mmu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/target-cris/mmu.c b/target-cris/mmu.c
> index 2a5ded8..d09e921 100644
> --- a/target-cris/mmu.c
> +++ b/target-cris/mmu.c
> @@ -31,7 +31,7 @@
>  
>  #ifdef DEBUG
>  #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
>  #else
>  #define D(x)
>  #define D_LOG(...) do { } while (0)
> -- 
> 1.7.1
> 

Re: [Qemu-devel] [PATCH 1/3] Fix typo in balloon help

[Aurelien Jarno]

On Wed, May 19, 2010 at 06:49:28PM +0200, Riccardo Magliocchetti wrote:
> Fix launchpad #563883
> 
> Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>

Thanks, applied.

> ---
>  qemu-monitor.hx |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qemu-monitor.hx b/qemu-monitor.hx
> index a8f194c..ed7def9 100644
> --- a/qemu-monitor.hx
> +++ b/qemu-monitor.hx
> @@ -979,7 +979,7 @@ ETEXI
>          .name       = "balloon",
>          .args_type  = "value:M",
>          .params     = "target",
> -        .help       = "request VM to change it's memory allocation (in MB)",
> +        .help       = "request VM to change its memory allocation (in MB)",
>          .user_print = monitor_user_noop,
>          .mhandler.cmd_async = do_balloon,
>          .async      = 1,
> -- 
> 1.7.1
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] [PATCH 3/3] Fix hw/gt64xxx.c compilation with DEBUG defined

[Aurelien Jarno]

On Wed, May 19, 2010 at 06:49:30PM +0200, Riccardo Magliocchetti wrote:
> Use TARGET_FMT_plx as format placeholder for target_phys_addr_t
> 
> Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>

Thanks, applied.

> ---
>  hw/gt64xxx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c
> index 55971b9..7691e1d 100644
> --- a/hw/gt64xxx.c
> +++ b/hw/gt64xxx.c
> @@ -276,7 +276,7 @@ static void gt64120_isd_mapping(GT64120State *s)
>      check_reserved_space(&start, &length);
>      length = 0x1000;
>      /* Map new address */
> -    DPRINTF("ISD: %x@%x -> %x@%x, %x\n", s->ISD_length, s->ISD_start,
> +    DPRINTF("ISD: "TARGET_FMT_plx"@"TARGET_FMT_plx" -> "TARGET_FMT_plx"@"TARGET_FMT_plx", %x\n", s->ISD_length, s->ISD_start,
>              length, start, s->ISD_handle);
>      s->ISD_start = start;
>      s->ISD_length = length;
> -- 
> 1.7.1
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net