* [PATCH] ARM: S5PV210: Add GONI board support @ 2010-05-19 14:15 Joonyoung Shim 2010-05-20 0:48 ` Ben Dooks 0 siblings, 1 reply; 6+ messages in thread From: Joonyoung Shim @ 2010-05-19 14:15 UTC (permalink / raw) To: linux-arm-kernel This is for samsung GONI board using s5pc110. Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/mach-s5pv210/Kconfig | 8 +++ arch/arm/mach-s5pv210/Makefile | 1 + arch/arm/mach-s5pv210/mach-goni.c | 98 +++++++++++++++++++++++++++++++++++++ 3 files changed, 107 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-s5pv210/mach-goni.c diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig index 7601c28..83b15b2 100644 --- a/arch/arm/mach-s5pv210/Kconfig +++ b/arch/arm/mach-s5pv210/Kconfig @@ -36,6 +36,14 @@ config MACH_SMDKC110 Machine support for Samsung SMDKC110 S5PC110(MCP) is one of package option of S5PV210 +config MACH_GONI + bool "GONI" + select CPU_S5PV210 + select ARCH_SPARSEMEM_ENABLE + help + Machine support for Samsung GONI board + S5PC110(MCP) is one of package option of S5PV210 + endchoice endif diff --git a/arch/arm/mach-s5pv210/Makefile b/arch/arm/mach-s5pv210/Makefile index 9982781..5135577 100644 --- a/arch/arm/mach-s5pv210/Makefile +++ b/arch/arm/mach-s5pv210/Makefile @@ -19,6 +19,7 @@ obj-$(CONFIG_CPU_S5PV210) += setup-i2c0.o obj-$(CONFIG_MACH_SMDKV210) += mach-smdkv210.o obj-$(CONFIG_MACH_SMDKC110) += mach-smdkc110.o +obj-$(CONFIG_MACH_GONI) += mach-goni.o # device support diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c new file mode 100644 index 0000000..4863b13 --- /dev/null +++ b/arch/arm/mach-s5pv210/mach-goni.c @@ -0,0 +1,98 @@ +/* linux/arch/arm/mach-s5pv210/mach-goni.c + * + * Copyright (c) 2010 Samsung Electronics Co., Ltd. + * http://www.samsung.com/ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +#include <linux/kernel.h> +#include <linux/types.h> +#include <linux/init.h> +#include <linux/serial_core.h> + +#include <asm/mach/arch.h> +#include <asm/mach/map.h> +#include <asm/setup.h> +#include <asm/mach-types.h> + +#include <mach/map.h> +#include <mach/regs-clock.h> + +#include <plat/regs-serial.h> +#include <plat/s5pv210.h> +#include <plat/devs.h> +#include <plat/cpu.h> + +/* Following are default values for UCON, ULCON and UFCON UART registers */ +#define S5PV210_UCON_DEFAULT (S3C2410_UCON_TXILEVEL | \ + S3C2410_UCON_RXILEVEL | \ + S3C2410_UCON_TXIRQMODE | \ + S3C2410_UCON_RXIRQMODE | \ + S3C2410_UCON_RXFIFO_TOI | \ + S3C2443_UCON_RXERR_IRQEN) + +#define S5PV210_ULCON_DEFAULT S3C2410_LCON_CS8 + +#define S5PV210_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | \ + S5PV210_UFCON_TXTRIG4 | \ + S5PV210_UFCON_RXTRIG4) + +static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = { + [0] = { + .hwport = 0, + .flags = 0, + .ucon = S5PV210_UCON_DEFAULT, + .ulcon = S5PV210_ULCON_DEFAULT, + .ufcon = S5PV210_UFCON_DEFAULT, + }, + [1] = { + .hwport = 1, + .flags = 0, + .ucon = S5PV210_UCON_DEFAULT, + .ulcon = S5PV210_ULCON_DEFAULT, + .ufcon = S5PV210_UFCON_DEFAULT, + }, + [2] = { + .hwport = 2, + .flags = 0, + .ucon = S5PV210_UCON_DEFAULT, + .ulcon = S5PV210_ULCON_DEFAULT, + .ufcon = S5PV210_UFCON_DEFAULT, + }, + [3] = { + .hwport = 3, + .flags = 0, + .ucon = S5PV210_UCON_DEFAULT, + .ulcon = S5PV210_ULCON_DEFAULT, + .ufcon = S5PV210_UFCON_DEFAULT, + }, +}; + +static struct platform_device *goni_devices[] __initdata = { +}; + +static void __init goni_map_io(void) +{ + s5p_init_io(NULL, 0, S5P_VA_CHIPID); + s3c24xx_init_clocks(24000000); + s3c24xx_init_uarts(goni_uartcfgs, ARRAY_SIZE(goni_uartcfgs)); +} + +static void __init goni_machine_init(void) +{ + platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices)); +} + +MACHINE_START(GONI, "GONI") + /* Maintainers: Kyungmin Park <kyungmin.park@samsung.com> */ + .phys_io = S3C_PA_UART & 0xfff00000, + .io_pg_offst = (((u32)S3C_VA_UART) >> 18) & 0xfffc, + .boot_params = S5P_PA_SDRAM + 0x100, + .init_irq = s5pv210_init_irq, + .map_io = goni_map_io, + .init_machine = goni_machine_init, + .timer = &s3c24xx_timer, +MACHINE_END -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: S5PV210: Add GONI board support 2010-05-19 14:15 [PATCH] ARM: S5PV210: Add GONI board support Joonyoung Shim @ 2010-05-20 0:48 ` Ben Dooks 2010-05-20 1:10 ` Kyungmin Park 0 siblings, 1 reply; 6+ messages in thread From: Ben Dooks @ 2010-05-20 0:48 UTC (permalink / raw) To: linux-arm-kernel On Wed, May 19, 2010 at 11:15:32PM +0900, Joonyoung Shim wrote: > This is for samsung GONI board using s5pc110. > > Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> > Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com> I'll think about adding this, however it is very late in the development cycle, and the only thing saving it from immediate stalling until the next round is the fact that it is so simple. > --- > arch/arm/mach-s5pv210/Kconfig | 8 +++ > arch/arm/mach-s5pv210/Makefile | 1 + > arch/arm/mach-s5pv210/mach-goni.c | 98 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 107 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/mach-s5pv210/mach-goni.c > > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig > index 7601c28..83b15b2 100644 > --- a/arch/arm/mach-s5pv210/Kconfig > +++ b/arch/arm/mach-s5pv210/Kconfig > @@ -36,6 +36,14 @@ config MACH_SMDKC110 > Machine support for Samsung SMDKC110 > S5PC110(MCP) is one of package option of S5PV210 > > +config MACH_GONI > + bool "GONI" > + select CPU_S5PV210 > + select ARCH_SPARSEMEM_ENABLE > + help > + Machine support for Samsung GONI board > + S5PC110(MCP) is one of package option of S5PV210 > + > endchoice > > endif > diff --git a/arch/arm/mach-s5pv210/Makefile b/arch/arm/mach-s5pv210/Makefile > index 9982781..5135577 100644 > --- a/arch/arm/mach-s5pv210/Makefile > +++ b/arch/arm/mach-s5pv210/Makefile > @@ -19,6 +19,7 @@ obj-$(CONFIG_CPU_S5PV210) += setup-i2c0.o > > obj-$(CONFIG_MACH_SMDKV210) += mach-smdkv210.o > obj-$(CONFIG_MACH_SMDKC110) += mach-smdkc110.o > +obj-$(CONFIG_MACH_GONI) += mach-goni.o > > # device support > > diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c > new file mode 100644 > index 0000000..4863b13 > --- /dev/null > +++ b/arch/arm/mach-s5pv210/mach-goni.c > @@ -0,0 +1,98 @@ > +/* linux/arch/arm/mach-s5pv210/mach-goni.c > + * > + * Copyright (c) 2010 Samsung Electronics Co., Ltd. > + * http://www.samsung.com/ > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > +*/ > + > +#include <linux/kernel.h> > +#include <linux/types.h> > +#include <linux/init.h> > +#include <linux/serial_core.h> > + > +#include <asm/mach/arch.h> > +#include <asm/mach/map.h> > +#include <asm/setup.h> > +#include <asm/mach-types.h> > + > +#include <mach/map.h> > +#include <mach/regs-clock.h> > + > +#include <plat/regs-serial.h> > +#include <plat/s5pv210.h> > +#include <plat/devs.h> > +#include <plat/cpu.h> > + > +/* Following are default values for UCON, ULCON and UFCON UART registers */ > +#define S5PV210_UCON_DEFAULT (S3C2410_UCON_TXILEVEL | \ > + S3C2410_UCON_RXILEVEL | \ > + S3C2410_UCON_TXIRQMODE | \ > + S3C2410_UCON_RXIRQMODE | \ > + S3C2410_UCON_RXFIFO_TOI | \ > + S3C2443_UCON_RXERR_IRQEN) > + > +#define S5PV210_ULCON_DEFAULT S3C2410_LCON_CS8 > + > +#define S5PV210_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | \ > + S5PV210_UFCON_TXTRIG4 | \ > + S5PV210_UFCON_RXTRIG4) > + > +static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = { > + [0] = { > + .hwport = 0, > + .flags = 0, > + .ucon = S5PV210_UCON_DEFAULT, > + .ulcon = S5PV210_ULCON_DEFAULT, > + .ufcon = S5PV210_UFCON_DEFAULT, > + }, > + [1] = { > + .hwport = 1, > + .flags = 0, > + .ucon = S5PV210_UCON_DEFAULT, > + .ulcon = S5PV210_ULCON_DEFAULT, > + .ufcon = S5PV210_UFCON_DEFAULT, > + }, > + [2] = { > + .hwport = 2, > + .flags = 0, > + .ucon = S5PV210_UCON_DEFAULT, > + .ulcon = S5PV210_ULCON_DEFAULT, > + .ufcon = S5PV210_UFCON_DEFAULT, > + }, > + [3] = { > + .hwport = 3, > + .flags = 0, > + .ucon = S5PV210_UCON_DEFAULT, > + .ulcon = S5PV210_ULCON_DEFAULT, > + .ufcon = S5PV210_UFCON_DEFAULT, > + }, > +}; > + > +static struct platform_device *goni_devices[] __initdata = { > +}; If you promise to actually populate this, then it can stay. > +static void __init goni_map_io(void) > +{ > + s5p_init_io(NULL, 0, S5P_VA_CHIPID); > + s3c24xx_init_clocks(24000000); > + s3c24xx_init_uarts(goni_uartcfgs, ARRAY_SIZE(goni_uartcfgs)); > +} > + > +static void __init goni_machine_init(void) > +{ > + platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices)); > +} > + > +MACHINE_START(GONI, "GONI") > + /* Maintainers: Kyungmin Park <kyungmin.park@samsung.com> */ > + .phys_io = S3C_PA_UART & 0xfff00000, > + .io_pg_offst = (((u32)S3C_VA_UART) >> 18) & 0xfffc, > + .boot_params = S5P_PA_SDRAM + 0x100, > + .init_irq = s5pv210_init_irq, > + .map_io = goni_map_io, > + .init_machine = goni_machine_init, > + .timer = &s3c24xx_timer, > +MACHINE_END -- Ben Q: What's a light-year? A: One-third less calories than a regular year. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: S5PV210: Add GONI board support 2010-05-20 0:48 ` Ben Dooks @ 2010-05-20 1:10 ` Kyungmin Park 2010-05-20 1:48 ` Ben Dooks 2010-05-21 19:10 ` Russell King - ARM Linux 0 siblings, 2 replies; 6+ messages in thread From: Kyungmin Park @ 2010-05-20 1:10 UTC (permalink / raw) To: linux-arm-kernel On Thu, May 20, 2010 at 9:48 AM, Ben Dooks <ben-linux@fluff.org> wrote: > On Wed, May 19, 2010 at 11:15:32PM +0900, Joonyoung Shim wrote: >> This is for samsung GONI board using s5pc110. >> >> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> >> Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com> > > I'll think about adding this, however it is very late in the development > cycle, and the only thing saving it from immediate stalling until the next > round is the fact that it is so simple. Hi, In the previous time, Marek sent the s5pv210 patch including the aquila board support. But in this merge cycle, it doesn't included. of course all s5pv210 patches too, Please find the patch subject "ARM: S5PV210: add Aquila board" and check it again. Thank you, Kyungmin Park > >> --- >> ?arch/arm/mach-s5pv210/Kconfig ? ? | ? ?8 +++ >> ?arch/arm/mach-s5pv210/Makefile ? ?| ? ?1 + >> ?arch/arm/mach-s5pv210/mach-goni.c | ? 98 +++++++++++++++++++++++++++++++++++++ >> ?3 files changed, 107 insertions(+), 0 deletions(-) >> ?create mode 100644 arch/arm/mach-s5pv210/mach-goni.c >> >> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig >> index 7601c28..83b15b2 100644 >> --- a/arch/arm/mach-s5pv210/Kconfig >> +++ b/arch/arm/mach-s5pv210/Kconfig >> @@ -36,6 +36,14 @@ config MACH_SMDKC110 >> ? ? ? ? Machine support for Samsung SMDKC110 >> ? ? ? ? S5PC110(MCP) is one of package option of S5PV210 >> >> +config MACH_GONI >> + ? ? bool "GONI" >> + ? ? select CPU_S5PV210 >> + ? ? select ARCH_SPARSEMEM_ENABLE >> + ? ? help >> + ? ? ? Machine support for Samsung GONI board >> + ? ? ? S5PC110(MCP) is one of package option of S5PV210 >> + >> ?endchoice >> >> ?endif >> diff --git a/arch/arm/mach-s5pv210/Makefile b/arch/arm/mach-s5pv210/Makefile >> index 9982781..5135577 100644 >> --- a/arch/arm/mach-s5pv210/Makefile >> +++ b/arch/arm/mach-s5pv210/Makefile >> @@ -19,6 +19,7 @@ obj-$(CONFIG_CPU_S5PV210) ? += setup-i2c0.o >> >> ?obj-$(CONFIG_MACH_SMDKV210) ?+= mach-smdkv210.o >> ?obj-$(CONFIG_MACH_SMDKC110) ?+= mach-smdkc110.o >> +obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? ?+= mach-goni.o >> >> ?# device support >> >> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c >> new file mode 100644 >> index 0000000..4863b13 >> --- /dev/null >> +++ b/arch/arm/mach-s5pv210/mach-goni.c >> @@ -0,0 +1,98 @@ >> +/* linux/arch/arm/mach-s5pv210/mach-goni.c >> + * >> + * Copyright (c) 2010 Samsung Electronics Co., Ltd. >> + * ? ? ? ? ? http://www.samsung.com/ >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> +*/ >> + >> +#include <linux/kernel.h> >> +#include <linux/types.h> >> +#include <linux/init.h> >> +#include <linux/serial_core.h> >> + >> +#include <asm/mach/arch.h> >> +#include <asm/mach/map.h> >> +#include <asm/setup.h> >> +#include <asm/mach-types.h> >> + >> +#include <mach/map.h> >> +#include <mach/regs-clock.h> >> + >> +#include <plat/regs-serial.h> >> +#include <plat/s5pv210.h> >> +#include <plat/devs.h> >> +#include <plat/cpu.h> >> + >> +/* Following are default values for UCON, ULCON and UFCON UART registers */ >> +#define S5PV210_UCON_DEFAULT (S3C2410_UCON_TXILEVEL | ? ? ? ?\ >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXILEVEL | ? ? ? ?\ >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_TXIRQMODE | ? ? ? \ >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXIRQMODE | ? ? ? \ >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXFIFO_TOI | ? ? ?\ >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2443_UCON_RXERR_IRQEN) >> + >> +#define S5PV210_ULCON_DEFAULT ? ? ? ?S3C2410_LCON_CS8 >> + >> +#define S5PV210_UFCON_DEFAULT ? ? ? ?(S3C2410_UFCON_FIFOMODE | ? ? ? \ >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\ >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4) >> + >> +static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = { >> + ? ? [0] = { >> + ? ? ? ? ? ? .hwport ? ? ? ? = 0, >> + ? ? ? ? ? ? .flags ? ? ? ? ?= 0, >> + ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT, >> + ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT, >> + ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT, >> + ? ? }, >> + ? ? [1] = { >> + ? ? ? ? ? ? .hwport ? ? ? ? = 1, >> + ? ? ? ? ? ? .flags ? ? ? ? ?= 0, >> + ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT, >> + ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT, >> + ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT, >> + ? ? }, >> + ? ? [2] = { >> + ? ? ? ? ? ? .hwport ? ? ? ? = 2, >> + ? ? ? ? ? ? .flags ? ? ? ? ?= 0, >> + ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT, >> + ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT, >> + ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT, >> + ? ? }, >> + ? ? [3] = { >> + ? ? ? ? ? ? .hwport ? ? ? ? = 3, >> + ? ? ? ? ? ? .flags ? ? ? ? ?= 0, >> + ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT, >> + ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT, >> + ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT, >> + ? ? }, >> +}; >> + >> +static struct platform_device *goni_devices[] __initdata = { >> +}; > > If you promise to actually populate this, then it can stay. > >> +static void __init goni_map_io(void) >> +{ >> + ? ? s5p_init_io(NULL, 0, S5P_VA_CHIPID); >> + ? ? s3c24xx_init_clocks(24000000); >> + ? ? s3c24xx_init_uarts(goni_uartcfgs, ARRAY_SIZE(goni_uartcfgs)); >> +} >> + >> +static void __init goni_machine_init(void) >> +{ >> + ? ? platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices)); >> +} >> + >> +MACHINE_START(GONI, "GONI") >> + ? ? /* Maintainers: Kyungmin Park <kyungmin.park@samsung.com> */ >> + ? ? .phys_io ? ? ? ?= S3C_PA_UART & 0xfff00000, >> + ? ? .io_pg_offst ? ?= (((u32)S3C_VA_UART) >> 18) & 0xfffc, >> + ? ? .boot_params ? ?= S5P_PA_SDRAM + 0x100, >> + ? ? .init_irq ? ? ? = s5pv210_init_irq, >> + ? ? .map_io ? ? ? ? = goni_map_io, >> + ? ? .init_machine ? = goni_machine_init, >> + ? ? .timer ? ? ? ? ?= &s3c24xx_timer, >> +MACHINE_END > > -- > Ben > > Q: ? ? ?What's a light-year? > A: ? ? ?One-third less calories than a regular year. > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: S5PV210: Add GONI board support 2010-05-20 1:10 ` Kyungmin Park @ 2010-05-20 1:48 ` Ben Dooks 2010-05-21 19:10 ` Russell King - ARM Linux 1 sibling, 0 replies; 6+ messages in thread From: Ben Dooks @ 2010-05-20 1:48 UTC (permalink / raw) To: linux-arm-kernel On Thu, May 20, 2010 at 10:10:33AM +0900, Kyungmin Park wrote: > On Thu, May 20, 2010 at 9:48 AM, Ben Dooks <ben-linux@fluff.org> wrote: > > On Wed, May 19, 2010 at 11:15:32PM +0900, Joonyoung Shim wrote: > >> This is for samsung GONI board using s5pc110. > >> > >> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> > >> Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com> > > > > I'll think about adding this, however it is very late in the development > > cycle, and the only thing saving it from immediate stalling until the next > > round is the fact that it is so simple. > > Hi, > > In the previous time, Marek sent the s5pv210 patch including the > aquila board support. > But in this merge cycle, it doesn't included. of course all s5pv210 patches too, > Please find the patch subject "ARM: S5PV210: add Aquila board" and > check it again. I thought he said it depended on some other work and it was being held until this was sorted. Will check with Marek again and find out what is going on. If it is mergeable I will add it in with the final pull request to Russell to sort out the S5PC100 re-arangement that is currently going on. > Thank you, > Kyungmin Park > > > >> --- > >> ?arch/arm/mach-s5pv210/Kconfig ? ? | ? ?8 +++ > >> ?arch/arm/mach-s5pv210/Makefile ? ?| ? ?1 + > >> ?arch/arm/mach-s5pv210/mach-goni.c | ? 98 +++++++++++++++++++++++++++++++++++++ > >> ?3 files changed, 107 insertions(+), 0 deletions(-) > >> ?create mode 100644 arch/arm/mach-s5pv210/mach-goni.c > >> > >> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig > >> index 7601c28..83b15b2 100644 > >> --- a/arch/arm/mach-s5pv210/Kconfig > >> +++ b/arch/arm/mach-s5pv210/Kconfig > >> @@ -36,6 +36,14 @@ config MACH_SMDKC110 > >> ? ? ? ? Machine support for Samsung SMDKC110 > >> ? ? ? ? S5PC110(MCP) is one of package option of S5PV210 > >> > >> +config MACH_GONI > >> + ? ? bool "GONI" > >> + ? ? select CPU_S5PV210 > >> + ? ? select ARCH_SPARSEMEM_ENABLE > >> + ? ? help > >> + ? ? ? Machine support for Samsung GONI board > >> + ? ? ? S5PC110(MCP) is one of package option of S5PV210 > >> + > >> ?endchoice > >> > >> ?endif > >> diff --git a/arch/arm/mach-s5pv210/Makefile b/arch/arm/mach-s5pv210/Makefile > >> index 9982781..5135577 100644 > >> --- a/arch/arm/mach-s5pv210/Makefile > >> +++ b/arch/arm/mach-s5pv210/Makefile > >> @@ -19,6 +19,7 @@ obj-$(CONFIG_CPU_S5PV210) ? += setup-i2c0.o > >> > >> ?obj-$(CONFIG_MACH_SMDKV210) ?+= mach-smdkv210.o > >> ?obj-$(CONFIG_MACH_SMDKC110) ?+= mach-smdkc110.o > >> +obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? ?+= mach-goni.o > >> > >> ?# device support > >> > >> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c > >> new file mode 100644 > >> index 0000000..4863b13 > >> --- /dev/null > >> +++ b/arch/arm/mach-s5pv210/mach-goni.c > >> @@ -0,0 +1,98 @@ > >> +/* linux/arch/arm/mach-s5pv210/mach-goni.c > >> + * > >> + * Copyright (c) 2010 Samsung Electronics Co., Ltd. > >> + * ? ? ? ? ? http://www.samsung.com/ > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2 as > >> + * published by the Free Software Foundation. > >> +*/ > >> + > >> +#include <linux/kernel.h> > >> +#include <linux/types.h> > >> +#include <linux/init.h> > >> +#include <linux/serial_core.h> > >> + > >> +#include <asm/mach/arch.h> > >> +#include <asm/mach/map.h> > >> +#include <asm/setup.h> > >> +#include <asm/mach-types.h> > >> + > >> +#include <mach/map.h> > >> +#include <mach/regs-clock.h> > >> + > >> +#include <plat/regs-serial.h> > >> +#include <plat/s5pv210.h> > >> +#include <plat/devs.h> > >> +#include <plat/cpu.h> > >> + > >> +/* Following are default values for UCON, ULCON and UFCON UART registers */ > >> +#define S5PV210_UCON_DEFAULT (S3C2410_UCON_TXILEVEL | ? ? ? ?\ > >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXILEVEL | ? ? ? ?\ > >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_TXIRQMODE | ? ? ? \ > >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXIRQMODE | ? ? ? \ > >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXFIFO_TOI | ? ? ?\ > >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2443_UCON_RXERR_IRQEN) > >> + > >> +#define S5PV210_ULCON_DEFAULT ? ? ? ?S3C2410_LCON_CS8 > >> + > >> +#define S5PV210_UFCON_DEFAULT ? ? ? ?(S3C2410_UFCON_FIFOMODE | ? ? ? \ > >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\ > >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4) > >> + > >> +static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = { > >> + ? ? [0] = { > >> + ? ? ? ? ? ? .hwport ? ? ? ? = 0, > >> + ? ? ? ? ? ? .flags ? ? ? ? ?= 0, > >> + ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT, > >> + ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT, > >> + ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT, > >> + ? ? }, > >> + ? ? [1] = { > >> + ? ? ? ? ? ? .hwport ? ? ? ? = 1, > >> + ? ? ? ? ? ? .flags ? ? ? ? ?= 0, > >> + ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT, > >> + ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT, > >> + ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT, > >> + ? ? }, > >> + ? ? [2] = { > >> + ? ? ? ? ? ? .hwport ? ? ? ? = 2, > >> + ? ? ? ? ? ? .flags ? ? ? ? ?= 0, > >> + ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT, > >> + ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT, > >> + ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT, > >> + ? ? }, > >> + ? ? [3] = { > >> + ? ? ? ? ? ? .hwport ? ? ? ? = 3, > >> + ? ? ? ? ? ? .flags ? ? ? ? ?= 0, > >> + ? ? ? ? ? ? .ucon ? ? ? ? ? = S5PV210_UCON_DEFAULT, > >> + ? ? ? ? ? ? .ulcon ? ? ? ? ?= S5PV210_ULCON_DEFAULT, > >> + ? ? ? ? ? ? .ufcon ? ? ? ? ?= S5PV210_UFCON_DEFAULT, > >> + ? ? }, > >> +}; > >> + > >> +static struct platform_device *goni_devices[] __initdata = { > >> +}; > > > > If you promise to actually populate this, then it can stay. > > > >> +static void __init goni_map_io(void) > >> +{ > >> + ? ? s5p_init_io(NULL, 0, S5P_VA_CHIPID); > >> + ? ? s3c24xx_init_clocks(24000000); > >> + ? ? s3c24xx_init_uarts(goni_uartcfgs, ARRAY_SIZE(goni_uartcfgs)); > >> +} > >> + > >> +static void __init goni_machine_init(void) > >> +{ > >> + ? ? platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices)); > >> +} > >> + > >> +MACHINE_START(GONI, "GONI") > >> + ? ? /* Maintainers: Kyungmin Park <kyungmin.park@samsung.com> */ > >> + ? ? .phys_io ? ? ? ?= S3C_PA_UART & 0xfff00000, > >> + ? ? .io_pg_offst ? ?= (((u32)S3C_VA_UART) >> 18) & 0xfffc, > >> + ? ? .boot_params ? ?= S5P_PA_SDRAM + 0x100, > >> + ? ? .init_irq ? ? ? = s5pv210_init_irq, > >> + ? ? .map_io ? ? ? ? = goni_map_io, > >> + ? ? .init_machine ? = goni_machine_init, > >> + ? ? .timer ? ? ? ? ?= &s3c24xx_timer, > >> +MACHINE_END > > > > -- > > Ben > > > > Q: ? ? ?What's a light-year? > > A: ? ? ?One-third less calories than a regular year. > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel at lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > -- -- Ben Q: What's a light-year? A: One-third less calories than a regular year. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: S5PV210: Add GONI board support 2010-05-20 1:10 ` Kyungmin Park 2010-05-20 1:48 ` Ben Dooks @ 2010-05-21 19:10 ` Russell King - ARM Linux 2010-05-21 23:24 ` Kyungmin Park 1 sibling, 1 reply; 6+ messages in thread From: Russell King - ARM Linux @ 2010-05-21 19:10 UTC (permalink / raw) To: linux-arm-kernel On Thu, May 20, 2010 at 10:10:33AM +0900, Kyungmin Park wrote: > In the previous time, Marek sent the s5pv210 patch including the > aquila board support. > But in this merge cycle, it doesn't included. of course all s5pv210 patches too, > Please find the patch subject "ARM: S5PV210: add Aquila board" and > check it again. The merge windows are not for people to send their patches which they've been sitting on to mailing lists. The merge window is for the patches prepared and reviewed _prior_ to the merge window opening, and which have been tested in the linux-next tree to be merged into Linus' tree. I make this comment because it seems to me that as soon as the merge window opened, this mailing list immediately got flooded with Samsung patches. This is not the way it works. In future, please prepare your patches before the merge window, and submit them to the mailing list for review as soon as they're prepared. Once they've been reviewed, they can be queued and sit in linux-next for a while for the following merge window. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: S5PV210: Add GONI board support 2010-05-21 19:10 ` Russell King - ARM Linux @ 2010-05-21 23:24 ` Kyungmin Park 0 siblings, 0 replies; 6+ messages in thread From: Kyungmin Park @ 2010-05-21 23:24 UTC (permalink / raw) To: linux-arm-kernel On Sat, May 22, 2010 at 4:10 AM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Thu, May 20, 2010 at 10:10:33AM +0900, Kyungmin Park wrote: >> In the previous time, Marek sent the s5pv210 patch including the >> aquila board support. >> But in this merge cycle, it doesn't included. of course all s5pv210 patches too, >> Please find the patch subject "ARM: S5PV210: add Aquila board" and >> check it again. > > The merge windows are not for people to send their patches which they've > been sitting on to mailing lists. ?The merge window is for the patches > prepared and reviewed _prior_ to the merge window opening, and which > have been tested in the linux-next tree to be merged into Linus' tree. Right, I know that. but please note that the aquila board support mail is posted it at Mar 25. 2 month ago!!!. the May 20 is updated version with recent samsung patches. > > I make this comment because it seems to me that as soon as the merge > window opened, this mailing list immediately got flooded with Samsung > patches. ?This is not the way it works. > > In future, please prepare your patches before the merge window, and > submit them to the mailing list for review as soon as they're prepared. > Once they've been reviewed, they can be queued and sit in linux-next > for a while for the following merge window. I also ask please talk to ben how to merge samsung patches in the future I proper send the patches and request to pull too. Thank you, Kyungmin Park > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-05-21 23:24 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-05-19 14:15 [PATCH] ARM: S5PV210: Add GONI board support Joonyoung Shim 2010-05-20 0:48 ` Ben Dooks 2010-05-20 1:10 ` Kyungmin Park 2010-05-20 1:48 ` Ben Dooks 2010-05-21 19:10 ` Russell King - ARM Linux 2010-05-21 23:24 ` Kyungmin Park
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.