From: Marek Vasut <marek.vasut@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/11] [ARM] pxa: Storage class should be before const qualifier
Date: Thu, 20 May 2010 10:26:13 +0000 [thread overview]
Message-ID: <201005201226.13337.marek.vasut@gmail.com> (raw)
In-Reply-To: <1274344306-8735-1-git-send-email-tklauser@distanz.ch>
Dne Čt 20. května 2010 10:31:46 Tobias Klauser napsal(a):
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> arch/arm/mach-pxa/palmtc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/palmtc.c b/arch/arm/mach-pxa/palmtc.c
> index 033b567..ce1104d 100644
> --- a/arch/arm/mach-pxa/palmtc.c
> +++ b/arch/arm/mach-pxa/palmtc.c
> @@ -263,11 +263,11 @@ const struct matrix_keymap_data palmtc_keymap_data > { .keymap_size = ARRAY_SIZE(palmtc_matrix_keys),
> };
>
> -const static unsigned int palmtc_keypad_row_gpios[] = {
> +static const unsigned int palmtc_keypad_row_gpios[] = {
> 0, 9, 10, 11
> };
>
> -const static unsigned int palmtc_keypad_col_gpios[] = {
> +static const unsigned int palmtc_keypad_col_gpios[] = {
> 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 79, 80
> };
Ok, if that's the case, you have my ack:
Acked-by: Marek Vasut <marek.vasut@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/11] [ARM] pxa: Storage class should be before const qualifier
Date: Thu, 20 May 2010 12:26:13 +0200 [thread overview]
Message-ID: <201005201226.13337.marek.vasut@gmail.com> (raw)
In-Reply-To: <1274344306-8735-1-git-send-email-tklauser@distanz.ch>
Dne ?t 20. kv?tna 2010 10:31:46 Tobias Klauser napsal(a):
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> arch/arm/mach-pxa/palmtc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/palmtc.c b/arch/arm/mach-pxa/palmtc.c
> index 033b567..ce1104d 100644
> --- a/arch/arm/mach-pxa/palmtc.c
> +++ b/arch/arm/mach-pxa/palmtc.c
> @@ -263,11 +263,11 @@ const struct matrix_keymap_data palmtc_keymap_data =
> { .keymap_size = ARRAY_SIZE(palmtc_matrix_keys),
> };
>
> -const static unsigned int palmtc_keypad_row_gpios[] = {
> +static const unsigned int palmtc_keypad_row_gpios[] = {
> 0, 9, 10, 11
> };
>
> -const static unsigned int palmtc_keypad_col_gpios[] = {
> +static const unsigned int palmtc_keypad_col_gpios[] = {
> 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 79, 80
> };
Ok, if that's the case, you have my ack:
Acked-by: Marek Vasut <marek.vasut@gmail.com>
next prev parent reply other threads:[~2010-05-20 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 8:31 [PATCH 01/11] [ARM] pxa: Storage class should be before const qualifier Tobias Klauser
2010-05-20 8:31 ` Tobias Klauser
2010-05-20 10:26 ` Marek Vasut [this message]
2010-05-20 10:26 ` Marek Vasut
2010-05-20 15:05 ` [PATCH 01/11] [ARM] pxa: Storage class should be before const Eric Miao
2010-05-20 15:05 ` [PATCH 01/11] [ARM] pxa: Storage class should be before const qualifier Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005201226.13337.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.