All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
	linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	eric.y.miao@gmail.com, haojian.zhuang@gmail.com
Subject: Re: [PATCH] PXA DMA-capable PATA driver
Date: Thu, 20 May 2010 12:28:42 +0200	[thread overview]
Message-ID: <201005201228.42325.marek.vasut@gmail.com> (raw)
In-Reply-To: <4BF4F773.102@gmail.com>

Dne Čt 20. května 2010 10:48:51 Tejun Heo napsal(a):
> On 05/18/2010 12:53 AM, Marek Vasut wrote:
> > 4766 /**
> > 4767  *      atapi_check_dma - Check whether ATAPI DMA can be supported
> > 4768  *      @qc: Metadata associated with taskfile to check
> > 4769  *
> > 4770  *      Allow low-level driver to filter ATA PACKET commands,
> > returning 4771  *      a status indicating whether or not it is OK to
> > use DMA for the 4772  *      supplied PACKET command.
> > 4773  *
> > 4774  *      LOCKING:
> > 4775  *      spin_lock_irqsave(host lock)
> > 4776  *
> > 4777  *      RETURNS: 0 when ATAPI DMA can be used
> > 4778  *               nonzero otherwise
> > 4779  */
> > 
> > this is from libata-core.c FYI and -EOPNOTSUPP is non-zero.
> 
> Argh... that method needs to be changed to return bool.

That'd make sense.

WARNING: multiple messages have this Message-ID (diff)
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PXA DMA-capable PATA driver
Date: Thu, 20 May 2010 12:28:42 +0200	[thread overview]
Message-ID: <201005201228.42325.marek.vasut@gmail.com> (raw)
In-Reply-To: <4BF4F773.102@gmail.com>

Dne ?t 20. kv?tna 2010 10:48:51 Tejun Heo napsal(a):
> On 05/18/2010 12:53 AM, Marek Vasut wrote:
> > 4766 /**
> > 4767  *      atapi_check_dma - Check whether ATAPI DMA can be supported
> > 4768  *      @qc: Metadata associated with taskfile to check
> > 4769  *
> > 4770  *      Allow low-level driver to filter ATA PACKET commands,
> > returning 4771  *      a status indicating whether or not it is OK to
> > use DMA for the 4772  *      supplied PACKET command.
> > 4773  *
> > 4774  *      LOCKING:
> > 4775  *      spin_lock_irqsave(host lock)
> > 4776  *
> > 4777  *      RETURNS: 0 when ATAPI DMA can be used
> > 4778  *               nonzero otherwise
> > 4779  */
> > 
> > this is from libata-core.c FYI and -EOPNOTSUPP is non-zero.
> 
> Argh... that method needs to be changed to return bool.

That'd make sense.

  reply	other threads:[~2010-05-20 10:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-10  3:02 [PATCH] PXA DMA-capable PATA driver Marek Vasut
2010-05-10  3:02 ` Marek Vasut
2010-05-14 13:51 ` Marek Vasut
2010-05-14 13:51   ` Marek Vasut
2010-05-14 17:42   ` Jeff Garzik
2010-05-14 17:42     ` Jeff Garzik
2010-05-14 22:03 ` Jeff Garzik
2010-05-14 22:03   ` Jeff Garzik
2010-05-14 22:23   ` Marek Vasut
2010-05-14 22:23     ` Marek Vasut
2010-05-15 20:48     ` Robert Jarzmik
2010-05-15 20:48       ` Robert Jarzmik
2010-05-16  1:00       ` Marek Vasut
2010-05-16  1:00         ` Marek Vasut
2010-05-17 15:35         ` Robert Jarzmik
2010-05-17 15:35           ` Robert Jarzmik
2010-05-17 22:53   ` Marek Vasut
2010-05-17 22:53     ` Marek Vasut
2010-05-20  8:48     ` Tejun Heo
2010-05-20  8:48       ` Tejun Heo
2010-05-20 10:28       ` Marek Vasut [this message]
2010-05-20 10:28         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005201228.42325.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=eric.y.miao@gmail.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.