* [PATCH 09/11] Staging: hv: Storage class should be before const qualifier
@ 2010-05-20 8:39 Tobias Klauser
2010-05-20 8:53 ` [PATCH 09/11] Staging: hv: Storage class should be before Joe Perches
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tobias Klauser @ 2010-05-20 8:39 UTC (permalink / raw)
To: kernel-janitors
The C99 specification states in section 6.11.5:
The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/staging/hv/vmbus_drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
index c21731a..4f6f640 100644
--- a/drivers/staging/hv/vmbus_drv.c
+++ b/drivers/staging/hv/vmbus_drv.c
@@ -1025,7 +1025,7 @@ static void __exit vmbus_exit(void)
* installed and/or configured. We don't do anything else with the table, but
* it needs to be present.
*/
-const static struct pci_device_id microsoft_hv_pci_table[] = {
+static const struct pci_device_id microsoft_hv_pci_table[] = {
{ PCI_DEVICE(0x1414, 0x5353) }, /* VGA compatible controller */
{ 0 }
};
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 09/11] Staging: hv: Storage class should be before
2010-05-20 8:39 [PATCH 09/11] Staging: hv: Storage class should be before const qualifier Tobias Klauser
@ 2010-05-20 8:53 ` Joe Perches
2010-05-20 15:36 ` Greg KH
2010-05-20 16:36 ` Joe Perches
2 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2010-05-20 8:53 UTC (permalink / raw)
To: kernel-janitors
On Thu, 2010-05-20 at 10:39 +0200, Tobias Klauser wrote:
> +++ b/drivers/staging/hv/vmbus_drv.c
> -const static struct pci_device_id microsoft_hv_pci_table[] = {
> +static const struct pci_device_id microsoft_hv_pci_table[] = {
> { PCI_DEVICE(0x1414, 0x5353) }, /* VGA compatible controller
> */
> { 0 }
> };
DEFINE_PCI_DEVICE_TABLE ?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 09/11] Staging: hv: Storage class should be before
2010-05-20 8:39 [PATCH 09/11] Staging: hv: Storage class should be before const qualifier Tobias Klauser
2010-05-20 8:53 ` [PATCH 09/11] Staging: hv: Storage class should be before Joe Perches
@ 2010-05-20 15:36 ` Greg KH
2010-05-20 16:36 ` Joe Perches
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2010-05-20 15:36 UTC (permalink / raw)
To: kernel-janitors
On Thu, May 20, 2010 at 01:53:34AM -0700, Joe Perches wrote:
> On Thu, 2010-05-20 at 10:39 +0200, Tobias Klauser wrote:
> > +++ b/drivers/staging/hv/vmbus_drv.c
> > -const static struct pci_device_id microsoft_hv_pci_table[] = {
> > +static const struct pci_device_id microsoft_hv_pci_table[] = {
> > { PCI_DEVICE(0x1414, 0x5353) }, /* VGA compatible controller
> > */
> > { 0 }
> > };
>
> DEFINE_PCI_DEVICE_TABLE ?
No, I hate that macro.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 09/11] Staging: hv: Storage class should be before
2010-05-20 8:39 [PATCH 09/11] Staging: hv: Storage class should be before const qualifier Tobias Klauser
2010-05-20 8:53 ` [PATCH 09/11] Staging: hv: Storage class should be before Joe Perches
2010-05-20 15:36 ` Greg KH
@ 2010-05-20 16:36 ` Joe Perches
2 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2010-05-20 16:36 UTC (permalink / raw)
To: kernel-janitors
On Thu, 2010-05-20 at 08:36 -0700, Greg KH wrote:
> On Thu, May 20, 2010 at 01:53:34AM -0700, Joe Perches wrote:
> > On Thu, 2010-05-20 at 10:39 +0200, Tobias Klauser wrote:
> > > +++ b/drivers/staging/hv/vmbus_drv.c
> > > -const static struct pci_device_id microsoft_hv_pci_table[] = {
> > > +static const struct pci_device_id microsoft_hv_pci_table[] = {
> > > { PCI_DEVICE(0x1414, 0x5353) }, /* VGA compatible controller
> > > */
> > > { 0 }
> > > };
> >
> > DEFINE_PCI_DEVICE_TABLE ?
>
> No, I hate that macro.
You mean the one that every other instance of a definition
of struct pci_device_id uses? The one that puts the data
in .devinit.rodata?
Didn't you signed off on 90a1ba0c5e39eeea278f263c28ae02166c5911c8 ?
What happened to change your mind?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-20 16:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-20 8:39 [PATCH 09/11] Staging: hv: Storage class should be before const qualifier Tobias Klauser
2010-05-20 8:53 ` [PATCH 09/11] Staging: hv: Storage class should be before Joe Perches
2010-05-20 15:36 ` Greg KH
2010-05-20 16:36 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.