From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] Driver for the i.MX2x CMOS Sensor Interface
Date: Tue, 25 May 2010 09:20:04 +0200 [thread overview]
Message-ID: <20100525072004.GI17272@pengutronix.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1005212023400.8450@axis700.grange>
On Fri, May 21, 2010 at 08:33:40PM +0200, Guennadi Liakhovetski wrote:
> On Fri, 21 May 2010, Baruch Siach wrote:
>
> > Hi Sascha,
> >
> > On Fri, May 21, 2010 at 09:20:45AM +0200, Sascha Hauer wrote:
> > > On Thu, May 06, 2010 at 04:09:38PM +0300, Baruch Siach wrote:
> > > > This series contains a soc_camera driver for the i.MX25/i.MX27 CSI device, and
> > > > platform code for the i.MX25 and i.MX27 chips. This driver is based on a driver
> > > > for i.MX27 CSI from Sascha Hauer, that Alan Carvalho de Assis has posted in
> > > > linux-media last December[1]. Since all I have is a i.MX25 PDK paltform I can't
> > > > test the mx27 specific code. Testers and comment are welcome.
> > > >
> > > > [1] https://patchwork.kernel.org/patch/67636/
> > > >
> > > > Baruch Siach (3):
> > > > mx2_camera: Add soc_camera support for i.MX25/i.MX27
> > > > mx27: add support for the CSI device
> > > > mx25: add support for the CSI device
> > >
> > > With the two additions I sent I can confirm this working on i.MX27, so
> > > no need to remove the related code.
> >
> > Thanks. I'll add your patches to my queue and resend the series next week.
>
> Firstly, Sascha, unfortunately, you've forgotten to CC the maintainer,
> that will have to deal with these patches.
>
> Secondly, I don't think that's a good idea to submit mx27 fixes as
> incremental patches. I'd prefer to have them rolled into the actual driver
> submission patches, where Sascha would just add his Sob / acked-by /
> tested-by / whatever... Or you can first submit an mx25-only driver and
> let Sascha add mx27 to it, in which case this would be a functionality
> extension, but not a fix of a broken driver.
My intention with these fixes was that Baruch integrates them into his
patch (which he did).
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Baruch Siach <baruch@tkos.co.il>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] Driver for the i.MX2x CMOS Sensor Interface
Date: Tue, 25 May 2010 09:20:04 +0200 [thread overview]
Message-ID: <20100525072004.GI17272@pengutronix.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1005212023400.8450@axis700.grange>
On Fri, May 21, 2010 at 08:33:40PM +0200, Guennadi Liakhovetski wrote:
> On Fri, 21 May 2010, Baruch Siach wrote:
>
> > Hi Sascha,
> >
> > On Fri, May 21, 2010 at 09:20:45AM +0200, Sascha Hauer wrote:
> > > On Thu, May 06, 2010 at 04:09:38PM +0300, Baruch Siach wrote:
> > > > This series contains a soc_camera driver for the i.MX25/i.MX27 CSI device, and
> > > > platform code for the i.MX25 and i.MX27 chips. This driver is based on a driver
> > > > for i.MX27 CSI from Sascha Hauer, that Alan Carvalho de Assis has posted in
> > > > linux-media last December[1]. Since all I have is a i.MX25 PDK paltform I can't
> > > > test the mx27 specific code. Testers and comment are welcome.
> > > >
> > > > [1] https://patchwork.kernel.org/patch/67636/
> > > >
> > > > Baruch Siach (3):
> > > > mx2_camera: Add soc_camera support for i.MX25/i.MX27
> > > > mx27: add support for the CSI device
> > > > mx25: add support for the CSI device
> > >
> > > With the two additions I sent I can confirm this working on i.MX27, so
> > > no need to remove the related code.
> >
> > Thanks. I'll add your patches to my queue and resend the series next week.
>
> Firstly, Sascha, unfortunately, you've forgotten to CC the maintainer,
> that will have to deal with these patches.
>
> Secondly, I don't think that's a good idea to submit mx27 fixes as
> incremental patches. I'd prefer to have them rolled into the actual driver
> submission patches, where Sascha would just add his Sob / acked-by /
> tested-by / whatever... Or you can first submit an mx25-only driver and
> let Sascha add mx27 to it, in which case this would be a functionality
> extension, but not a fix of a broken driver.
My intention with these fixes was that Baruch integrates them into his
patch (which he did).
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2010-05-25 7:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 13:09 [PATCH 0/3] Driver for the i.MX2x CMOS Sensor Interface Baruch Siach
2010-05-06 13:09 ` Baruch Siach
2010-05-06 13:09 ` [PATCH 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27 Baruch Siach
2010-05-06 13:09 ` Baruch Siach
2010-05-12 19:02 ` Guennadi Liakhovetski
2010-05-12 19:02 ` Guennadi Liakhovetski
2010-05-13 5:21 ` Baruch Siach
2010-05-13 5:21 ` Baruch Siach
2010-05-17 7:27 ` Sascha Hauer
2010-05-17 7:27 ` Sascha Hauer
2010-05-17 13:58 ` Baruch Siach
2010-05-17 13:58 ` Baruch Siach
2010-05-19 8:55 ` Sascha Hauer
2010-05-19 8:55 ` Sascha Hauer
2010-05-21 7:19 ` Sascha Hauer
2010-05-21 7:19 ` Sascha Hauer
2010-05-06 13:09 ` [PATCH 2/3] mx27: add support for the CSI device Baruch Siach
2010-05-06 13:09 ` Baruch Siach
2010-05-21 7:17 ` Sascha Hauer
2010-05-21 7:17 ` Sascha Hauer
2010-05-06 13:09 ` [PATCH 3/3] mx25: " Baruch Siach
2010-05-06 13:09 ` Baruch Siach
2010-05-12 19:11 ` Guennadi Liakhovetski
2010-05-12 19:11 ` Guennadi Liakhovetski
2010-05-21 7:20 ` [PATCH 0/3] Driver for the i.MX2x CMOS Sensor Interface Sascha Hauer
2010-05-21 7:20 ` Sascha Hauer
2010-05-21 7:27 ` Baruch Siach
2010-05-21 7:27 ` Baruch Siach
2010-05-21 18:33 ` Guennadi Liakhovetski
2010-05-21 18:33 ` Guennadi Liakhovetski
2010-05-25 7:20 ` Sascha Hauer [this message]
2010-05-25 7:20 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525072004.GI17272@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.