From: Andrew Morton <akpm@linux-foundation.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Julia Lawall <julia@diku.dk>,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 12/27] drivers/ieee1394: Use memdup_user
Date: Tue, 25 May 2010 22:32:44 +0000 [thread overview]
Message-ID: <20100525153244.73069b6a.akpm@linux-foundation.org> (raw)
In-Reply-To: <4BF7A31B.2040302@s5r6.in-berlin.de>
On Sat, 22 May 2010 11:25:47 +0200
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> Julia Lawall wrote:
> > Use memdup_user when user data is immediately copied into the
> > allocated region.
>
> Looks nice. We won't apply janitorial updates to drivers/ieee1394
> anymore though, since it is made obsolete by drivers/firewire and to be
> removed sooner than later. (I will post a proposed removal schedule
> today to make this better known.)
I don't see much point in declaring a moratorium against
drivers/ieee1394. Perhaps that removal will never happen. Perhaps
third parties will find reason to revert that removal and to continue
to maintain drivers/ieee1394. Perhaps people will take code snippets
from drivers/ieee1394 and will move them into drivers/firewire.
The bottom line is that the patch improves the code. And there ain't
nothing wrong with having better code.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Julia Lawall <julia@diku.dk>,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 12/27] drivers/ieee1394: Use memdup_user
Date: Tue, 25 May 2010 15:32:44 -0700 [thread overview]
Message-ID: <20100525153244.73069b6a.akpm@linux-foundation.org> (raw)
In-Reply-To: <4BF7A31B.2040302@s5r6.in-berlin.de>
On Sat, 22 May 2010 11:25:47 +0200
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> Julia Lawall wrote:
> > Use memdup_user when user data is immediately copied into the
> > allocated region.
>
> Looks nice. We won't apply janitorial updates to drivers/ieee1394
> anymore though, since it is made obsolete by drivers/firewire and to be
> removed sooner than later. (I will post a proposed removal schedule
> today to make this better known.)
I don't see much point in declaring a moratorium against
drivers/ieee1394. Perhaps that removal will never happen. Perhaps
third parties will find reason to revert that removal and to continue
to maintain drivers/ieee1394. Perhaps people will take code snippets
from drivers/ieee1394 and will move them into drivers/firewire.
The bottom line is that the patch improves the code. And there ain't
nothing wrong with having better code.
next prev parent reply other threads:[~2010-05-25 22:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 8:22 [PATCH 12/27] drivers/ieee1394: Use memdup_user Julia Lawall
2010-05-22 8:22 ` Julia Lawall
2010-05-22 9:25 ` Stefan Richter
2010-05-22 9:25 ` Stefan Richter
2010-05-25 22:32 ` Andrew Morton [this message]
2010-05-25 22:32 ` Andrew Morton
2010-05-25 23:25 ` Stefan Richter
2010-05-25 23:25 ` Stefan Richter
2010-05-31 16:58 ` Stefan Richter
2010-05-31 16:58 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525153244.73069b6a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.