All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Dan Carpenter <error27@gmail.com>,
	Herbert Xu <herbert@gondor.hengli.com.au>,
	Henrik Kretzschmar <henne@nachtwindheim.de>,
	Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] padata: add parenthesis in MAX_SEQ_NR macro
Date: Wed, 26 May 2010 06:32:27 +0000	[thread overview]
Message-ID: <20100526063227.GP2184@secunet.com> (raw)
In-Reply-To: <20100525212913.GK22515@bicker>

On Tue, May 25, 2010 at 11:29:13PM +0200, Dan Carpenter wrote:
> MAX_SEQ_NR is used in padata_alloc_pd() like this:
> 
>         pd->max_seq_nr = (MAX_SEQ_NR / num_cpus) * num_cpus - 1;
> 
> It needs parenthesis or the divide by num_cpus takes precedence over the
> subtraction.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Acked-by: Steffen Klassert <steffen.klassert@secunet.com>

Thanks,

Steffen

WARNING: multiple messages have this Message-ID (diff)
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Dan Carpenter <error27@gmail.com>,
	Herbert Xu <herbert@gondor.hengli.com.au>,
	Henrik Kretzschmar <henne@nachtwindheim.de>,
	Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] padata: add parenthesis in MAX_SEQ_NR macro
Date: Wed, 26 May 2010 08:32:27 +0200	[thread overview]
Message-ID: <20100526063227.GP2184@secunet.com> (raw)
In-Reply-To: <20100525212913.GK22515@bicker>

On Tue, May 25, 2010 at 11:29:13PM +0200, Dan Carpenter wrote:
> MAX_SEQ_NR is used in padata_alloc_pd() like this:
> 
>         pd->max_seq_nr = (MAX_SEQ_NR / num_cpus) * num_cpus - 1;
> 
> It needs parenthesis or the divide by num_cpus takes precedence over the
> subtraction.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Acked-by: Steffen Klassert <steffen.klassert@secunet.com>

Thanks,

Steffen

  reply	other threads:[~2010-05-26  6:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-25 21:29 [patch] padata: add parenthesis in MAX_SEQ_NR macro Dan Carpenter
2010-05-25 21:29 ` Dan Carpenter
2010-05-26  6:32 ` Steffen Klassert [this message]
2010-05-26  6:32   ` Steffen Klassert
2010-06-03 10:19   ` Herbert Xu
2010-06-03 10:19     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100526063227.GP2184@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=error27@gmail.com \
    --cc=henne@nachtwindheim.de \
    --cc=herbert@gondor.hengli.com.au \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.