Re: [PATCH] KVM: svm: Fix erratum 383 check for 32-bit hosts

["Roedel, Joerg" <Joerg.Roedel@amd.com>]

On Wed, May 26, 2010 at 03:11:17AM -0400, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This overflow should have left the check broken behind for 32-bit hosts.

The check itself should work but it gives a compile warning for me (at
least in my small userspace test I did ;) Good catch, thanks.

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Acked-by: Joerg Roedel <joerg.roedel@amd.com>

> ---
>  arch/x86/kvm/svm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 3c03c36..fd32791 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -1460,7 +1460,7 @@ static bool is_erratum_383(void)
>  	/* Bit 62 may or may not be set for this mce */
>  	value &= ~(1ULL << 62);
>  
> -	if (value != 0xb600000000010015)
> +	if (value != 0xb600000000010015ULL)
>  		return false;
>  
>  	/* Clear MCi_STATUS registers */
> -- 
> 1.6.0.2
>