From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: svm: Fix erratum 383 check for 32-bit hosts
Date: Wed, 26 May 2010 10:00:06 +0200 [thread overview]
Message-ID: <20100526080006.GE23190@amd.com> (raw)
In-Reply-To: <4BFCD43B.7070702@web.de>
On Wed, May 26, 2010 at 03:56:43AM -0400, Jan Kiszka wrote:
> Roedel, Joerg wrote:
> > On Wed, May 26, 2010 at 03:11:17AM -0400, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> This overflow should have left the check broken behind for 32-bit hosts.
> >
> > The check itself should work but it gives a compile warning for me (at
> > least in my small userspace test I did ;) Good catch, thanks.
>
> To my understanding, the test degraded to value != 0x00010015. That may
> not have the intended effect, no?
I tested this with a small test program in userspace (compiled with
gcc -m32) and the check actually works. But I get a compile warning
because the constant is too large for type long. So I think the check
should work in the 32 bit kernel too.
Joerg
prev parent reply other threads:[~2010-05-26 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 7:11 [PATCH] KVM: svm: Fix erratum 383 check for 32-bit hosts Jan Kiszka
2010-05-26 7:45 ` Roedel, Joerg
2010-05-26 7:56 ` Jan Kiszka
2010-05-26 8:00 ` Roedel, Joerg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526080006.GE23190@amd.com \
--to=joerg.roedel@amd.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.