From: Jean Delvare <khali@linux-fr.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
"Beholder Intl. Ltd. Dmitry Belimov" <d.belimov@gmail.com>,
hermann pitton <hermann-pitton@arcor.de>,
Douglas Schilling Landgraf <dougsland@redhat.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v3 2/2] video/saa7134: remove duplicate break
Date: Wed, 26 May 2010 12:43:43 +0000 [thread overview]
Message-ID: <20100526144343.0c2369da@hyperion.delvare> (raw)
In-Reply-To: <20100525092149.GA13089@bicker>
On Tue, 25 May 2010 11:21:50 +0200, Dan Carpenter wrote:
> The original code had two break statements in a row.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
> ---
> v3: Put this in a seperate patch.
>
> diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
> index e5565e2..7691bf2 100644
> --- a/drivers/media/video/saa7134/saa7134-input.c
> +++ b/drivers/media/video/saa7134/saa7134-input.c
> @@ -815,7 +815,6 @@ int saa7134_input_init1(struct saa7134_dev *dev)
> mask_keyup = 0x020000;
> polling = 50; /* ms */
> break;
> - break;
> }
> if (NULL = ir_codes) {
> printk("%s: Oops: IR config error [card=%d]\n",
>
--
Jean Delvare
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
"Beholder Intl. Ltd. Dmitry Belimov" <d.belimov@gmail.com>,
hermann pitton <hermann-pitton@arcor.de>,
Douglas Schilling Landgraf <dougsland@redhat.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v3 2/2] video/saa7134: remove duplicate break
Date: Wed, 26 May 2010 14:43:43 +0200 [thread overview]
Message-ID: <20100526144343.0c2369da@hyperion.delvare> (raw)
In-Reply-To: <20100525092149.GA13089@bicker>
On Tue, 25 May 2010 11:21:50 +0200, Dan Carpenter wrote:
> The original code had two break statements in a row.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
> ---
> v3: Put this in a seperate patch.
>
> diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
> index e5565e2..7691bf2 100644
> --- a/drivers/media/video/saa7134/saa7134-input.c
> +++ b/drivers/media/video/saa7134/saa7134-input.c
> @@ -815,7 +815,6 @@ int saa7134_input_init1(struct saa7134_dev *dev)
> mask_keyup = 0x020000;
> polling = 50; /* ms */
> break;
> - break;
> }
> if (NULL == ir_codes) {
> printk("%s: Oops: IR config error [card=%d]\n",
>
--
Jean Delvare
next prev parent reply other threads:[~2010-05-26 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 9:21 [patch v3 2/2] video/saa7134: remove duplicate break Dan Carpenter
2010-05-25 9:21 ` Dan Carpenter
2010-05-26 12:43 ` Jean Delvare [this message]
2010-05-26 12:43 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526144343.0c2369da@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=d.belimov@gmail.com \
--cc=dougsland@redhat.com \
--cc=error27@gmail.com \
--cc=hermann-pitton@arcor.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.