All of lore.kernel.org
 help / color / mirror / Atom feed
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Baruch Siach <baruch@tkos.co.il>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH] fbdev: fix frame buffer devices menu
Date: Wed, 26 May 2010 19:02:15 +0000	[thread overview]
Message-ID: <20100526190215.GA11764@pengutronix.de> (raw)
In-Reply-To: <1274896477-6832-1-git-send-email-cascardo@holoscopio.com>

Hello,

On Wed, May 26, 2010 at 02:54:37PM -0300, Thadeu Lima de Souza Cascardo wrote:
> Commit f601441916d1e19291d0b4f044b4a7551e2924d0 has inserted the symbol
> HAVE_FB_IMX, which does not depend on FB after the menuconfig FB. This
> breaks the menu, presenting most of the drivers outside of it, when
> using menuconfig.
> 
> Moving the symbol to the start of the file, just like HAVE_FB_ATMEL,
> fixes the problem without breaking it for iMX25 configurations (tested
> with ARCH=arm, no build).
> 
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
You're right,

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Baruch Siach <baruch@tkos.co.il>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH] fbdev: fix frame buffer devices menu
Date: Wed, 26 May 2010 21:02:15 +0200	[thread overview]
Message-ID: <20100526190215.GA11764@pengutronix.de> (raw)
In-Reply-To: <1274896477-6832-1-git-send-email-cascardo@holoscopio.com>

Hello,

On Wed, May 26, 2010 at 02:54:37PM -0300, Thadeu Lima de Souza Cascardo wrote:
> Commit f601441916d1e19291d0b4f044b4a7551e2924d0 has inserted the symbol
> HAVE_FB_IMX, which does not depend on FB after the menuconfig FB. This
> breaks the menu, presenting most of the drivers outside of it, when
> using menuconfig.
> 
> Moving the symbol to the start of the file, just like HAVE_FB_ATMEL,
> fixes the problem without breaking it for iMX25 configurations (tested
> with ARCH=arm, no build).
> 
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
You're right,

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2010-05-26 19:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26 17:54 [PATCH] fbdev: fix frame buffer devices menu Thadeu Lima de Souza Cascardo
2010-05-26 17:54 ` Thadeu Lima de Souza Cascardo
2010-05-26 19:02 `  [this message]
2010-05-26 19:02   ` Uwe Kleine-König
2010-05-27  4:03 ` Baruch Siach
2010-05-27  4:03   ` Baruch Siach
2010-06-01 21:28   ` Andrew Morton
2010-06-01 21:28     ` Andrew Morton
2010-06-01 21:41     ` Randy Dunlap
2010-06-01 21:41       ` Randy Dunlap
2010-06-02  4:34     ` Baruch Siach
2010-06-02  4:34       ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100526190215.GA11764@pengutronix.de \
    --to=cascardo@holoscopio.com \
    --cc=baruch@tkos.co.il \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.