Re: [PATCHv2] mac80211: Fix basic rates for created IBSS networks

[Bruno Randolf <br1@einfach.org>]

On Wednesday 26 May 2010 23:14:36 you wrote:
> Needs to be split up (setting bss_conf and the bss_change flag is a
> separate bugfix) and tested but this is what I think it should be like.

thanks for this!

> +	} else {
> +		/*
> +		 * If no rates were explicitly configured,
> +		 * use the mandatory rate set for 11b or
> +		 * 11a for maximum compatibility.
> +		 */
> +		struct ieee80211_supported_band *sband =
> +			wiphy->bands[ibss.channel->band];
> +		int j;
> +		u32 flag = ibss.channel->band == IEEE80211_BAND_5GHZ ?
> +				IEEE80211_RATE_MANDATORY_A :
> +				IEEE80211_RATE_MANDATORY_B;
> +
> +		for (j = 0; j < sband->n_bitrates; j++) {
> +			if (sband->bitrates[j].flags & flag)
> +				ibss.basic_rates |= j;
> +		}
> +	}

couldn't we use ieee80211_mandatory_rates() here?

bruno