All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benoit Papillault <benoit.papillault@free.fr>
To: Bruno Randolf <br1@einfach.org>
Cc: linville@tuxdriver.com, juuso.oikarinen@nokia.com,
	johannes@sipsolutions.net, ath5k-devel@lists.ath5k.org,
	linux-wireless@vger.kernel.org
Subject: Re: [ath5k-devel] [PATCH] mac80211: mark 1, 2,	5.5 and 11Mbps as mandatory rates for 802.11b
Date: Thu, 27 May 2010 08:02:06 +0200	[thread overview]
Message-ID: <4BFE0ADE.2090403@free.fr> (raw)
In-Reply-To: <20100527004545.11541.88667.stgit@tt-desk>

Le 27/05/2010 02:45, Bruno Randolf a écrit :
> IEEE802.11-2007 clause 18.2.3.3 (p640) states that 1, 2, 5.5&  11 Mbits are
> mandatory rates for what they call High Rate direct sequence spread spectrum
> (HR/DSSS) PHY (with long PLCP).
>
> Signed-off-by: Bruno Randolf<br1@einfach.org>
> ---
>   net/wireless/util.c |   12 ++++++------
>   1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/net/wireless/util.c b/net/wireless/util.c
> index 3416373..f6f4101 100644
> --- a/net/wireless/util.c
> +++ b/net/wireless/util.c
> @@ -100,17 +100,17 @@ static void set_mandatory_flags_band(struct ieee80211_supported_band *sband,
>   	case IEEE80211_BAND_2GHZ:
>   		want = 7;
>   		for (i = 0; i<  sband->n_bitrates; i++) {
> -			if (sband->bitrates[i].bitrate == 10) {
> +			if (sband->bitrates[i].bitrate == 10 ||
> +			    sband->bitrates[i].bitrate == 20 ||
> +			    sband->bitrates[i].bitrate == 55 ||
> +			    sband->bitrates[i].bitrate == 110) {
>   				sband->bitrates[i].flags |=
>   					IEEE80211_RATE_MANDATORY_B |
>   					IEEE80211_RATE_MANDATORY_G;
>   				want--;
>   			}
>
> -			if (sband->bitrates[i].bitrate == 20 ||
> -			    sband->bitrates[i].bitrate == 55 ||
> -			    sband->bitrates[i].bitrate == 110 ||
> -			    sband->bitrates[i].bitrate == 60 ||
> +			if (sband->bitrates[i].bitrate == 60 ||
>   			    sband->bitrates[i].bitrate == 120 ||
>   			    sband->bitrates[i].bitrate == 240) {
>   				sband->bitrates[i].flags |=
> @@ -125,7 +125,7 @@ static void set_mandatory_flags_band(struct ieee80211_supported_band *sband,
>   				sband->bitrates[i].flags |=
>   					IEEE80211_RATE_ERP_G;
>   		}
> -		WARN_ON(want != 0&&  want != 3&&  want != 6);
> +		WARN_ON(want != 0&&  want != 3);
>   		break;
>   	case IEEE80211_NUM_BANDS:
>   		WARN_ON(1);
>

Acked-by: Benoit Papillault <benoit.papillault@free.fr>

Regards,
Benoit

  reply	other threads:[~2010-05-27  6:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26 12:48 [PATCHv2] mac80211: Fix basic rates for created IBSS networks Juuso Oikarinen
2010-05-26 12:53 ` Johannes Berg
2010-05-26 13:13   ` Juuso Oikarinen
2010-05-26 13:27     ` Johannes Berg
2010-05-27  4:50       ` Juuso Oikarinen
2010-05-26 14:14     ` Johannes Berg
2010-05-27  0:41       ` Bruno Randolf
2010-05-27  8:12         ` Johannes Berg
2010-05-27  0:45       ` [PATCH] mac80211: mark 1, 2, 5.5 and 11Mbps as mandatory rates for 802.11b Bruno Randolf
2010-05-27  6:02         ` Benoit Papillault [this message]
2010-05-27  8:08         ` Johannes Berg
2010-05-27  8:11           ` Johannes Berg
2010-05-27 12:09           ` Benoit Papillault
2010-05-27 12:13             ` Johannes Berg
2010-05-27  5:06       ` [PATCHv2] mac80211: Fix basic rates for created IBSS networks Juuso Oikarinen
2010-05-27  8:11         ` Johannes Berg
2010-05-27  8:28           ` Juuso Oikarinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFE0ADE.2090403@free.fr \
    --to=benoit.papillault@free.fr \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=br1@einfach.org \
    --cc=johannes@sipsolutions.net \
    --cc=juuso.oikarinen@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.