From: "Luis Claudio R. Goncalves" <lclaudio@uudg.org>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Oleg Nesterov <oleg@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
williams@redhat.com
Subject: [RFC] oom-kill: give the dying task a higher priority
Date: Thu, 27 May 2010 15:04:31 -0300 [thread overview]
Message-ID: <20100527180431.GP13035@uudg.org> (raw)
Hello,
Could you please review this patch?
The idea behind it is quite simple: give the dying task a higher priority
so that it can be scheduled sooner and die to free memory.
oom-kill: give the dying task a higher priority
In a system under heavy load it was observed that even after the
oom-killer selects a task to die, the task may take a long time to die.
Right before sending a SIGKILL to the selected task the oom-killer
increases the task priority so that it can exit quickly, freeing memory.
That is accomplished by:
/*
* We give our sacrificial lamb high priority and access to
* all the memory it needs. That way it should be able to
* exit() and clear out its resources quickly...
*/
p->rt.time_slice = HZ;
set_tsk_thread_flag(p, TIF_MEMDIE);
It sounds plausible giving the dying task an even higher priority to be
sure it will be scheduled sooner and free the desired memory.
Signed-off-by: Luis Claudio R. Gonçalves <lclaudio@uudg.org>
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index b68e802..8047309 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -382,6 +382,8 @@ static void dump_header(struct task_struct *p, gfp_t gfp_mask, int order,
*/
static void __oom_kill_task(struct task_struct *p, int verbose)
{
+ struct sched_param param;
+
if (is_global_init(p)) {
WARN_ON(1);
printk(KERN_WARNING "tried to kill init!\n");
@@ -413,6 +415,8 @@ static void __oom_kill_task(struct task_struct *p, int verbose)
*/
p->rt.time_slice = HZ;
set_tsk_thread_flag(p, TIF_MEMDIE);
+ param.sched_priority = MAX_RT_PRIO-1;
+ sched_setscheduler(p, SCHED_FIFO, ¶m);
force_sig(SIGKILL, p);
}
Thanks,
Luis
--
[ Luis Claudio R. Goncalves Bass - Gospel - RT ]
[ Fingerprint: 4FDD B8C4 3C59 34BD 8BE9 2696 7203 D980 A448 C8F8 ]
WARNING: multiple messages have this Message-ID (diff)
From: "Luis Claudio R. Goncalves" <lclaudio@uudg.org>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Oleg Nesterov <oleg@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
williams@redhat.com
Subject: [RFC] oom-kill: give the dying task a higher priority
Date: Thu, 27 May 2010 15:04:31 -0300 [thread overview]
Message-ID: <20100527180431.GP13035@uudg.org> (raw)
Hello,
Could you please review this patch?
The idea behind it is quite simple: give the dying task a higher priority
so that it can be scheduled sooner and die to free memory.
oom-kill: give the dying task a higher priority
In a system under heavy load it was observed that even after the
oom-killer selects a task to die, the task may take a long time to die.
Right before sending a SIGKILL to the selected task the oom-killer
increases the task priority so that it can exit quickly, freeing memory.
That is accomplished by:
/*
* We give our sacrificial lamb high priority and access to
* all the memory it needs. That way it should be able to
* exit() and clear out its resources quickly...
*/
p->rt.time_slice = HZ;
set_tsk_thread_flag(p, TIF_MEMDIE);
It sounds plausible giving the dying task an even higher priority to be
sure it will be scheduled sooner and free the desired memory.
Signed-off-by: Luis Claudio R. Goncalves <lclaudio@uudg.org>
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index b68e802..8047309 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -382,6 +382,8 @@ static void dump_header(struct task_struct *p, gfp_t gfp_mask, int order,
*/
static void __oom_kill_task(struct task_struct *p, int verbose)
{
+ struct sched_param param;
+
if (is_global_init(p)) {
WARN_ON(1);
printk(KERN_WARNING "tried to kill init!\n");
@@ -413,6 +415,8 @@ static void __oom_kill_task(struct task_struct *p, int verbose)
*/
p->rt.time_slice = HZ;
set_tsk_thread_flag(p, TIF_MEMDIE);
+ param.sched_priority = MAX_RT_PRIO-1;
+ sched_setscheduler(p, SCHED_FIFO, ¶m);
force_sig(SIGKILL, p);
}
Thanks,
Luis
--
[ Luis Claudio R. Goncalves Bass - Gospel - RT ]
[ Fingerprint: 4FDD B8C4 3C59 34BD 8BE9 2696 7203 D980 A448 C8F8 ]
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2010-05-27 18:04 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 18:04 Luis Claudio R. Goncalves [this message]
2010-05-27 18:04 ` [RFC] oom-kill: give the dying task a higher priority Luis Claudio R. Goncalves
2010-05-27 18:33 ` Oleg Nesterov
2010-05-27 18:33 ` Oleg Nesterov
2010-05-28 2:54 ` KOSAKI Motohiro
2010-05-28 2:54 ` KOSAKI Motohiro
2010-05-28 3:51 ` Luis Claudio R. Goncalves
2010-05-28 3:51 ` Luis Claudio R. Goncalves
2010-05-28 4:33 ` Balbir Singh
2010-05-28 4:33 ` Balbir Singh
2010-05-28 4:46 ` KOSAKI Motohiro
2010-05-28 4:46 ` KOSAKI Motohiro
2010-05-28 5:30 ` Minchan Kim
2010-05-28 5:30 ` Minchan Kim
2010-05-28 5:39 ` KOSAKI Motohiro
2010-05-28 5:39 ` KOSAKI Motohiro
2010-05-28 5:50 ` Minchan Kim
2010-05-28 5:50 ` Minchan Kim
2010-05-28 5:59 ` KOSAKI Motohiro
2010-05-28 5:59 ` KOSAKI Motohiro
2010-05-28 7:52 ` Minchan Kim
2010-05-28 7:52 ` Minchan Kim
2010-05-28 12:53 ` Luis Claudio R. Goncalves
2010-05-28 12:53 ` Luis Claudio R. Goncalves
2010-05-28 14:06 ` Minchan Kim
2010-05-28 14:06 ` Minchan Kim
2010-05-28 14:20 ` Balbir Singh
2010-05-28 14:20 ` Balbir Singh
2010-05-28 15:03 ` Minchan Kim
2010-05-28 15:03 ` Minchan Kim
2010-05-28 14:36 ` Luis Claudio R. Goncalves
2010-05-28 14:36 ` Luis Claudio R. Goncalves
2010-05-28 15:12 ` Minchan Kim
2010-05-28 15:12 ` Minchan Kim
2010-05-28 15:21 ` Peter Zijlstra
2010-05-28 15:21 ` Peter Zijlstra
2010-05-28 15:35 ` Minchan Kim
2010-05-28 15:35 ` Minchan Kim
2010-05-28 15:28 ` Luis Claudio R. Goncalves
2010-05-28 15:28 ` Luis Claudio R. Goncalves
2010-05-28 15:45 ` Minchan Kim
2010-05-28 15:45 ` Minchan Kim
2010-05-28 16:48 ` Luis Claudio R. Goncalves
2010-05-28 16:48 ` Luis Claudio R. Goncalves
2010-05-29 3:59 ` KOSAKI Motohiro
2010-05-29 3:59 ` KOSAKI Motohiro
2010-05-31 2:15 ` Luis Claudio R. Goncalves
2010-05-31 2:15 ` Luis Claudio R. Goncalves
2010-05-31 5:06 ` Minchan Kim
2010-05-31 5:06 ` Minchan Kim
2010-05-31 6:35 ` KOSAKI Motohiro
2010-05-31 6:35 ` KOSAKI Motohiro
2010-05-31 7:05 ` Minchan Kim
2010-05-31 7:05 ` Minchan Kim
2010-05-31 7:25 ` KAMEZAWA Hiroyuki
2010-05-31 7:25 ` KAMEZAWA Hiroyuki
2010-05-31 9:30 ` Minchan Kim
2010-05-31 9:30 ` Minchan Kim
2010-05-30 15:09 ` Minchan Kim
2010-05-30 15:09 ` Minchan Kim
2010-05-31 0:21 ` KAMEZAWA Hiroyuki
2010-05-31 0:21 ` KAMEZAWA Hiroyuki
2010-05-31 5:01 ` Minchan Kim
2010-05-31 5:01 ` Minchan Kim
2010-05-31 5:04 ` KAMEZAWA Hiroyuki
2010-05-31 5:04 ` KAMEZAWA Hiroyuki
2010-05-31 5:46 ` Minchan Kim
2010-05-31 5:46 ` Minchan Kim
2010-05-31 5:54 ` KAMEZAWA Hiroyuki
2010-05-31 5:54 ` KAMEZAWA Hiroyuki
2010-05-31 6:09 ` Minchan Kim
2010-05-31 6:09 ` Minchan Kim
2010-05-31 6:51 ` KAMEZAWA Hiroyuki
2010-05-31 6:51 ` KAMEZAWA Hiroyuki
2010-05-31 10:33 ` Minchan Kim
2010-05-31 10:33 ` Minchan Kim
2010-05-31 13:52 ` Luis Claudio R. Goncalves
2010-05-31 13:52 ` Luis Claudio R. Goncalves
2010-05-31 23:50 ` KAMEZAWA Hiroyuki
2010-05-31 23:50 ` KAMEZAWA Hiroyuki
2010-06-01 17:35 ` Luis Claudio R. Goncalves
2010-06-01 17:35 ` Luis Claudio R. Goncalves
2010-06-01 20:49 ` David Rientjes
2010-06-01 20:49 ` David Rientjes
2010-06-02 13:54 ` KOSAKI Motohiro
2010-06-02 13:54 ` KOSAKI Motohiro
2010-06-02 14:20 ` Luis Claudio R. Goncalves
2010-06-02 14:20 ` Luis Claudio R. Goncalves
2010-06-02 21:11 ` David Rientjes
2010-06-02 21:11 ` David Rientjes
2010-06-02 23:36 ` KOSAKI Motohiro
2010-06-02 23:36 ` KOSAKI Motohiro
2010-06-03 0:52 ` Minchan Kim
2010-06-03 0:52 ` Minchan Kim
2010-06-03 7:50 ` Peter Zijlstra
2010-06-03 7:50 ` Peter Zijlstra
2010-06-03 20:32 ` David Rientjes
2010-06-03 20:32 ` David Rientjes
2010-06-01 8:19 ` Minchan Kim
2010-06-01 8:19 ` Minchan Kim
2010-06-01 18:36 ` David Rientjes
2010-06-01 18:36 ` David Rientjes
2010-05-28 6:27 ` Balbir Singh
2010-05-28 6:27 ` Balbir Singh
2010-05-28 6:34 ` KAMEZAWA Hiroyuki
2010-05-28 6:34 ` KAMEZAWA Hiroyuki
2010-05-28 6:38 ` KOSAKI Motohiro
2010-05-28 6:38 ` KOSAKI Motohiro
2010-05-28 15:53 ` Peter Zijlstra
2010-05-28 15:53 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527180431.GP13035@uudg.org \
--to=lclaudio@uudg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.