From: Alan Cox <alan@linux.intel.com>
To: "Ds, Sreedhara" <sreedhara.ds@intel.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"mjg@redhat.com" <mjg@redhat.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [Patch 1/4] intel scu ipc
Date: Fri, 28 May 2010 19:51:33 +0100 [thread overview]
Message-ID: <20100528195133.708ab02c@linux.intel.com> (raw)
In-Reply-To: <0AE3E14D83C76F4994657326177D1FF9042CE9F49C@bgsmsx501.gar.corp.intel.com>
On Fri, 28 May 2010 14:09:39 +0530
"Ds, Sreedhara" <sreedhara.ds@intel.com> wrote:
> Hello,
> Please review and accept the patch
>
>
> From 443010eead6d69e3b60b460fd3f82344de95da5d Mon Sep 17 00:00:00 2001
> From: Sreedhara DS <sreedhara.ds@intel.com>
> Date: Fri, 28 May 2010 13:53:38 +0530
> Subject: [PATCH] changes to find platform type during int
> modified: intel_scu_ipc.c
>
>
> Signed-off-by: Sreedhara DS <sreedhara.ds@intel.com>
Code is fine but your subject/comments don't reflect the patch. That
causes problems for the upstream merge because the upstream history
needs to accurately describe it.
Something like
Subject: intel_scu_ipc: detect CPU type automatically
Intel SCU message formats depend upon the processor type. Replace the
module option with automatic detection of the processor type.
----
Code looks fine and I'll add it to the Meego working tree but with the
comment I quoted if that is ok
Alan
next prev parent reply other threads:[~2010-05-28 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 8:39 [Patch 1/4] intel scu ipc Ds, Sreedhara
2010-05-28 18:51 ` Alan Cox [this message]
2010-05-30 15:39 ` Ds, Sreedhara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528195133.708ab02c@linux.intel.com \
--to=alan@linux.intel.com \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sreedhara.ds@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.