From: Jean Delvare <khali@linux-fr.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Dan Carpenter <error27@gmail.com>,
"Beholder Intl. Ltd. Dmitry Belimov" <d.belimov@gmail.com>,
hermann pitton <hermann-pitton@arcor.de>,
Douglas Schilling Landgraf <dougsland@redhat.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] video/saa7134: potential null dereferences in debug
Date: Sat, 29 May 2010 07:06:52 +0000 [thread overview]
Message-ID: <20100529090652.2e8f5e43@hyperion.delvare> (raw)
In-Reply-To: <20100529012954.25490c3a@pedra>
On Sat, 29 May 2010 01:29:54 -0300, Mauro Carvalho Chehab wrote:
> Em Sat, 22 May 2010 22:59:21 +0200
> Jean Delvare <khali@linux-fr.org> escreveu:
> > I would have used "(null)" instead of "<null>" for consistency with
> > lib/vsprintf.c:string().
> >
> > But more importantly, I suspect that a better fix would be to not call
> > these macros when dev or ir, respectively, is NULL. The faulty dprintk
> > calls in get_key_msi_tvanywhere_plus() and get_key_flydvb_trio() could
> > be replaced with i2cdprintk (which is misnamed IMHO, BTW.)
>
> Agreed.
>
> Dan, could you please rework your patch according with Jean's feedback?
He did already.
--
Jean Delvare
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Dan Carpenter <error27@gmail.com>,
"Beholder Intl. Ltd. Dmitry Belimov" <d.belimov@gmail.com>,
hermann pitton <hermann-pitton@arcor.de>,
Douglas Schilling Landgraf <dougsland@redhat.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] video/saa7134: potential null dereferences in debug code
Date: Sat, 29 May 2010 09:06:52 +0200 [thread overview]
Message-ID: <20100529090652.2e8f5e43@hyperion.delvare> (raw)
In-Reply-To: <20100529012954.25490c3a@pedra>
On Sat, 29 May 2010 01:29:54 -0300, Mauro Carvalho Chehab wrote:
> Em Sat, 22 May 2010 22:59:21 +0200
> Jean Delvare <khali@linux-fr.org> escreveu:
> > I would have used "(null)" instead of "<null>" for consistency with
> > lib/vsprintf.c:string().
> >
> > But more importantly, I suspect that a better fix would be to not call
> > these macros when dev or ir, respectively, is NULL. The faulty dprintk
> > calls in get_key_msi_tvanywhere_plus() and get_key_flydvb_trio() could
> > be replaced with i2cdprintk (which is misnamed IMHO, BTW.)
>
> Agreed.
>
> Dan, could you please rework your patch according with Jean's feedback?
He did already.
--
Jean Delvare
next prev parent reply other threads:[~2010-05-29 7:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 20:15 [patch] video/saa7134: potential null dereferences in debug code Dan Carpenter
2010-05-22 20:15 ` Dan Carpenter
2010-05-22 20:59 ` [patch] video/saa7134: potential null dereferences in debug Jean Delvare
2010-05-22 20:59 ` [patch] video/saa7134: potential null dereferences in debug code Jean Delvare
2010-05-24 15:59 ` [patch v2] video/saa7134: change dprintk() to i2cdprintk() Dan Carpenter
2010-05-24 15:59 ` Dan Carpenter
2010-05-24 18:04 ` Jean Delvare
2010-05-24 18:04 ` Jean Delvare
2010-05-29 4:29 ` [patch] video/saa7134: potential null dereferences in debug Mauro Carvalho Chehab
2010-05-29 4:29 ` [patch] video/saa7134: potential null dereferences in debug code Mauro Carvalho Chehab
2010-05-29 7:06 ` Jean Delvare [this message]
2010-05-29 7:06 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529090652.2e8f5e43@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=d.belimov@gmail.com \
--cc=dougsland@redhat.com \
--cc=error27@gmail.com \
--cc=hermann-pitton@arcor.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.