From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mike Fedyk <mfedyk@mikefedyk.com>
Cc: Dan Carpenter <error27@gmail.com>,
linux-btrfs@vger.kernel.org, Yan Zheng <zheng.yan@oracle.com>,
Josef Bacik <josef@redhat.com>,
Chris Mason <chris.mason@oracle.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 5/11] btrfs: remove unneeded null check in btrfs_rename()
Date: Sat, 29 May 2010 19:26:39 +0000 [thread overview]
Message-ID: <20100529192639.GP31073@ZenIV.linux.org.uk> (raw)
In-Reply-To: <AANLkTikLkpTgkOGi8M8VL_rZRLyzbJKoKW9RiNMJenMi@mail.gmail.com>
On Sat, May 29, 2010 at 11:01:56AM -0700, Mike Fedyk wrote:
> I think code like this is here because there are still a lot of
> features that are being added to btrfs and it's easier to have the
> additional checks than continually adding and removing them as the
> code changes.
_What_ features? Check for ->rename() argument not being negative is
done outside of btrfs.
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mike Fedyk <mfedyk@mikefedyk.com>
Cc: Dan Carpenter <error27@gmail.com>,
linux-btrfs@vger.kernel.org, Yan Zheng <zheng.yan@oracle.com>,
Josef Bacik <josef@redhat.com>,
Chris Mason <chris.mason@oracle.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 5/11] btrfs: remove unneeded null check in btrfs_rename()
Date: Sat, 29 May 2010 20:26:39 +0100 [thread overview]
Message-ID: <20100529192639.GP31073@ZenIV.linux.org.uk> (raw)
In-Reply-To: <AANLkTikLkpTgkOGi8M8VL_rZRLyzbJKoKW9RiNMJenMi@mail.gmail.com>
On Sat, May 29, 2010 at 11:01:56AM -0700, Mike Fedyk wrote:
> I think code like this is here because there are still a lot of
> features that are being added to btrfs and it's easier to have the
> additional checks than continually adding and removing them as the
> code changes.
_What_ features? Check for ->rename() argument not being negative is
done outside of btrfs.
next prev parent reply other threads:[~2010-05-29 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 9:45 [patch 5/11] btrfs: remove unneeded null check in btrfs_rename() Dan Carpenter
2010-05-29 9:45 ` Dan Carpenter
2010-05-29 18:01 ` Mike Fedyk
2010-05-29 18:01 ` Mike Fedyk
2010-05-29 19:26 ` Al Viro [this message]
2010-05-29 19:26 ` Al Viro
2010-05-31 7:25 ` [patch 5/11] btrfs: remove unneeded null check in Dan Carpenter
2010-05-31 7:25 ` [patch 5/11] btrfs: remove unneeded null check in btrfs_rename() Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529192639.GP31073@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chris.mason@oracle.com \
--cc=error27@gmail.com \
--cc=josef@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=mfedyk@mikefedyk.com \
--cc=zheng.yan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.