From: Christoph Hellwig <hch@lst.de>
To: bharrosh@panasas.com
Cc: linux-fsdevel@vger.kernel.org
Subject: exofs_file_fsync
Date: Mon, 31 May 2010 12:09:27 +0200 [thread overview]
Message-ID: <20100531100927.GA11149@lst.de> (raw)
Various odd things going on here:
- no checks for I_DIRTY and friends, so it will always write out data
- filemap_write_and_wait is superflous, as it's already done by
the caller
- write_inode_now is overkill as it also writes out data, better use
sync_inode in a similar way to generic_file_fsync
next reply other threads:[~2010-05-31 10:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 10:09 Christoph Hellwig [this message]
2010-05-31 10:23 ` exofs_file_fsync Boaz Harrosh
2010-05-31 10:27 ` exofs_file_fsync Christoph Hellwig
2010-05-31 10:31 ` exofs_file_fsync Boaz Harrosh
2010-05-31 10:33 ` exofs_file_fsync Christoph Hellwig
2010-05-31 13:43 ` exofs_file_fsync Boaz Harrosh
2010-05-31 13:46 ` exofs_file_fsync Boaz Harrosh
2010-06-01 10:05 ` exofs_file_fsync Christoph Hellwig
2010-06-01 10:04 ` exofs_file_fsync Christoph Hellwig
2010-06-01 15:29 ` exofs_file_fsync Boaz Harrosh
2010-06-01 15:30 ` [PATCH] exofs: exofs_file_fsync correctness Boaz Harrosh
2010-06-01 15:33 ` [osd-dev] " Boaz Harrosh
2010-06-01 15:34 ` Christoph Hellwig
2010-06-01 15:40 ` Boaz Harrosh
2010-06-01 15:47 ` Christoph Hellwig
2010-06-01 16:10 ` Boaz Harrosh
2010-06-01 16:11 ` [PATCH ver2] exofs: exofs_file_fsync and exofs_file_flush correctness Boaz Harrosh
2010-06-01 16:17 ` Christoph Hellwig
2010-06-01 16:36 ` Boaz Harrosh
2010-06-01 17:03 ` [PATCH ver3] " Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531100927.GA11149@lst.de \
--to=hch@lst.de \
--cc=bharrosh@panasas.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.