From: Boaz Harrosh <bharrosh@panasas.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: exofs_file_fsync
Date: Tue, 01 Jun 2010 18:29:04 +0300 [thread overview]
Message-ID: <4C052740.1070200@panasas.com> (raw)
In-Reply-To: <20100601100401.GB28762@lst.de>
On 06/01/2010 01:04 PM, Christoph Hellwig wrote:
>
> The pages are written by vfs_fsync_range. You need to make sure
> that the inode back, or if the datasync flag is set only changes
> to the inode require to find that data are written back. That's
> basically a messy wording for you can skip dirtiness of timestamp
> updates if the datasync flag is set.
>
> Note that your patch below is very wrong for this, as it does
> a lot of asynchronous activity if the datasync flag is not set.
>
Thank you Christoph. Me smack me on the head. Got two unrelated
flags totally confused.
I'll be posting a fix. For the best of my knowledge all I need is
a synchronous call to sync_inode() which will in turn call
exofs_write_inode. The later takes care of all metadata an exofs inode has.
(No allocation bitmaps, no data nodes lists, etc...)
In a next patch I'll also fix the super-block shit. Testing ...
Boaz
next prev parent reply other threads:[~2010-06-01 15:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 10:09 exofs_file_fsync Christoph Hellwig
2010-05-31 10:23 ` exofs_file_fsync Boaz Harrosh
2010-05-31 10:27 ` exofs_file_fsync Christoph Hellwig
2010-05-31 10:31 ` exofs_file_fsync Boaz Harrosh
2010-05-31 10:33 ` exofs_file_fsync Christoph Hellwig
2010-05-31 13:43 ` exofs_file_fsync Boaz Harrosh
2010-05-31 13:46 ` exofs_file_fsync Boaz Harrosh
2010-06-01 10:05 ` exofs_file_fsync Christoph Hellwig
2010-06-01 10:04 ` exofs_file_fsync Christoph Hellwig
2010-06-01 15:29 ` Boaz Harrosh [this message]
2010-06-01 15:30 ` [PATCH] exofs: exofs_file_fsync correctness Boaz Harrosh
2010-06-01 15:33 ` [osd-dev] " Boaz Harrosh
2010-06-01 15:34 ` Christoph Hellwig
2010-06-01 15:40 ` Boaz Harrosh
2010-06-01 15:47 ` Christoph Hellwig
2010-06-01 16:10 ` Boaz Harrosh
2010-06-01 16:11 ` [PATCH ver2] exofs: exofs_file_fsync and exofs_file_flush correctness Boaz Harrosh
2010-06-01 16:17 ` Christoph Hellwig
2010-06-01 16:36 ` Boaz Harrosh
2010-06-01 17:03 ` [PATCH ver3] " Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C052740.1070200@panasas.com \
--to=bharrosh@panasas.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.