All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Thomas Monjalon <thomas_ml@monjalon.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-ppc: remove useless line
Date: Mon, 31 May 2010 20:45:16 +0200	[thread overview]
Message-ID: <20100531184516.GV4621@ohm.aurel32.net> (raw)
In-Reply-To: <1275073245-20352-1-git-send-email-thomas_ml@monjalon.net>

On Fri, May 28, 2010 at 09:00:45PM +0200, Thomas Monjalon wrote:
> From: Thomas Monjalon <thomas@monjalon.net>
> 
> This line was a bit clear.
> The next lines set or reset this bit (LE) depending of another bit (ILE).
> So the first line is useless.

Thanks, applied.

> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  target-ppc/helper.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/target-ppc/helper.c b/target-ppc/helper.c
> index 3d843b5..dabf1fd 100644
> --- a/target-ppc/helper.c
> +++ b/target-ppc/helper.c
> @@ -2591,7 +2591,6 @@ static inline void powerpc_excp(CPUState *env, int excp_model, int excp)
>  #if 0 /* Fix this: not on all targets */
>      new_msr &= ~((target_ulong)1 << MSR_PMM);
>  #endif
> -    new_msr &= ~((target_ulong)1 << MSR_LE);
>      if (msr_ile)
>          new_msr |= (target_ulong)1 << MSR_LE;
>      else
> -- 
> 1.7.1
> 
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

      parent reply	other threads:[~2010-05-31 18:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-28 19:00 [Qemu-devel] [PATCH] target-ppc: remove useless line Thomas Monjalon
2010-05-29 13:31 ` Andreas Färber
2010-05-31  9:49   ` Alexander Graf
2010-05-31 13:11     ` Thomas Monjalon
2010-05-31 14:59       ` Alexander Graf
2010-05-31 18:45 ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100531184516.GV4621@ohm.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=thomas_ml@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.