All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Thomas Monjalon <thomas_ml@monjalon.net>
Cc: "Andreas Färber" <andreas.faerber@web.de>,
	"qemu-devel Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-ppc: remove useless line
Date: Mon, 31 May 2010 16:59:17 +0200	[thread overview]
Message-ID: <4C03CEC5.5010203@suse.de> (raw)
In-Reply-To: <201005311511.13701.thomas_ml@monjalon.net>

Thomas Monjalon wrote:
> Alexander Graf wrote:
>   
>> Thomas, have you verified that it still boots a ppc64 guest?
>>     
>
> No, but I don't see any specific link between ppc64 and this change.
>
> This is the current (pseudo)code:
>     LE = 0
>     if ILE == 1
>         LE = 1
>     else
>         LE = 0
> In all cases, LE will be overwritten after the first line.
>
> I cannot see any justification to keep the first line.
>   

I agree.

Alex

  reply	other threads:[~2010-05-31 14:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-28 19:00 [Qemu-devel] [PATCH] target-ppc: remove useless line Thomas Monjalon
2010-05-29 13:31 ` Andreas Färber
2010-05-31  9:49   ` Alexander Graf
2010-05-31 13:11     ` Thomas Monjalon
2010-05-31 14:59       ` Alexander Graf [this message]
2010-05-31 18:45 ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C03CEC5.5010203@suse.de \
    --to=agraf@suse.de \
    --cc=andreas.faerber@web.de \
    --cc=qemu-devel@nongnu.org \
    --cc=thomas_ml@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.