From: Ben Dooks <ben@trinity.fluff.org>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org,
Banajit Goswami <banajit.g@samsung.com>
Subject: Re: [PATCH] ARM: S5PC100: Add Watchdog support for S5PC100
Date: Tue, 1 Jun 2010 03:35:36 +0100 [thread overview]
Message-ID: <20100601023536.GA30276@trinity.fluff.org> (raw)
In-Reply-To: <1275357892-21314-1-git-send-email-kgene.kim@samsung.com>
On Tue, Jun 01, 2010 at 11:04:52AM +0900, Kukjin Kim wrote:
> From: Banajit Goswami <banajit.g@samsung.com>
>
> This patch adds support for Watchdog timer for Samsung S5PC100.
>
> Signed-off-by: Banajit Goswami <banajit.g@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/mach-s5pc100/Kconfig | 2 ++
> arch/arm/mach-s5pc100/include/mach/map.h | 3 +++
> arch/arm/mach-s5pc100/mach-smdkc100.c | 1 +
> 3 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pc100/Kconfig b/arch/arm/mach-s5pc100/Kconfig
> index b2a11df..b63b440 100644
> --- a/arch/arm/mach-s5pc100/Kconfig
> +++ b/arch/arm/mach-s5pc100/Kconfig
> @@ -44,6 +44,8 @@ config MACH_SMDKC100
> select S3C_DEV_HSMMC
> select S3C_DEV_HSMMC1
> select S3C_DEV_HSMMC2
> + select S3C_DEV_WDT
> + select HAVE_S3C2410_WATCHDOG
Hmm, HAVE_S3C2410_WATCHDOG should probably be property fo the SoC an
the board only needs to select S3C_DEV_WDT.
> select S5PC100_SETUP_FB_24BPP
> select S5PC100_SETUP_I2C1
> select S5PC100_SETUP_SDHCI
> diff --git a/arch/arm/mach-s5pc100/include/mach/map.h b/arch/arm/mach-s5pc100/include/mach/map.h
> index cadae43..7671baa 100644
> --- a/arch/arm/mach-s5pc100/include/mach/map.h
> +++ b/arch/arm/mach-s5pc100/include/mach/map.h
> @@ -72,6 +72,8 @@
>
> #define S5PC100_PA_SYSTIMER (0xEA100000)
>
> +#define S5PC100_PA_WDT (0xEA200000)
> +
> #define S5PC100_PA_UART (0xEC000000)
>
> #define S5P_PA_UART0 (S5PC100_PA_UART + 0x0)
> @@ -131,6 +133,7 @@
> #define S3C_PA_HSMMC2 S5PC100_PA_HSMMC(2)
> #define S3C_PA_KEYPAD S5PC100_PA_KEYPAD
> #define S3C_PA_TSADC S5PC100_PA_TSADC
> +#define S3C_PA_WDT S5PC100_PA_WDT
> #define S3C_PA_ONENAND S5PC100_PA_ONENAND
> #define S3C_PA_ONENAND_BUF S5PC100_PA_ONENAND_BUF
> #define S3C_SZ_ONENAND_BUF S5PC100_SZ_ONENAND_BUF
> diff --git a/arch/arm/mach-s5pc100/mach-smdkc100.c b/arch/arm/mach-s5pc100/mach-smdkc100.c
> index af22f82..6fc0bff 100644
> --- a/arch/arm/mach-s5pc100/mach-smdkc100.c
> +++ b/arch/arm/mach-s5pc100/mach-smdkc100.c
> @@ -156,6 +156,7 @@ static struct platform_device *smdkc100_devices[] __initdata = {
> &s3c_device_hsmmc0,
> &s3c_device_hsmmc1,
> &s3c_device_hsmmc2,
> + &s3c_device_wdt,
> &smdkc100_lcd_powerdev,
> &s5pc100_device_iis0,
> &s5pc100_device_ac97,
> --
> 1.6.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
WARNING: multiple messages have this Message-ID (diff)
From: ben@trinity.fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S5PC100: Add Watchdog support for S5PC100
Date: Tue, 1 Jun 2010 03:35:36 +0100 [thread overview]
Message-ID: <20100601023536.GA30276@trinity.fluff.org> (raw)
In-Reply-To: <1275357892-21314-1-git-send-email-kgene.kim@samsung.com>
On Tue, Jun 01, 2010 at 11:04:52AM +0900, Kukjin Kim wrote:
> From: Banajit Goswami <banajit.g@samsung.com>
>
> This patch adds support for Watchdog timer for Samsung S5PC100.
>
> Signed-off-by: Banajit Goswami <banajit.g@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/mach-s5pc100/Kconfig | 2 ++
> arch/arm/mach-s5pc100/include/mach/map.h | 3 +++
> arch/arm/mach-s5pc100/mach-smdkc100.c | 1 +
> 3 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pc100/Kconfig b/arch/arm/mach-s5pc100/Kconfig
> index b2a11df..b63b440 100644
> --- a/arch/arm/mach-s5pc100/Kconfig
> +++ b/arch/arm/mach-s5pc100/Kconfig
> @@ -44,6 +44,8 @@ config MACH_SMDKC100
> select S3C_DEV_HSMMC
> select S3C_DEV_HSMMC1
> select S3C_DEV_HSMMC2
> + select S3C_DEV_WDT
> + select HAVE_S3C2410_WATCHDOG
Hmm, HAVE_S3C2410_WATCHDOG should probably be property fo the SoC an
the board only needs to select S3C_DEV_WDT.
> select S5PC100_SETUP_FB_24BPP
> select S5PC100_SETUP_I2C1
> select S5PC100_SETUP_SDHCI
> diff --git a/arch/arm/mach-s5pc100/include/mach/map.h b/arch/arm/mach-s5pc100/include/mach/map.h
> index cadae43..7671baa 100644
> --- a/arch/arm/mach-s5pc100/include/mach/map.h
> +++ b/arch/arm/mach-s5pc100/include/mach/map.h
> @@ -72,6 +72,8 @@
>
> #define S5PC100_PA_SYSTIMER (0xEA100000)
>
> +#define S5PC100_PA_WDT (0xEA200000)
> +
> #define S5PC100_PA_UART (0xEC000000)
>
> #define S5P_PA_UART0 (S5PC100_PA_UART + 0x0)
> @@ -131,6 +133,7 @@
> #define S3C_PA_HSMMC2 S5PC100_PA_HSMMC(2)
> #define S3C_PA_KEYPAD S5PC100_PA_KEYPAD
> #define S3C_PA_TSADC S5PC100_PA_TSADC
> +#define S3C_PA_WDT S5PC100_PA_WDT
> #define S3C_PA_ONENAND S5PC100_PA_ONENAND
> #define S3C_PA_ONENAND_BUF S5PC100_PA_ONENAND_BUF
> #define S3C_SZ_ONENAND_BUF S5PC100_SZ_ONENAND_BUF
> diff --git a/arch/arm/mach-s5pc100/mach-smdkc100.c b/arch/arm/mach-s5pc100/mach-smdkc100.c
> index af22f82..6fc0bff 100644
> --- a/arch/arm/mach-s5pc100/mach-smdkc100.c
> +++ b/arch/arm/mach-s5pc100/mach-smdkc100.c
> @@ -156,6 +156,7 @@ static struct platform_device *smdkc100_devices[] __initdata = {
> &s3c_device_hsmmc0,
> &s3c_device_hsmmc1,
> &s3c_device_hsmmc2,
> + &s3c_device_wdt,
> &smdkc100_lcd_powerdev,
> &s5pc100_device_iis0,
> &s5pc100_device_ac97,
> --
> 1.6.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2010-06-01 2:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 2:04 [PATCH] ARM: S5PC100: Add Watchdog support for S5PC100 Kukjin Kim
2010-06-01 2:04 ` Kukjin Kim
2010-06-01 2:35 ` Ben Dooks [this message]
2010-06-01 2:35 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601023536.GA30276@trinity.fluff.org \
--to=ben@trinity.fluff.org \
--cc=banajit.g@samsung.com \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.