From: Ben Dooks <ben@trinity.fluff.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/6] s3c-fb: Correct FRAMESEL1 bitfield defines for
Date: Tue, 01 Jun 2010 04:17:13 +0000 [thread overview]
Message-ID: <20100601041713.GC30276@trinity.fluff.org> (raw)
In-Reply-To: <1275296935-2693-3-git-send-email-p.osciak@samsung.com>
On Mon, May 31, 2010 at 11:08:51AM +0200, Pawel Osciak wrote:
> FRAMESEL1 bitfield starts on 13th bit, not on 14th.
is this true for all variants that have FRAMESEL1?
> Signed-off-by: Pawel Osciak <p.osciak@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-fb.h | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat-samsung/include/plat/regs-fb.h
> index f4259e5..ac10013 100644
> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h
> +++ b/arch/arm/plat-samsung/include/plat/regs-fb.h
> @@ -292,11 +292,11 @@
> #define VIDINTCON0_FRAMESEL0_ACTIVE (0x2 << 15)
> #define VIDINTCON0_FRAMESEL0_FRONTPORCH (0x3 << 15)
>
> -#define VIDINTCON0_FRAMESEL1 (1 << 14)
> -#define VIDINTCON0_FRAMESEL1_NONE (0x0 << 14)
> -#define VIDINTCON0_FRAMESEL1_BACKPORCH (0x1 << 14)
> -#define VIDINTCON0_FRAMESEL1_VSYNC (0x2 << 14)
> -#define VIDINTCON0_FRAMESEL1_FRONTPORCH (0x3 << 14)
> +#define VIDINTCON0_FRAMESEL1 (1 << 13)
> +#define VIDINTCON0_FRAMESEL1_NONE (0x0 << 13)
> +#define VIDINTCON0_FRAMESEL1_BACKPORCH (0x1 << 13)
> +#define VIDINTCON0_FRAMESEL1_VSYNC (0x2 << 13)
> +#define VIDINTCON0_FRAMESEL1_FRONTPORCH (0x3 << 13)
>
> #define VIDINTCON0_INT_FRAME (1 << 12)
> #define VIDINTCON0_FIFIOSEL_MASK (0x7f << 5)
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben@trinity.fluff.org>
To: Pawel Osciak <p.osciak@samsung.com>
Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kyungmin.park@samsung.com,
ben-linux@fluff.org
Subject: Re: [PATCH 2/6] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register
Date: Tue, 1 Jun 2010 05:17:13 +0100 [thread overview]
Message-ID: <20100601041713.GC30276@trinity.fluff.org> (raw)
In-Reply-To: <1275296935-2693-3-git-send-email-p.osciak@samsung.com>
On Mon, May 31, 2010 at 11:08:51AM +0200, Pawel Osciak wrote:
> FRAMESEL1 bitfield starts on 13th bit, not on 14th.
is this true for all variants that have FRAMESEL1?
> Signed-off-by: Pawel Osciak <p.osciak@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-fb.h | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat-samsung/include/plat/regs-fb.h
> index f4259e5..ac10013 100644
> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h
> +++ b/arch/arm/plat-samsung/include/plat/regs-fb.h
> @@ -292,11 +292,11 @@
> #define VIDINTCON0_FRAMESEL0_ACTIVE (0x2 << 15)
> #define VIDINTCON0_FRAMESEL0_FRONTPORCH (0x3 << 15)
>
> -#define VIDINTCON0_FRAMESEL1 (1 << 14)
> -#define VIDINTCON0_FRAMESEL1_NONE (0x0 << 14)
> -#define VIDINTCON0_FRAMESEL1_BACKPORCH (0x1 << 14)
> -#define VIDINTCON0_FRAMESEL1_VSYNC (0x2 << 14)
> -#define VIDINTCON0_FRAMESEL1_FRONTPORCH (0x3 << 14)
> +#define VIDINTCON0_FRAMESEL1 (1 << 13)
> +#define VIDINTCON0_FRAMESEL1_NONE (0x0 << 13)
> +#define VIDINTCON0_FRAMESEL1_BACKPORCH (0x1 << 13)
> +#define VIDINTCON0_FRAMESEL1_VSYNC (0x2 << 13)
> +#define VIDINTCON0_FRAMESEL1_FRONTPORCH (0x3 << 13)
>
> #define VIDINTCON0_INT_FRAME (1 << 12)
> #define VIDINTCON0_FIFIOSEL_MASK (0x7f << 5)
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
WARNING: multiple messages have this Message-ID (diff)
From: ben@trinity.fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register
Date: Tue, 1 Jun 2010 05:17:13 +0100 [thread overview]
Message-ID: <20100601041713.GC30276@trinity.fluff.org> (raw)
In-Reply-To: <1275296935-2693-3-git-send-email-p.osciak@samsung.com>
On Mon, May 31, 2010 at 11:08:51AM +0200, Pawel Osciak wrote:
> FRAMESEL1 bitfield starts on 13th bit, not on 14th.
is this true for all variants that have FRAMESEL1?
> Signed-off-by: Pawel Osciak <p.osciak@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-fb.h | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat-samsung/include/plat/regs-fb.h
> index f4259e5..ac10013 100644
> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h
> +++ b/arch/arm/plat-samsung/include/plat/regs-fb.h
> @@ -292,11 +292,11 @@
> #define VIDINTCON0_FRAMESEL0_ACTIVE (0x2 << 15)
> #define VIDINTCON0_FRAMESEL0_FRONTPORCH (0x3 << 15)
>
> -#define VIDINTCON0_FRAMESEL1 (1 << 14)
> -#define VIDINTCON0_FRAMESEL1_NONE (0x0 << 14)
> -#define VIDINTCON0_FRAMESEL1_BACKPORCH (0x1 << 14)
> -#define VIDINTCON0_FRAMESEL1_VSYNC (0x2 << 14)
> -#define VIDINTCON0_FRAMESEL1_FRONTPORCH (0x3 << 14)
> +#define VIDINTCON0_FRAMESEL1 (1 << 13)
> +#define VIDINTCON0_FRAMESEL1_NONE (0x0 << 13)
> +#define VIDINTCON0_FRAMESEL1_BACKPORCH (0x1 << 13)
> +#define VIDINTCON0_FRAMESEL1_VSYNC (0x2 << 13)
> +#define VIDINTCON0_FRAMESEL1_FRONTPORCH (0x3 << 13)
>
> #define VIDINTCON0_INT_FRAME (1 << 12)
> #define VIDINTCON0_FIFIOSEL_MASK (0x7f << 5)
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2010-06-01 4:17 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 9:08 [PATCH 0/6] Various s3c-fb updates Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-05-31 9:08 ` [PATCH 1/6] s3c-fb: Fix various null references on framebuffer memory Pawel Osciak
2010-05-31 9:08 ` [PATCH 1/6] s3c-fb: Fix various null references on framebuffer memory alloc failure Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-05-31 9:08 ` [PATCH 2/6] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 Pawel Osciak
2010-05-31 9:08 ` [PATCH 2/6] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-06-01 4:17 ` Ben Dooks [this message]
2010-06-01 4:17 ` Ben Dooks
2010-06-01 4:17 ` Ben Dooks
2010-06-01 6:49 ` [PATCH 2/6] s3c-fb: Correct FRAMESEL1 bitfield defines for Pawel Osciak
2010-06-01 6:49 ` [PATCH 2/6] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register Pawel Osciak
2010-06-01 6:49 ` Pawel Osciak
2010-05-31 9:08 ` [PATCH 3/6] s3c-fb: Add device name initialization Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-05-31 9:08 ` [PATCH 4/6] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver Pawel Osciak
2010-05-31 9:08 ` [PATCH 4/6] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver data structures Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-05-31 9:08 ` [PATCH 5/6] s3c-fb: Add support for display panning Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-05-31 9:08 ` [PATCH 6/6] s3c-fb: Add wait for VSYNC ioctl Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-05-31 9:08 ` Pawel Osciak
2010-05-31 11:40 ` Ben Dooks
2010-05-31 11:40 ` Ben Dooks
2010-05-31 11:40 ` Ben Dooks
2010-06-11 5:32 ` [PATCH 0/6] Various s3c-fb updates Ben Dooks
2010-06-11 5:32 ` Ben Dooks
2010-06-11 5:32 ` Ben Dooks
2010-06-16 9:34 ` [PATCH v2] " Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` [PATCH 1/9] s3c-fb: Fix various null references on framebuffer memory Marek Szyprowski
2010-06-16 9:34 ` [PATCH 1/9] s3c-fb: Fix various null references on framebuffer memory alloc failure Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` [PATCH 2/9] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 Marek Szyprowski
2010-06-16 9:34 ` [PATCH 2/9] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` [PATCH 3/9] s3c-fb: Add device name initialization Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` [PATCH 4/9] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver Marek Szyprowski
2010-06-16 9:34 ` [PATCH 4/9] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver data structures Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` [PATCH 5/9] s3c-fb: Add support for display panning Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` [PATCH 6/9] s3c-fb: Add wait for VSYNC ioctl Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` [PATCH 7/9] s3c-fb: window 3 of 64xx+ does not have an osd_d register Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` [PATCH 8/9] s3c-fb: Add SHADOWCON shadow register locking support for Marek Szyprowski
2010-06-16 9:34 ` [PATCH 8/9] s3c-fb: Add SHADOWCON shadow register locking support for S5PV210 Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` [PATCH 9/9] s3c-fb: Correct window osd size and alpha register handling Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
2010-06-16 9:34 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601041713.GC30276@trinity.fluff.org \
--to=ben@trinity.fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.