From: Borislav Petkov <borislav.petkov@amd.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Dave Jones <davej@redhat.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] x86, cacheinfo: dereferences before check
Date: Tue, 01 Jun 2010 08:23:05 +0000 [thread overview]
Message-ID: <20100601082305.GA10650@aftab> (raw)
In-Reply-To: <20100601071126.GF5483@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Tue, Jun 01, 2010 at 03:11:27AM -0400
> This moves a couple dereferences after the checks in
> show_cache_disable() and store_cache_disable(). These were introduced
> fairly recently in 9350f982e4: "x86, cacheinfo: Reorganize AMD L3 cache
> structure"
Yes, this is correct, thanks. However I have a couple of patches which
rewrite and cleanup this section even more and was waiting for the merge
window to close before sending out. Stay tuned...
--
Regards/Gruss,
Boris.
Operating Systems Research Center
Advanced Micro Devices, Inc.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <borislav.petkov@amd.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<x86@kernel.org>, Dave Jones <davej@redhat.com>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [patch] x86, cacheinfo: dereferences before check
Date: Tue, 1 Jun 2010 10:23:05 +0200 [thread overview]
Message-ID: <20100601082305.GA10650@aftab> (raw)
In-Reply-To: <20100601071126.GF5483@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Tue, Jun 01, 2010 at 03:11:27AM -0400
> This moves a couple dereferences after the checks in
> show_cache_disable() and store_cache_disable(). These were introduced
> fairly recently in 9350f982e4: "x86, cacheinfo: Reorganize AMD L3 cache
> structure"
Yes, this is correct, thanks. However I have a couple of patches which
rewrite and cleanup this section even more and was waiting for the merge
window to close before sending out. Stay tuned...
--
Regards/Gruss,
Boris.
Operating Systems Research Center
Advanced Micro Devices, Inc.
next prev parent reply other threads:[~2010-06-01 8:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 7:11 [patch] x86, cacheinfo: dereferences before check Dan Carpenter
2010-06-01 7:11 ` Dan Carpenter
2010-06-01 8:23 ` Borislav Petkov [this message]
2010-06-01 8:23 ` Borislav Petkov
2010-06-02 16:09 ` [PATCH] x86, cacheinfo: Carve out L3 cache slot accessors Borislav Petkov
2010-06-02 16:09 ` Borislav Petkov
2010-06-02 16:18 ` [PATCH -v2] " Borislav Petkov
2010-06-02 16:18 ` Borislav Petkov
2010-06-10 0:10 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601082305.GA10650@aftab \
--to=borislav.petkov@amd.com \
--cc=davej@redhat.com \
--cc=error27@gmail.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.