From: Oleg Nesterov <oleg@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Nick Piggin <npiggin@suse.de>
Subject: Re: [PATCH 3/5] oom: Fix child process iteration properly
Date: Tue, 1 Jun 2010 21:27:26 +0200 [thread overview]
Message-ID: <20100601192726.GA19120@redhat.com> (raw)
In-Reply-To: <20100601144810.2440.A69D9226@jp.fujitsu.com>
On 06/01, KOSAKI Motohiro wrote:
>
> @@ -88,6 +88,7 @@ unsigned long badness(struct task_struct *p, unsigned long uptime)
> {
> unsigned long points, cpu_time, run_time;
> struct task_struct *c;
> + struct task_struct *t = p;
This initialization should be moved down to
> + do {
> + list_for_each_entry(c, &t->children, sibling) {
> + child = find_lock_task_mm(c);
> + if (child) {
> + if (child->mm != p->mm)
> + points += child->mm->total_vm/2 + 1;
> + task_unlock(child);
> + }
> }
> - }
> + } while_each_thread(p, t);
this loop. We have "p = find_lock_task_mm(p)" in between which can change p.
Apart from this, I think the whole series is nice.
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Nick Piggin <npiggin@suse.de>
Subject: Re: [PATCH 3/5] oom: Fix child process iteration properly
Date: Tue, 1 Jun 2010 21:27:26 +0200 [thread overview]
Message-ID: <20100601192726.GA19120@redhat.com> (raw)
In-Reply-To: <20100601144810.2440.A69D9226@jp.fujitsu.com>
On 06/01, KOSAKI Motohiro wrote:
>
> @@ -88,6 +88,7 @@ unsigned long badness(struct task_struct *p, unsigned long uptime)
> {
> unsigned long points, cpu_time, run_time;
> struct task_struct *c;
> + struct task_struct *t = p;
This initialization should be moved down to
> + do {
> + list_for_each_entry(c, &t->children, sibling) {
> + child = find_lock_task_mm(c);
> + if (child) {
> + if (child->mm != p->mm)
> + points += child->mm->total_vm/2 + 1;
> + task_unlock(child);
> + }
> }
> - }
> + } while_each_thread(p, t);
this loop. We have "p = find_lock_task_mm(p)" in between which can change p.
Apart from this, I think the whole series is nice.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-06-01 19:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 5:46 [PATCH 1/5] oom: make oom_unkillable() helper function KOSAKI Motohiro
2010-06-01 5:46 ` KOSAKI Motohiro
2010-06-01 5:48 ` [PATCH 2/5] oom: remove warning for in mm-less task __oom_kill_process() KOSAKI Motohiro
2010-06-01 5:48 ` KOSAKI Motohiro
2010-06-01 7:20 ` David Rientjes
2010-06-01 7:20 ` David Rientjes
2010-06-01 5:49 ` [PATCH 3/5] oom: Fix child process iteration properly KOSAKI Motohiro
2010-06-01 5:49 ` KOSAKI Motohiro
2010-06-01 19:27 ` Oleg Nesterov [this message]
2010-06-01 19:27 ` Oleg Nesterov
2010-06-02 13:53 ` KOSAKI Motohiro
2010-06-02 13:53 ` KOSAKI Motohiro
2010-06-01 5:50 ` [PATCH 4/5] oom-kill: give the dying task a higher priority (v4) KOSAKI Motohiro
2010-06-01 5:50 ` KOSAKI Motohiro
2010-06-01 5:51 ` [PATCH 5/5] oom: dump_tasks() use find_lock_task_mm() too KOSAKI Motohiro
2010-06-01 5:51 ` KOSAKI Motohiro
2010-06-02 13:54 ` KOSAKI Motohiro
2010-06-02 13:54 ` KOSAKI Motohiro
2010-06-02 15:03 ` Minchan Kim
2010-06-02 15:03 ` Minchan Kim
2010-06-03 0:06 ` KOSAKI Motohiro
2010-06-03 0:06 ` KOSAKI Motohiro
2010-06-03 0:32 ` Minchan Kim
2010-06-03 0:32 ` Minchan Kim
2010-06-03 0:41 ` KOSAKI Motohiro
2010-06-03 0:41 ` KOSAKI Motohiro
2010-06-03 0:46 ` Minchan Kim
2010-06-03 0:46 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601192726.GA19120@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.