From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, npiggin@suse.de, jack@suse.cz,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/6] introduce __block_write_begin
Date: Wed, 2 Jun 2010 01:39:50 +0200 [thread overview]
Message-ID: <20100601233950.GF8137@quack.suse.cz> (raw)
In-Reply-To: <20100530205018.GF21002@lst.de>
On Sun 30-05-10 22:50:18, Christoph Hellwig wrote:
> Split up the block_write_begin implementation - __block_write_begin is a new
> trivial wrapper for block_prepare_write that always takes an already
> allocated page and can be either called from block_write_begin or filesystem
> code that already has a page allocated. Remove the handling of already
> allocated pages from block_write_begin after switching all callers that
> do it to __block_write_begin.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/fs/buffer.c
> ===================================================================
> --- linux-2.6.orig/fs/buffer.c 2010-05-30 22:32:22.754253961 +0200
> +++ linux-2.6/fs/buffer.c 2010-05-30 22:40:16.496254519 +0200
> @@ -1833,9 +1833,10 @@ void page_zero_new_buffers(struct page *
> }
> EXPORT_SYMBOL(page_zero_new_buffers);
>
> -static int __block_prepare_write(struct inode *inode, struct page *page,
> - unsigned from, unsigned to, get_block_t *get_block)
> +int block_prepare_write(struct page *page, unsigned from, unsigned to,
> + get_block_t *get_block)
> {
> + struct inode *inode = page->mapping->host;
This new variable doesn't seem to be used...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-06-01 23:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 20:49 [PATCH 0/6] first step toward the new truncate sequence Christoph Hellwig
2010-05-30 20:49 ` [PATCH 1/6] sort out blockdev_direct_IO variants Christoph Hellwig
2010-06-01 23:00 ` Jan Kara
2010-06-01 23:12 ` Christoph Hellwig
2010-06-01 23:16 ` Jan Kara
2010-05-30 20:49 ` [PATCH 2/6] get rid of nobh_write_begin_newtrunc Christoph Hellwig
2010-05-30 20:50 ` [PATCH 3/6] get rid of cont_write_begin_newtrunc Christoph Hellwig
2010-05-30 20:50 ` [PATCH 4/6] clean up write_begin usage for directories in pagecache Christoph Hellwig
2010-05-30 20:50 ` [PATCH 5/6] introduce __block_write_begin Christoph Hellwig
2010-05-31 8:10 ` Christoph Hellwig
2010-06-01 23:39 ` Jan Kara [this message]
2010-06-02 7:25 ` Christoph Hellwig
2010-06-02 9:47 ` Jan Kara
2010-05-30 20:50 ` [PATCH 6/6] get rid of block_write_begin_newtrunc Christoph Hellwig
2010-05-31 7:13 ` [PATCH 0/6] first step toward the new truncate sequence Nick Piggin
2010-05-31 7:38 ` Christoph Hellwig
2010-05-31 7:45 ` Nick Piggin
2010-05-31 9:50 ` Boaz Harrosh
2010-05-31 10:17 ` Boaz Harrosh
2010-05-31 13:15 ` Nick Piggin
2010-05-31 13:18 ` Christoph Hellwig
2010-05-31 13:21 ` Boaz Harrosh
2010-06-01 10:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601233950.GF8137@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.