From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, npiggin@suse.de,
linux-fsdevel@vger.kernel.org, chris.mason@oracle.com
Subject: Re: [PATCH 1/6] sort out blockdev_direct_IO variants
Date: Wed, 2 Jun 2010 01:12:02 +0200 [thread overview]
Message-ID: <20100601231202.GA32382@lst.de> (raw)
In-Reply-To: <20100601230014.GC8137@quack.suse.cz>
On Wed, Jun 02, 2010 at 01:00:14AM +0200, Jan Kara wrote:
> On Sun 30-05-10 22:49:42, Christoph Hellwig wrote:
> > Move the call to vmtruncate to get rid of accessive blocks to the callers
> > in prepearation of the new truncate calling sequence. This was only done
> > for DIO_LOCKING filesystems, so the __blockdev_direct_IO_newtrunc variant
> > was not needed anyway. Get rid of blockdev_direct_IO_no_locking and
> > it's _newtrunc variant while at it as just opencoding the two additional
> > paramters is shorted than the name suffix.
> Hmm, I've noticed that you didn't add truncate code to btrfs. I see that
> it already does some recovery after direct IO error but I'd like to make
> sure that it won't be broken by your patches... Chris?
As mentioned above __blockdev_direct_IO only called vmtruncate for the
DIO_LOCKING, which does not include btrfs. And yes, there's quite a bit
of things that need cleanup but didn't have it before due to the way
the cleanup code was hidden, but that's not something I want to do
in this transformation series.
next prev parent reply other threads:[~2010-06-01 23:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 20:49 [PATCH 0/6] first step toward the new truncate sequence Christoph Hellwig
2010-05-30 20:49 ` [PATCH 1/6] sort out blockdev_direct_IO variants Christoph Hellwig
2010-06-01 23:00 ` Jan Kara
2010-06-01 23:12 ` Christoph Hellwig [this message]
2010-06-01 23:16 ` Jan Kara
2010-05-30 20:49 ` [PATCH 2/6] get rid of nobh_write_begin_newtrunc Christoph Hellwig
2010-05-30 20:50 ` [PATCH 3/6] get rid of cont_write_begin_newtrunc Christoph Hellwig
2010-05-30 20:50 ` [PATCH 4/6] clean up write_begin usage for directories in pagecache Christoph Hellwig
2010-05-30 20:50 ` [PATCH 5/6] introduce __block_write_begin Christoph Hellwig
2010-05-31 8:10 ` Christoph Hellwig
2010-06-01 23:39 ` Jan Kara
2010-06-02 7:25 ` Christoph Hellwig
2010-06-02 9:47 ` Jan Kara
2010-05-30 20:50 ` [PATCH 6/6] get rid of block_write_begin_newtrunc Christoph Hellwig
2010-05-31 7:13 ` [PATCH 0/6] first step toward the new truncate sequence Nick Piggin
2010-05-31 7:38 ` Christoph Hellwig
2010-05-31 7:45 ` Nick Piggin
2010-05-31 9:50 ` Boaz Harrosh
2010-05-31 10:17 ` Boaz Harrosh
2010-05-31 13:15 ` Nick Piggin
2010-05-31 13:18 ` Christoph Hellwig
2010-05-31 13:21 ` Boaz Harrosh
2010-06-01 10:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601231202.GA32382@lst.de \
--to=hch@lst.de \
--cc=chris.mason@oracle.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.