Re: [B.A.T.M.A.N.] [PATCH] drivers/staging/batman-adv: Convert MAC_FMT to %pM

[Sven Eckelmann <sven.eckelmann@gmx.de>]

[-- Attachment #1: Type: Text/Plain, Size: 957 bytes --]

Joe Perches wrote:
> On Thu, 2010-06-03 at 01:33 +0200, Sven Eckelmann wrote:
> > Joe Perches wrote:
> > > On Thu, 2010-06-03 at 01:23 +0200, Sven Eckelmann wrote:
> > > > You've also changed the output. So you may partly broke batctl too
> > > > (have to check that first).
> > > 
> > > There was no change in output.
> > > MAC_FMT output is the same as %pM
> > 
> > I meant the other patch :)
> 
> batctl is parsing dmesg or equivalent?  ouch.

It has functionality to parse logfiles which for example could come from 
dmesg.

> If so, may I suggest you consider using something other than
> a message logging parser for batctl?
> 
> I glanced at the source and don't see any such use.
> It looks like it's only /sys, /proc and debugfs,
> but I only spent a few seconds at it.
> 
> http://www.open-mesh.net/changeset/1682/trunk?old_path=%2F&format=zip

see sys.c -> log_print
and read_file -> read_file

Best regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]