From: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: Joonyoung Shim <jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH] i2c: Enable i2c-s3c2410 for S5P cpus
Date: Thu, 3 Jun 2010 09:46:03 +0100 [thread overview]
Message-ID: <20100603084603.GB4720@trinity.fluff.org> (raw)
In-Reply-To: <1275544623-5425-1-git-send-email-jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On Thu, Jun 03, 2010 at 02:57:03PM +0900, Joonyoung Shim wrote:
> This i2c controller driver can be used on the S5P series processors too,
> so enable the driver in Konfig for those platforms.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/i2c/busses/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 87ab056..4765d62 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -503,7 +503,7 @@ config I2C_PXA_SLAVE
>
> config I2C_S3C2410
> tristate "S3C2410 I2C Driver"
> - depends on ARCH_S3C2410 || ARCH_S3C64XX
> + depends on ARCH_S3C2410 || ARCH_S3C64XX || PLAT_S5P
It may be worth changing this to PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P
or maybe we should just enable it if PLAT_SAMSUNG
It would be good to get an policy sorted out on these core drivers which
exists across many parts of S3C/S5P supported systems.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
WARNING: multiple messages have this Message-ID (diff)
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: Enable i2c-s3c2410 for S5P cpus
Date: Thu, 3 Jun 2010 09:46:03 +0100 [thread overview]
Message-ID: <20100603084603.GB4720@trinity.fluff.org> (raw)
In-Reply-To: <1275544623-5425-1-git-send-email-jy0922.shim@samsung.com>
On Thu, Jun 03, 2010 at 02:57:03PM +0900, Joonyoung Shim wrote:
> This i2c controller driver can be used on the S5P series processors too,
> so enable the driver in Konfig for those platforms.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/i2c/busses/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 87ab056..4765d62 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -503,7 +503,7 @@ config I2C_PXA_SLAVE
>
> config I2C_S3C2410
> tristate "S3C2410 I2C Driver"
> - depends on ARCH_S3C2410 || ARCH_S3C64XX
> + depends on ARCH_S3C2410 || ARCH_S3C64XX || PLAT_S5P
It may be worth changing this to PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P
or maybe we should just enable it if PLAT_SAMSUNG
It would be good to get an policy sorted out on these core drivers which
exists across many parts of S3C/S5P supported systems.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2010-06-03 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 5:57 [PATCH] i2c: Enable i2c-s3c2410 for S5P cpus Joonyoung Shim
2010-06-03 5:57 ` Joonyoung Shim
[not found] ` <1275544623-5425-1-git-send-email-jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2010-06-03 8:46 ` Ben Dooks [this message]
2010-06-03 8:46 ` Ben Dooks
[not found] ` <20100603084603.GB4720-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-06-03 10:27 ` Joonyoung Shim
2010-06-03 10:27 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603084603.GB4720@trinity.fluff.org \
--to=ben-linux-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
--cc=jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.