All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Doyu Hiroshi (Nokia-D/Helsinki)" <hiroshi.doyu@nokia.com>,
	"felipe.contreras@gmail.com" <felipe.contreras@gmail.com>,
	"tony@atomide.com" <tony@atomide.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 00/14] omap: mailbox: bunch of cleanups
Date: Thu, 3 Jun 2010 14:56:18 +0300	[thread overview]
Message-ID: <20100603115618.GT11078@nokia.com> (raw)
In-Reply-To: <20100603114726.GC7127@n2100.arm.linux.org.uk>

Hi,

On Thu, Jun 03, 2010 at 01:47:26PM +0200, ext Russell King - ARM Linux wrote:
>I think folk need to read this:
>
>	http://lkml.org/lkml/2010/6/2/472
>
>and consider what it means for the future, and what can be done to reduce
>the amount of "churn".

I believe Linus is considering more the amount of files not the amount 
of patches. Personally, I consider trivial cleanup patches the best way 
to start off with a new code (not saying that Felipe C. is new to mbox 
driver) and those patches are as needed as a brand new feature.

One thing to decrease the amount of lines of code in arch/arm is to move 
the drivers to they're proper locations on the tree. Only on omap we 
have 6 platform_drivers that could (should) be moved to proper 
locations after a 'trivial cleanups'.

gpio.c mcbsp.c timer drivers (for clocksource) etc, which alone would 
mean a decrease of 6237 lines out of arch/arm/*omap* only. And I'm not 
even counting the drivers which aren't platform_drivers.

The thing is that ARM is really different than x86 and there's no 
standardization among different SoCs, so other than moving drivers out 
of arch/arm, there isn't much we can do. Or do you have any ideas ?

-- 
balbi

DefectiveByDesign.org

WARNING: multiple messages have this Message-ID (diff)
From: felipe.balbi@nokia.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 00/14] omap: mailbox: bunch of cleanups
Date: Thu, 3 Jun 2010 14:56:18 +0300	[thread overview]
Message-ID: <20100603115618.GT11078@nokia.com> (raw)
In-Reply-To: <20100603114726.GC7127@n2100.arm.linux.org.uk>

Hi,

On Thu, Jun 03, 2010 at 01:47:26PM +0200, ext Russell King - ARM Linux wrote:
>I think folk need to read this:
>
>	http://lkml.org/lkml/2010/6/2/472
>
>and consider what it means for the future, and what can be done to reduce
>the amount of "churn".

I believe Linus is considering more the amount of files not the amount 
of patches. Personally, I consider trivial cleanup patches the best way 
to start off with a new code (not saying that Felipe C. is new to mbox 
driver) and those patches are as needed as a brand new feature.

One thing to decrease the amount of lines of code in arch/arm is to move 
the drivers to they're proper locations on the tree. Only on omap we 
have 6 platform_drivers that could (should) be moved to proper 
locations after a 'trivial cleanups'.

gpio.c mcbsp.c timer drivers (for clocksource) etc, which alone would 
mean a decrease of 6237 lines out of arch/arm/*omap* only. And I'm not 
even counting the drivers which aren't platform_drivers.

The thing is that ARM is really different than x86 and there's no 
standardization among different SoCs, so other than moving drivers out 
of arch/arm, there isn't much we can do. Or do you have any ideas ?

-- 
balbi

DefectiveByDesign.org

  reply	other threads:[~2010-06-03 11:57 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-22 17:14 [PATCH v3 00/14] omap: mailbox: bunch of cleanups Felipe Contreras
2010-05-22 17:14 ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 01/14] omap: mailbox: trivial whitespace cleanups Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-24 10:56   ` Hiroshi DOYU
2010-05-24 10:56     ` Hiroshi DOYU
2010-05-22 17:14 ` [PATCH v3 02/14] omap: mailbox: trivial cleanups Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 03/14] omap: mailbox: reorganize structures Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 04/14] omap: mailbox: 2420 should be detected at run-time Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 05/14] omap: mailbox: use correct config for omap1 Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 06/14] omap: mailbox: update omap1 probing Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 07/14] omap: mailbox: don't export unecessary symbols Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 08/14] omap: mailbox: remove unecessary fields Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 09/14] omap: mailbox: add IRQ names Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 10/14] omap: mailbox: reorganize registering Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-24 15:24   ` Hiroshi DOYU
2010-05-24 15:24     ` Hiroshi DOYU
2010-05-24 18:32     ` Russell King - ARM Linux
2010-05-24 18:32       ` Russell King - ARM Linux
2010-05-24 19:17       ` Felipe Contreras
2010-05-24 19:17         ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 11/14] omap: mailbox: only compile for configured archs Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-24 14:42   ` Hiroshi DOYU
2010-05-24 14:42     ` Hiroshi DOYU
2010-05-24 19:29     ` Felipe Contreras
2010-05-24 19:29       ` Felipe Contreras
2010-05-24 21:00       ` Russell King - ARM Linux
2010-05-24 21:00         ` Russell King - ARM Linux
2010-05-22 17:14 ` [PATCH v3 12/14] omap: mailbox: standarize on 'omap-mailbox' Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 13/14] omap: mailbox: simplify omap_mbox_register() Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-24 14:42   ` Hiroshi DOYU
2010-05-24 14:42     ` Hiroshi DOYU
2010-06-11 15:17     ` Felipe Contreras
2010-06-11 15:17       ` Felipe Contreras
2010-06-11 15:19       ` Felipe Contreras
2010-06-11 15:19         ` Felipe Contreras
2010-05-24 15:14   ` Hiroshi DOYU
2010-05-24 15:14     ` Hiroshi DOYU
2010-05-22 17:14 ` [PATCH v3 14/14] omap: mailbox: reorganize headers Felipe Contreras
2010-05-22 17:14   ` Felipe Contreras
2010-05-24 17:16   ` Felipe Balbi
2010-05-24 17:16     ` Felipe Balbi
2010-05-24 19:14     ` Felipe Contreras
2010-05-24 19:14       ` Felipe Contreras
2010-05-25  5:49       ` Felipe Balbi
2010-05-25  5:49         ` Felipe Balbi
2010-05-25 18:04         ` Felipe Contreras
2010-05-25 18:04           ` Felipe Contreras
2010-06-03  6:40 ` [PATCH v3 00/14] omap: mailbox: bunch of cleanups Hiroshi DOYU
2010-06-03  6:40   ` Hiroshi DOYU
2010-06-03 10:23   ` Felipe Contreras
2010-06-03 10:23     ` Felipe Contreras
2010-06-03 10:59     ` Hiroshi DOYU
2010-06-03 10:59       ` Hiroshi DOYU
2010-06-03 11:47   ` Russell King - ARM Linux
2010-06-03 11:47     ` Russell King - ARM Linux
2010-06-03 11:56     ` Felipe Balbi [this message]
2010-06-03 11:56       ` Felipe Balbi
2010-06-03 12:05     ` Baruch Siach
2010-06-03 12:05       ` Baruch Siach
2010-06-03 14:59     ` Felipe Contreras
2010-06-03 14:59       ` Felipe Contreras
2010-06-03 16:15       ` Tony Lindgren
2010-06-03 16:15         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100603115618.GT11078@nokia.com \
    --to=felipe.balbi@nokia.com \
    --cc=felipe.contreras@gmail.com \
    --cc=hiroshi.doyu@nokia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.