From: Greg KH <greg@kroah.com>
To: Johan Hovold <jhovold@gmail.com>
Cc: Julia Lawall <julia@diku.dk>, Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 11/11] drivers/usb/serial: Eliminate a NULL pointer
Date: Thu, 03 Jun 2010 17:45:58 +0000 [thread overview]
Message-ID: <20100603174558.GA3834@kroah.com> (raw)
In-Reply-To: <20100527131539.GA26198@localhost>
On Thu, May 27, 2010 at 03:15:39PM +0200, Johan Hovold wrote:
> Hi Julia,
>
> On Thu, May 27, 2010 at 02:37:39PM +0200, Julia Lawall wrote:
> > From: Julia Lawall <julia@diku.dk>
> >
> > The assignment seems completely unnecessary if mos7840_port is NULL.
> >
> [...]
> > ---
> > drivers/usb/serial/mos7840.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> > index f8424d1..585b7e6 100644
> > --- a/drivers/usb/serial/mos7840.c
> > +++ b/drivers/usb/serial/mos7840.c
> > @@ -730,7 +730,6 @@ static void mos7840_bulk_in_callback(struct urb *urb)
> > mos7840_port = urb->context;
> > if (!mos7840_port) {
> > dbg("%s", "NULL mos7840_port pointer");
> > - mos7840_port->read_urb_busy = false;
> > return;
> > }
>
> I stumbled over this one a couple of weeks ago. There a patch sitting in
> Greg's queue already:
>
> http://thread.gmane.org/gmane.linux.usb.general/31668
Which is now in my tree.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Johan Hovold <jhovold@gmail.com>
Cc: Julia Lawall <julia@diku.dk>, Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 11/11] drivers/usb/serial: Eliminate a NULL pointer dereference
Date: Thu, 3 Jun 2010 10:45:58 -0700 [thread overview]
Message-ID: <20100603174558.GA3834@kroah.com> (raw)
In-Reply-To: <20100527131539.GA26198@localhost>
On Thu, May 27, 2010 at 03:15:39PM +0200, Johan Hovold wrote:
> Hi Julia,
>
> On Thu, May 27, 2010 at 02:37:39PM +0200, Julia Lawall wrote:
> > From: Julia Lawall <julia@diku.dk>
> >
> > The assignment seems completely unnecessary if mos7840_port is NULL.
> >
> [...]
> > ---
> > drivers/usb/serial/mos7840.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> > index f8424d1..585b7e6 100644
> > --- a/drivers/usb/serial/mos7840.c
> > +++ b/drivers/usb/serial/mos7840.c
> > @@ -730,7 +730,6 @@ static void mos7840_bulk_in_callback(struct urb *urb)
> > mos7840_port = urb->context;
> > if (!mos7840_port) {
> > dbg("%s", "NULL mos7840_port pointer");
> > - mos7840_port->read_urb_busy = false;
> > return;
> > }
>
> I stumbled over this one a couple of weeks ago. There a patch sitting in
> Greg's queue already:
>
> http://thread.gmane.org/gmane.linux.usb.general/31668
Which is now in my tree.
thanks,
greg k-h
next prev parent reply other threads:[~2010-06-03 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 12:37 [PATCH 11/11] drivers/usb/serial: Eliminate a NULL pointer dereference Julia Lawall
2010-05-27 12:37 ` Julia Lawall
2010-05-27 13:15 ` [PATCH 11/11] drivers/usb/serial: Eliminate a NULL pointer Johan Hovold
2010-05-27 13:15 ` [PATCH 11/11] drivers/usb/serial: Eliminate a NULL pointer dereference Johan Hovold
2010-06-03 17:45 ` Greg KH [this message]
2010-06-03 17:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603174558.GA3834@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jhovold@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.