* [PATCH 2.6.35/stable] TP_STORE_SIGINFO(SEND_SIG_FORCED) == OOPS
@ 2010-06-03 21:34 Oleg Nesterov
2010-06-03 22:35 ` Roland McGrath
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Oleg Nesterov @ 2010-06-03 21:34 UTC (permalink / raw)
To: Andrew Morton
Cc: Ingo Molnar, Jason Baron, Masami Hiramatsu, Roland McGrath,
linux-kernel, stable
BUG: unable to handle kernel NULL pointer dereference at 0000000000000006
IP: [<ffffffff8107bd37>] ftrace_raw_event_signal_generate+0x87/0x140
TP_STORE_SIGINFO() forgets about SEND_SIG_FORCED, fix.
We should probably export is_si_special() and change TP_STORE_SIGINFO()
to use it.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
include/trace/events/signal.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- 34-rc1/include/trace/events/signal.h~TP_STORE_SIGINFO 2009-12-18 19:05:38.000000000 +0100
+++ 34-rc1/include/trace/events/signal.h 2010-06-03 23:24:07.000000000 +0200
@@ -10,7 +10,8 @@
#define TP_STORE_SIGINFO(__entry, info) \
do { \
- if (info == SEND_SIG_NOINFO) { \
+ if (info == SEND_SIG_NOINFO || \
+ info == SEND_SIG_FORCED) { \
__entry->errno = 0; \
__entry->code = SI_USER; \
} else if (info == SEND_SIG_PRIV) { \
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.35/stable] TP_STORE_SIGINFO(SEND_SIG_FORCED) == OOPS
2010-06-03 21:34 [PATCH 2.6.35/stable] TP_STORE_SIGINFO(SEND_SIG_FORCED) == OOPS Oleg Nesterov
@ 2010-06-03 22:35 ` Roland McGrath
2010-06-08 21:07 ` Frederic Weisbecker
2010-06-09 5:24 ` [tip:perf/urgent] tracing: Fix null pointer deref with SEND_SIG_FORCED tip-bot for Oleg Nesterov
2 siblings, 0 replies; 4+ messages in thread
From: Roland McGrath @ 2010-06-03 22:35 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Ingo Molnar, Jason Baron, Masami Hiramatsu,
linux-kernel, stable
Acked-by: Roland McGrath <roland@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.35/stable] TP_STORE_SIGINFO(SEND_SIG_FORCED) == OOPS
2010-06-03 21:34 [PATCH 2.6.35/stable] TP_STORE_SIGINFO(SEND_SIG_FORCED) == OOPS Oleg Nesterov
2010-06-03 22:35 ` Roland McGrath
@ 2010-06-08 21:07 ` Frederic Weisbecker
2010-06-09 5:24 ` [tip:perf/urgent] tracing: Fix null pointer deref with SEND_SIG_FORCED tip-bot for Oleg Nesterov
2 siblings, 0 replies; 4+ messages in thread
From: Frederic Weisbecker @ 2010-06-08 21:07 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Ingo Molnar, Jason Baron, Masami Hiramatsu,
Roland McGrath, linux-kernel, stable
On Thu, Jun 03, 2010 at 11:34:09PM +0200, Oleg Nesterov wrote:
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000006
> IP: [<ffffffff8107bd37>] ftrace_raw_event_signal_generate+0x87/0x140
>
> TP_STORE_SIGINFO() forgets about SEND_SIG_FORCED, fix.
>
> We should probably export is_si_special() and change TP_STORE_SIGINFO()
> to use it.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Queued, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perf/urgent] tracing: Fix null pointer deref with SEND_SIG_FORCED
2010-06-03 21:34 [PATCH 2.6.35/stable] TP_STORE_SIGINFO(SEND_SIG_FORCED) == OOPS Oleg Nesterov
2010-06-03 22:35 ` Roland McGrath
2010-06-08 21:07 ` Frederic Weisbecker
@ 2010-06-09 5:24 ` tip-bot for Oleg Nesterov
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Oleg Nesterov @ 2010-06-09 5:24 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, fweisbec, roland, rostedt, akpm, stable,
tglx, oleg, jbaron, mhiramat
Commit-ID: b9b76dfaac6fa2c289ee8a005be637afd2da7e2f
Gitweb: http://git.kernel.org/tip/b9b76dfaac6fa2c289ee8a005be637afd2da7e2f
Author: Oleg Nesterov <oleg@redhat.com>
AuthorDate: Thu, 3 Jun 2010 23:34:09 +0200
Committer: Frederic Weisbecker <fweisbec@gmail.com>
CommitDate: Tue, 8 Jun 2010 23:51:32 +0200
tracing: Fix null pointer deref with SEND_SIG_FORCED
BUG: unable to handle kernel NULL pointer dereference at
0000000000000006
IP: [<ffffffff8107bd37>] ftrace_raw_event_signal_generate+0x87/0x140
TP_STORE_SIGINFO() forgets about SEND_SIG_FORCED, fix.
We should probably export is_si_special() and change TP_STORE_SIGINFO()
to use it in the longer term.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jason Baron <jbaron@redhat.com>
Cc: Masami Hiramatsu <mhiramat@redhat.com>
Cc: 2.6.33.x-2.6.34.x <stable@kernel.org>
LKML-Reference: <20100603213409.GA8307@redhat.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
include/trace/events/signal.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/trace/events/signal.h b/include/trace/events/signal.h
index 814566c..17df434 100644
--- a/include/trace/events/signal.h
+++ b/include/trace/events/signal.h
@@ -10,7 +10,8 @@
#define TP_STORE_SIGINFO(__entry, info) \
do { \
- if (info == SEND_SIG_NOINFO) { \
+ if (info == SEND_SIG_NOINFO || \
+ info == SEND_SIG_FORCED) { \
__entry->errno = 0; \
__entry->code = SI_USER; \
} else if (info == SEND_SIG_PRIV) { \
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-06-09 5:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03 21:34 [PATCH 2.6.35/stable] TP_STORE_SIGINFO(SEND_SIG_FORCED) == OOPS Oleg Nesterov
2010-06-03 22:35 ` Roland McGrath
2010-06-08 21:07 ` Frederic Weisbecker
2010-06-09 5:24 ` [tip:perf/urgent] tracing: Fix null pointer deref with SEND_SIG_FORCED tip-bot for Oleg Nesterov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.